diff options
| author | Péter Szilágyi <peterke@gmail.com> | 2015-05-16 01:54:10 +0800 |
|---|---|---|
| committer | Péter Szilágyi <peterke@gmail.com> | 2015-05-16 01:54:10 +0800 |
| commit | f3ae8f50a5dfafa667fbe5e6a6574e69162d5ee6 (patch) | |
| tree | 0864261e6b3de3294689364ca5c9572d35f45e1e | |
| parent | 98998534cb0f415fb85826d60607652240022c57 (diff) | |
| download | dexon-f3ae8f50a5dfafa667fbe5e6a6574e69162d5ee6.tar.gz dexon-f3ae8f50a5dfafa667fbe5e6a6574e69162d5ee6.tar.zst dexon-f3ae8f50a5dfafa667fbe5e6a6574e69162d5ee6.zip | |
eth/downloader: circumvent download race between crosscheck and hashes
| -rw-r--r-- | eth/downloader/downloader.go | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/eth/downloader/downloader.go b/eth/downloader/downloader.go index a0a5b20a2..1bc81406c 100644 --- a/eth/downloader/downloader.go +++ b/eth/downloader/downloader.go @@ -284,12 +284,14 @@ func (d *Downloader) fetchHashes(p *peer, h common.Hash) error { } if !done { // Try and fetch a random block to verify the hash batch - cross := inserts[rand.Intn(len(inserts))] - glog.V(logger.Detail).Infof("Cross checking (%s) with %x", active.id, cross) - - d.checks[cross] = time.Now().Add(blockTTL) - active.getBlocks([]common.Hash{cross}) + // Skip the last hash as the cross check races with the next hash fetch + if len(inserts) > 1 { + cross := inserts[rand.Intn(len(inserts)-1)] + glog.V(logger.Detail).Infof("Cross checking (%s) with %x", active.id, cross) + d.checks[cross] = time.Now().Add(blockTTL) + active.getBlocks([]common.Hash{cross}) + } // Also fetch a fresh active.getHashes(head) continue |