diff options
| author | Anton Evangelatov <anton.evangelatov@gmail.com> | 2018-03-02 01:55:31 +0800 |
|---|---|---|
| committer | Péter Szilágyi <peterke@gmail.com> | 2018-03-02 01:55:31 +0800 |
| commit | 3ca3fffdf01b94244ef6c2d93ed38a30da9fcb0a (patch) | |
| tree | 54b0c90df29bcb1a4e864285a21415211bd4b113 | |
| parent | 5a150e1b7724c91009a237ab0879cd64844b390d (diff) | |
| download | dexon-3ca3fffdf01b94244ef6c2d93ed38a30da9fcb0a.tar.gz dexon-3ca3fffdf01b94244ef6c2d93ed38a30da9fcb0a.tar.zst dexon-3ca3fffdf01b94244ef6c2d93ed38a30da9fcb0a.zip | |
metrics: fix flaky Example metrics test (#16222)
* metrics: add sleep to test in order to get predictable output
* metrics: relax constraints on timer test
| -rw-r--r-- | metrics/metrics_test.go | 3 | ||||
| -rw-r--r-- | metrics/timer_test.go | 4 |
2 files changed, 4 insertions, 3 deletions
diff --git a/metrics/metrics_test.go b/metrics/metrics_test.go index 726fba347..df36da0ad 100644 --- a/metrics/metrics_test.go +++ b/metrics/metrics_test.go @@ -6,6 +6,7 @@ import ( "log" "sync" "testing" + "time" ) const FANOUT = 128 @@ -114,7 +115,7 @@ func Example() { // Threadsafe registration t := GetOrRegisterTimer("db.get.latency", nil) - t.Time(func() {}) + t.Time(func() { time.Sleep(10 * time.Millisecond) }) t.Update(1) fmt.Println(c.Count()) diff --git a/metrics/timer_test.go b/metrics/timer_test.go index f85c9b803..c1f0ff938 100644 --- a/metrics/timer_test.go +++ b/metrics/timer_test.go @@ -47,8 +47,8 @@ func TestTimerStop(t *testing.T) { func TestTimerFunc(t *testing.T) { tm := NewTimer() tm.Time(func() { time.Sleep(50e6) }) - if max := tm.Max(); 45e6 > max || max > 55e6 { - t.Errorf("tm.Max(): 45e6 > %v || %v > 55e6\n", max, max) + if max := tm.Max(); 35e6 > max || max > 95e6 { + t.Errorf("tm.Max(): 35e6 > %v || %v > 95e6\n", max, max) } } |