diff options
| author | bas-vk <bas-vk@users.noreply.github.com> | 2016-12-11 07:01:57 +0800 |
|---|---|---|
| committer | Felix Lange <fjl@users.noreply.github.com> | 2016-12-11 07:01:57 +0800 |
| commit | 4f9ccdd70f69dd0a879329d57ec21588f29f182c (patch) | |
| tree | 485d305d44c364b93a4c6a06505803bb97ba70af /build/nsis.geth.nsi | |
| parent | 4e36b1e3dadda62a53e309a1b6cf7aed97ea7a3a (diff) | |
| download | dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.tar.gz dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.tar.zst dexon-4f9ccdd70f69dd0a879329d57ec21588f29f182c.zip | |
build: safe update of PATH on Windows (#3419)
NSIS has a default MAX_STR_LEN of 1024. If $ENV{PATH} is longer
the returned string is truncated to an empty string. Its then not
possible to distinguis between the variable not set or too long.
As a result the variable is set with the location where geth and/or
dev tools are installed. This may override any previous set values.
Diffstat (limited to 'build/nsis.geth.nsi')
| -rw-r--r-- | build/nsis.geth.nsi | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/build/nsis.geth.nsi b/build/nsis.geth.nsi index dbeb9319c..1034f3023 100644 --- a/build/nsis.geth.nsi +++ b/build/nsis.geth.nsi @@ -17,8 +17,12 @@ # # Requirements: # - NSIS, http://nsis.sourceforge.net/Main_Page +# - NSIS Large Strings build, http://nsis.sourceforge.net/Special_Builds # - SFP, http://nsis.sourceforge.net/NSIS_Simple_Firewall_Plugin (put dll in NSIS\Plugins\x86-ansi) # +# After intalling NSIS extra the NSIS Large Strings build zip and replace the makensis.exe and the +# files found in Stub. +# # based on: http://nsis.sourceforge.net/A_simple_installer_with_start_menu_shortcut_and_uninstaller # # TODO: @@ -37,6 +41,7 @@ RequestExecutionLevel admin SetCompressor /SOLID lzma !include LogicLib.nsh +!include PathUpdate.nsh !include EnvVarUpdate.nsh !macro VerifyUserIsAdmin |