aboutsummaryrefslogtreecommitdiffstats
path: root/core/vm
diff options
context:
space:
mode:
authorWei-Ning Huang <w@dexon.org>2018-11-19 22:08:53 +0800
committerWei-Ning Huang <w@dexon.org>2019-03-12 12:19:09 +0800
commitb2b6382ec557ab0895a1bbfe053a265fb470ec81 (patch)
tree476fc8d240ece0c2d7ae2e94efb32ac6dfaf6211 /core/vm
parent9181d784fb453423c1a7dafe7c182feafd437376 (diff)
downloaddexon-b2b6382ec557ab0895a1bbfe053a265fb470ec81.tar.gz
dexon-b2b6382ec557ab0895a1bbfe053a265fb470ec81.tar.zst
dexon-b2b6382ec557ab0895a1bbfe053a265fb470ec81.zip
core: vm: change offset type to int256
Since we use -1 to represent the offset of empty value, we should make the return type int256 instead of uint256.
Diffstat (limited to 'core/vm')
-rw-r--r--core/vm/governance.go9
1 files changed, 7 insertions, 2 deletions
diff --git a/core/vm/governance.go b/core/vm/governance.go
index 36b37b53c..f4c2f4d93 100644
--- a/core/vm/governance.go
+++ b/core/vm/governance.go
@@ -56,7 +56,7 @@ const GovernanceABIJSON = `
"outputs": [
{
"name": "",
- "type": "uint256"
+ "type": "int256"
}
],
"payable": false,
@@ -313,7 +313,7 @@ const GovernanceABIJSON = `
"outputs": [
{
"name": "",
- "type": "uint256"
+ "type": "int256"
}
],
"payable": false,
@@ -2044,6 +2044,11 @@ func (g *GovernanceContract) delegate(nodeAddr common.Address) ([]byte, error) {
caller := g.contract.Caller()
value := g.contract.Value()
+ // Can not delegate if no fund was sent.
+ if value.Cmp(big.NewInt(0)) == 0 {
+ return nil, errExecutionReverted
+ }
+
// Can not delegate if already delegated.
delegatorOffset := g.state.DelegatorsOffset(nodeAddr, caller)
if delegatorOffset.Cmp(big.NewInt(0)) >= 0 {