diff options
| author | Felix Lange <fjl@users.noreply.github.com> | 2017-12-12 05:49:09 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-12-12 05:49:09 +0800 |
| commit | 1a32bdf92cceb7a42e5636e12d95609e17b8f786 (patch) | |
| tree | b46644b4e2cd5cfdb44f8ede88c66c05fbbaec9c /crypto/crypto.go | |
| parent | 2499b1b139d82f2f266ce9c79aebca1568396a51 (diff) | |
| download | dexon-1a32bdf92cceb7a42e5636e12d95609e17b8f786.tar.gz dexon-1a32bdf92cceb7a42e5636e12d95609e17b8f786.tar.zst dexon-1a32bdf92cceb7a42e5636e12d95609e17b8f786.zip | |
crypto: fix error check in toECDSA (#15632)
With this change,
key, err := crypto.HexToECDSA("000000...")
returns nil key and an error instead of a non-nil key with nil X
and Y inside. Issue found by @guidovranken.
Diffstat (limited to 'crypto/crypto.go')
| -rw-r--r-- | crypto/crypto.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/crypto/crypto.go b/crypto/crypto.go index 8161769d3..3a98bfb50 100644 --- a/crypto/crypto.go +++ b/crypto/crypto.go @@ -98,6 +98,9 @@ func toECDSA(d []byte, strict bool) (*ecdsa.PrivateKey, error) { } priv.D = new(big.Int).SetBytes(d) priv.PublicKey.X, priv.PublicKey.Y = priv.PublicKey.Curve.ScalarBaseMult(d) + if priv.PublicKey.X == nil { + return nil, errors.New("invalid private key") + } return priv, nil } |