diff options
| author | Felix Lange <fjl@users.noreply.github.com> | 2018-04-10 21:33:25 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2018-04-10 21:33:25 +0800 |
| commit | 3caf16b15f0b6a30717acb245fa8d347b2f06c3f (patch) | |
| tree | 27488ad46d7238aa7be09b8644d93cc704e84da8 /tests/state_test.go | |
| parent | 30deb6067fa5882ff6b2d0ead723eae833127490 (diff) | |
| download | dexon-3caf16b15f0b6a30717acb245fa8d347b2f06c3f.tar.gz dexon-3caf16b15f0b6a30717acb245fa8d347b2f06c3f.tar.zst dexon-3caf16b15f0b6a30717acb245fa8d347b2f06c3f.zip | |
core: remove stray account creations in state transition (#16470)
The 'from' and 'to' methods on StateTransitions are reader methods and
shouldn't have inadvertent side effects on state.
It is safe to remove the check in 'from' because account existence is
implicitly checked by the nonce and balance checks. If the account has
non-zero balance or nonce, it must exist. Even if the sender account has
nonce zero at the start of the state transition or no balance, the nonce
is incremented before execution and the account will be created at that
time.
It is safe to remove the check in 'to' because the EVM creates the
account if necessary.
Fixes #15119
Diffstat (limited to 'tests/state_test.go')
| -rw-r--r-- | tests/state_test.go | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tests/state_test.go b/tests/state_test.go index 3fd3ce43a..adec4feb2 100644 --- a/tests/state_test.go +++ b/tests/state_test.go @@ -37,7 +37,6 @@ func TestState(t *testing.T) { // Expected failures: st.fails(`^stRevertTest/RevertPrecompiledTouch\.json/EIP158`, "bug in test") st.fails(`^stRevertTest/RevertPrecompiledTouch\.json/Byzantium`, "bug in test") - st.fails(`^stRandom2/randomStatetest64[45]\.json/(EIP150|Frontier|Homestead)/.*`, "known bug #15119") st.walk(t, stateTestDir, func(t *testing.T, name string, test *StateTest) { for _, subtest := range test.Subtests() { |