aboutsummaryrefslogtreecommitdiffstats
path: root/p2p/peer.go
Commit message (Collapse)AuthorAgeFilesLines
* p2p: add enode URL to PeerInfo (#17838)Felix Lange2018-10-041-3/+5
|
* all: new p2p node representation (#17643)Felix Lange2018-09-251-14/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Package p2p/enode provides a generalized representation of p2p nodes which can contain arbitrary information in key/value pairs. It is also the new home for the node database. The "v4" identity scheme is also moved here from p2p/enr to remove the dependency on Ethereum crypto from that package. Record signature handling is changed significantly. The identity scheme registry is removed and acceptable schemes must be passed to any method that needs identity. This means records must now be validated explicitly after decoding. The enode API is designed to make signature handling easy and safe: most APIs around the codebase work with enode.Node, which is a wrapper around a valid record. Going from enr.Record to enode.Node requires a valid signature. * p2p/discover: port to p2p/enode This ports the discovery code to the new node representation in p2p/enode. The wire protocol is unchanged, this can be considered a refactoring change. The Kademlia table can now deal with nodes using an arbitrary identity scheme. This requires a few incompatible API changes: - Table.Lookup is not available anymore. It used to take a public key as argument because v4 protocol requires one. Its replacement is LookupRandom. - Table.Resolve takes *enode.Node instead of NodeID. This is also for v4 protocol compatibility because nodes cannot be looked up by ID alone. - Types Node and NodeID are gone. Further commits in the series will be fixes all over the the codebase to deal with those removals. * p2p: port to p2p/enode and discovery changes This adapts package p2p to the changes in p2p/discover. All uses of discover.Node and discover.NodeID are replaced by their equivalents from p2p/enode. New API is added to retrieve the enode.Node instance of a peer. The behavior of Server.Self with discovery disabled is improved. It now tries much harder to report a working IP address, falling back to 127.0.0.1 if no suitable address can be determined through other means. These changes were needed for tests of other packages later in the series. * p2p/simulations, p2p/testing: port to p2p/enode No surprises here, mostly replacements of discover.Node, discover.NodeID with their new equivalents. The 'interesting' API changes are: - testing.ProtocolSession tracks complete nodes, not just their IDs. - adapters.NodeConfig has a new method to create a complete node. These changes were needed to make swarm tests work. Note that the NodeID change makes the code incompatible with old simulation snapshots. * whisper/whisperv5, whisper/whisperv6: port to p2p/enode This port was easy because whisper uses []byte for node IDs and URL strings in the API. * eth: port to p2p/enode Again, easy to port because eth uses strings for node IDs and doesn't care about node information in any way. * les: port to p2p/enode Apart from replacing discover.NodeID with enode.ID, most changes are in the server pool code. It now deals with complete nodes instead of (Pubkey, IP, Port) triples. The database format is unchanged for now, but we should probably change it to use the node database later. * node: port to p2p/enode This change simply replaces discover.Node and discover.NodeID with their new equivalents. * swarm/network: port to p2p/enode Swarm has its own node address representation, BzzAddr, containing both an overlay address (the hash of a secp256k1 public key) and an underlay address (enode:// URL). There are no changes to the BzzAddr format in this commit, but certain operations such as creating a BzzAddr from a node ID are now impossible because node IDs aren't public keys anymore. Most swarm-related changes in the series remove uses of NewAddrFromNodeID, replacing it with NewAddr which takes a complete node as argument. ToOverlayAddr is removed because we can just use the node ID directly.
* Merge pull request #16333 from shazow/addremovetrustedpeerFelföldi Zsolt2018-08-061-1/+1
|\ | | | | rpc: Add admin_addTrustedPeer and admin_removeTrustedPeer.
| * p2p: Wrap conn.flags ops with atomic.Load/StoreAndrey Petrov2018-06-221-14/+12
| |
| * p2p: Cache inbound flag on Peer.isInbound to avoid a raceAndrey Petrov2018-06-221-12/+14
| |
* | p2p: correct comments typo (#17184)jkcomment2018-07-181-1/+1
| |
* | swarm: network rewrite mergeethersphere2018-06-221-1/+6
|/
* p2p: don't discard reason set by Disconnect (#16559)Guilherme Salgado2018-05-091-0/+1
| | | | Peer.run was discarding the reason for disconnection sent to the disc channel by Disconnect.
* build: enable goimports and varcheck linters (#16446)thomasmodeneis2018-04-181-2/+0
|
* p2p, p2p/discover: misc connectivity improvements (#16069)Felix Lange2018-02-121-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * p2p: add DialRatio for configuration of inbound vs. dialed connections * p2p: add connection flags to PeerInfo * p2p/netutil: add SameNet, DistinctNetSet * p2p/discover: improve revalidation and seeding This changes node revalidation to be periodic instead of on-demand. This should prevent issues where dead nodes get stuck in closer buckets because no other node will ever come along to replace them. Every 5 seconds (on average), the last node in a random bucket is checked and moved to the front of the bucket if it is still responding. If revalidation fails, the last node is replaced by an entry of the 'replacement list' containing recently-seen nodes. Most close buckets are removed because it's very unlikely we'll ever encounter a node that would fall into any of those buckets. Table seeding is also improved: we now require a few minutes of table membership before considering a node as a potential seed node. This should make it less likely to store short-lived nodes as potential seeds. * p2p/discover: fix nits in UDP transport We would skip sending neighbors replies if there were fewer than maxNeighbors results and CheckRelayIP returned an error for the last one. While here, also resolve a TODO about pong reply tokens.
* p2p/simulations: various stability fixes (#15198)Lewis Marshall2017-12-011-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | p2p/simulations: introduce dialBan - Refactor simulations/network connection getters to support avoiding simultaneous dials between two peers If two peers dial simultaneously, the connection will be dropped to help avoid that, we essentially lock the connection object with a timestamp which serves as a ban on dialing for a period of time (dialBanTimeout). - The connection getter InitConn can be wrapped and passed to the nodes via adapters.NodeConfig#Reachable field and then used by the respective services when they initiate connections. This massively stablise the emerging connectivity when running with hundreds of nodes bootstrapping a network. p2p: add Inbound public method to p2p.Peer p2p/simulations: Add server id to logs to support debugging in-memory network simulations when multiple peers are logging. p2p: SetupConn now returns error. The dialer checks the error and only calls resolve if the actual TCP dial fails.
* p2p: snappy encoding for devp2p (version bump to 5) (#15106)Péter Szilágyi2017-09-261-1/+3
| | | | | | * p2p: snappy encoding for devp2p (version bump to 5) * p2p: remove lazy decompression, enforce 16MB limit
* p2p: add network simulation framework (#14982)Lewis Marshall2017-09-251-1/+41
| | | | | | This commit introduces a network simulation framework which can be used to run simulated networks of devp2p nodes. The intention is to use this for testing protocols, performing benchmarks and visualising emergent network behaviour.
* p2p: change ping ticker to timer (#15071)Martin Holst Swende2017-09-041-1/+2
| | | | | | Using a Timer over Ticker seems to be a lot better, though I cannot fully account for why that it behaves so (since Ticker should be more bursty, but not necessarily more active over time, but that may depend on how long window it uses to decide on when to tick next)
* p2p, p2p/discover, p2p/nat: rework logging using context keysFelix Lange2017-02-281-22/+21
|
* all: blidly swap out glog to our log15, logs need reworkPéter Szilágyi2017-02-231-10/+9
|
* p2p: remove trailing newlines from log messagesPéter Szilágyi2017-02-231-8/+8
|
* p2p: EIP-8 changesFelix Lange2016-02-191-0/+3
|
* eth, p2p, rpc/api: polish protocol info gatheringPéter Szilágyi2015-10-281-0/+46
|
* all: fix license headers one more timeFelix Lange2015-07-241-1/+1
| | | | I forgot to update one instance of "go-ethereum" in commit 3f047be5a.
* all: update license headers to distiguish GPL/LGPLFelix Lange2015-07-231-4/+4
| | | | | All code outside of cmd/ is licensed as LGPL. The headers now reflect this by calling the whole work "the go-ethereum library".
* all: update license informationFelix Lange2015-07-071-0/+16
|
* p2p: support protocol version negotiationPéter Szilágyi2015-06-261-2/+9
|
* p2p: improve disconnect loggingFelix Lange2015-06-151-5/+6
|
* p2p: track write errors and prevent writes during shutdownFelix Lange2015-06-151-25/+57
| | | | | | | As of this commit, we no longer rely on the protocol handler to report write errors in a timely fashion. When a write fails, shutdown is initiated immediately and no new writes can start. This will also prevent new writes from starting after Server.Stop has been called.
* p2p: new dialer, peer management without locksFelix Lange2015-05-251-25/+30
| | | | | | | | | | | | | | | | | | The most visible change is event-based dialing, which should be an improvement over the timer-based system that we have at the moment. The dialer gets a chance to compute new tasks whenever peers change or dials complete. This is better than checking peers on a timer because dials happen faster. The dialer can now make more precise decisions about whom to dial based on the peer set and we can test those decisions without actually opening any sockets. Peer management is easier to test because the tests can inject connections at checkpoints (after enc handshake, after protocol handshake). Most of the handshake stuff is now part of the RLPx code. It could be exported or move to its own package because it is no longer entangled with Server logic.
* p2p: decrease maximum message size for devp2p to 1kBFelix Lange2015-05-251-1/+1
| | | | | | The previous limit was 10MB which is unacceptable for all kinds of reasons, the most important one being that we don't want to allow the remote side to make us allocate 10MB at handshake time.
* p2p: delete Server.BroadcastFelix Lange2015-05-251-14/+0
|
* p2p: log remote reason when disconnect is requestedFelix Lange2015-05-141-2/+3
| | | | | | The returned reason is currently not used except for the log message. This change makes the log messages a bit more useful. The handshake code also returns the remote reason.
* p2p: drop connections with no matching protocolsFelix Lange2015-05-081-0/+12
|
* p2p, whisper: use glog for peer-level loggingFelix Lange2015-05-071-13/+8
|
* p2p, p2p/discover: protocol version 4Felix Lange2015-04-301-1/+1
|
* p2p: added received at to peer messageobscuren2015-04-301-0/+1
| | | | | p2p.Msg.ReceivedAt can be used for determining block propagation from begining to end.
* p2p: fix yet another disconnect hangFelix Lange2015-04-131-22/+8
| | | | | | | | | Peer.readLoop will only terminate if the connection is closed. Fix the hang by closing the connection before waiting for readLoop to terminate. This also removes the british disconnect procedure where we're waiting for the remote end to close the connection. I have confirmed with @subtly that cpp-ethereum doesn't adhere to it either.
* p2p: don't mess with the socket deadline in Peer.readLoopFelix Lange2015-04-101-1/+0
| | | | netWrapper already sets a read deadline in ReadMsg.
* p2p: fix Peer shutdown deadlocksFelix Lange2015-04-101-62/+69
| | | | | | | | | | There were multiple synchronization issues in the disconnect handling, all caused by the odd special-casing of Peer.readLoop errors. Remove the special handling of read errors and make readLoop part of the Peer WaitGroup. Thanks to @Gustav-Simonsson for pointing at arrows in a diagram and playing rubber-duck.
* p2p: log disconnect requestsFelix Lange2015-03-191-0/+1
| | | | This helps a lot with debugging.
* p2p: use package rlp to encode messagesFelix Lange2015-03-191-3/+3
| | | | | | | | | | Message encoding functions have been renamed to catch any uses. The switch to the new encoder can cause subtle incompatibilities. If there are any users outside of our tree, they will at least be alerted that there was a change. NewMsg no longer exists. The replacements for EncodeMsg are called Send and SendItems.
* p2p: restore read/write timeoutsFelix Lange2015-03-041-1/+2
| | | | They got lost in the transition to rlpxFrameRW.
* p2p: msg.Payload contains list dataFelix Lange2015-03-041-2/+2
| | | | | | | | | With RLPx frames, the message code is contained in the frame and is no longer part of the encoded data. EncodeMsg, Msg.Decode have been updated to match. Code that decodes RLP directly from Msg.Payload will need to change.
* p2p: use RLPx frames for messagingFelix Lange2015-03-041-9/+12
|
* p2p: enable devp2p pingFelix Lange2015-02-191-11/+26
| | | | This should prevent connection drops.
* p2p: disable encryption handshakeFelix Lange2015-02-191-170/+59
| | | | | | The diff is a bit bigger than expected because the protocol handshake logic has moved out of Peer. This is necessary because the protocol handshake will have custom framing in the final protocol.
* p2p: bump devp2p protcol version to 3Felix Lange2015-02-131-1/+1
| | | | For compatibility with cpp-ethereum
* p2p: handle disconnect before protocol handshakeFelix Lange2015-02-131-0/+7
|
* p2p: improve read deadlinesFelix Lange2015-02-131-12/+2
| | | | | | | | There are now two deadlines, frameReadTimeout and payloadReadTimeout. The frame timeout is longer and allows for connections that are idle. The message timeout is still short and ensures that we don't get stuck in the middle of a message.
* p2p: fixes for actual connectionsFelix Lange2015-02-071-16/+21
| | | | The unit test hooks were turned on 'in production'.
* p2p: integrate p2p/discoverFelix Lange2015-02-061-326/+192
| | | | | | | | | | | | Overview of changes: - ClientIdentity has been removed, use discover.NodeID - Server now requires a private key to be set (instead of public key) - Server performs the encryption handshake before launching Peer - Dial logic takes peers from discover table - Encryption handshake code has been cleaned up a bit - baseProtocol is gone because we don't exchange peers anymore - Some parts of baseProtocol have moved into Peer instead
* make crypto handshake calls package level, store privateKey on peer + tests okzelig2015-02-061-8/+19
|
* apply handshake related improvements from p2p.crypto branchzelig2015-02-061-1/+1
|
* add temporary forced session token generationzelig2015-02-061-0/+5
|
* peer-level integration test for crypto handshakezelig2015-02-061-9/+13
| | | | | | | | | - add const length params for handshake messages - add length check to fail early - add debug logs to help interop testing (!ABSOLUTELY SHOULD BE DELETED LATER) - wrap connection read/writes in error check - add cryptoReady channel in peer to signal when secure session setup is finished - wait for cryptoReady or timeout in TestPeersHandshake
* important fix for peer pubkey. when taken from identity, chop first format byte!zelig2015-02-061-1/+1
|
* first stab at integrating crypto in our p2pzelig2015-02-061-9/+22
| | | | | | | - abstract the entire handshake logic in cryptoId.Run() taking session-relevant parameters - changes in peer to accomodate how the encryption layer would be switched on - modify arguments of handshake components - fixed test getting the wrong pubkey but it till crashes on DH in newSession()
* integrate cryptoId into peer and connection lifecyclezelig2015-02-061-3/+18
|
* initial hook for crypto handshake (void, off by default)zelig2015-02-061-0/+26
|
* p2p: move peerList back into baseProtocolFelix Lange2015-01-061-22/+0
| | | | It had been moved to Peer, probably for debugging.
* Mergeobscuren2015-01-061-3/+25
|
* p2p: improve and test eofSignalFelix Lange2014-12-121-5/+12
|
* p2p: make Disconnect not hang for peers created with NewPeerFelix Lange2014-11-271-0/+1
|
* p2p: API cleanup and PoC 7 compatibilityFelix Lange2014-11-221-44/+432
| | | | | Whoa, one more big commit. I didn't manage to untangle the changes while working towards compatibility.
* p2p: rework protocol APIFelix Lange2014-11-221-23/+6
|
* initial commit of p2p packagezelig2014-10-231-0/+83