From 1f1d73ab747da9edc1c8f6bd39835e5653c539ee Mon Sep 17 00:00:00 2001 From: Péter Szilágyi Date: Tue, 1 Sep 2015 16:11:14 +0300 Subject: eth/downloader: fix race causing occasional test failure --- eth/downloader/downloader.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/eth/downloader/downloader.go b/eth/downloader/downloader.go index 574f2ba15..73f95bf64 100644 --- a/eth/downloader/downloader.go +++ b/eth/downloader/downloader.go @@ -739,9 +739,11 @@ func (d *Downloader) fetchBlocks61(from uint64) error { break } // Send a download request to all idle peers, until throttled + throttled := false for _, peer := range d.peers.IdlePeers() { // Short circuit if throttling activated if d.queue.Throttle() { + throttled = true break } // Reserve a chunk of hashes for a peer. A nil can mean either that @@ -762,7 +764,7 @@ func (d *Downloader) fetchBlocks61(from uint64) error { } // Make sure that we have peers available for fetching. If all peers have been tried // and all failed throw an error - if !d.queue.Throttle() && d.queue.InFlight() == 0 { + if !throttled && d.queue.InFlight() == 0 { return errPeersUnavailable } } -- cgit