diff options
| author | Felix Lange <fjl@twurst.com> | 2015-09-30 11:21:03 +0800 |
|---|---|---|
| committer | Felix Lange <fjl@twurst.com> | 2015-09-30 22:23:03 +0800 |
| commit | 32dda976020f8ec756fa65e7764f41e9d42dbef4 (patch) | |
| tree | 241293bcbd6a23221b11bd941853935b83c2a60e | |
| parent | 631bf361026676560b2995563fcf1324347a13a1 (diff) | |
| download | go-tangerine-32dda976020f8ec756fa65e7764f41e9d42dbef4.tar.gz go-tangerine-32dda976020f8ec756fa65e7764f41e9d42dbef4.tar.zst go-tangerine-32dda976020f8ec756fa65e7764f41e9d42dbef4.zip | |
p2p/discover: ignore packet version numbers
The strict matching can get in the way of protocol upgrades.
| -rw-r--r-- | p2p/discover/udp.go | 4 | ||||
| -rw-r--r-- | p2p/discover/udp_test.go | 1 |
2 files changed, 0 insertions, 5 deletions
diff --git a/p2p/discover/udp.go b/p2p/discover/udp.go index 8f62598f2..20f69cf08 100644 --- a/p2p/discover/udp.go +++ b/p2p/discover/udp.go @@ -39,7 +39,6 @@ var ( errPacketTooSmall = errors.New("too small") errBadHash = errors.New("bad hash") errExpired = errors.New("expired") - errBadVersion = errors.New("version mismatch") errUnsolicitedReply = errors.New("unsolicited reply") errUnknownNode = errors.New("unknown node") errTimeout = errors.New("RPC timeout") @@ -522,9 +521,6 @@ func (req *ping) handle(t *udp, from *net.UDPAddr, fromID NodeID, mac []byte) er if expired(req.Expiration) { return errExpired } - if req.Version != Version { - return errBadVersion - } t.send(from, pongPacket, pong{ To: makeEndpoint(from, req.From.TCP), ReplyTok: mac, diff --git a/p2p/discover/udp_test.go b/p2p/discover/udp_test.go index a86d3737b..913199c26 100644 --- a/p2p/discover/udp_test.go +++ b/p2p/discover/udp_test.go @@ -122,7 +122,6 @@ func TestUDP_packetErrors(t *testing.T) { defer test.table.Close() test.packetIn(errExpired, pingPacket, &ping{From: testRemote, To: testLocalAnnounced, Version: Version}) - test.packetIn(errBadVersion, pingPacket, &ping{From: testRemote, To: testLocalAnnounced, Version: 99, Expiration: futureExp}) test.packetIn(errUnsolicitedReply, pongPacket, &pong{ReplyTok: []byte{}, Expiration: futureExp}) test.packetIn(errUnknownNode, findnodePacket, &findnode{Expiration: futureExp}) test.packetIn(errUnsolicitedReply, neighborsPacket, &neighbors{Expiration: futureExp}) |