From d945ea451bece3c8e230ae017dd443266633d634 Mon Sep 17 00:00:00 2001 From: BJ4 Date: Thu, 15 Nov 2018 16:02:19 +0800 Subject: app: add cache to reuse same tx address which has already recovered (#26) --- core/types/transaction_signing.go | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) (limited to 'core/types') diff --git a/core/types/transaction_signing.go b/core/types/transaction_signing.go index cd18a7e13..a6c5c1f16 100644 --- a/core/types/transaction_signing.go +++ b/core/types/transaction_signing.go @@ -21,6 +21,7 @@ import ( "errors" "fmt" "math/big" + "sync" "github.com/dexon-foundation/dexon/common" "github.com/dexon-foundation/dexon/crypto" @@ -31,6 +32,27 @@ var ( ErrInvalidChainId = errors.New("invalid chain id for signer") ) +var ( + txCache = &sync.Map{} +) + +func DeleteTxCacheByHash(hash common.Hash) { + txCache.Delete(hash) +} + +func StoreTxCache(key common.Hash, value common.Address) { + txCache.Store(key, value) +} + +func LoadTxCache(key common.Hash) (common.Address, bool) { + addr, ok := txCache.Load(key) + if !ok { + return common.Address{}, ok + } + + return addr.(common.Address), ok +} + // sigCache is used to cache the derived sender and contains // the signer used to derive it. type sigCache struct { @@ -125,6 +147,11 @@ func (s EIP155Signer) Equal(s2 Signer) bool { var big8 = big.NewInt(8) func (s EIP155Signer) Sender(tx *Transaction) (common.Address, error) { + addr, ok := LoadTxCache(tx.Hash()) + if ok { + return addr, nil + } + if !tx.Protected() { return HomesteadSigner{}.Sender(tx) } @@ -133,7 +160,14 @@ func (s EIP155Signer) Sender(tx *Transaction) (common.Address, error) { } V := new(big.Int).Sub(tx.data.V, s.chainIdMul) V.Sub(V, big8) - return recoverPlain(s.Hash(tx), tx.data.R, tx.data.S, V, true) + + addr, err := recoverPlain(s.Hash(tx), tx.data.R, tx.data.S, V, true) + if err != nil { + return common.Address{}, err + } + + StoreTxCache(tx.Hash(), addr) + return addr, nil } // SignatureValues returns signature values. This signature -- cgit