diff options
| author | Fridrich Štrba <fridrich.strba@bluewin.ch> | 2010-09-14 04:54:19 +0800 |
|---|---|---|
| committer | Fridrich Štrba <fridrich.strba@bluewin.ch> | 2010-09-14 06:03:29 +0800 |
| commit | 81f3dc06fcb6f50cbb08f86b116cf57111468ec9 (patch) | |
| tree | 0e3b14df4c2b4e1ceef7fad8e6d571301d1643c4 | |
| parent | c33a84d443f6a340fc247531b6bc8c9997b52aba (diff) | |
| download | gsoc2013-evolution-81f3dc06fcb6f50cbb08f86b116cf57111468ec9.tar.gz gsoc2013-evolution-81f3dc06fcb6f50cbb08f86b116cf57111468ec9.tar.zst gsoc2013-evolution-81f3dc06fcb6f50cbb08f86b116cf57111468ec9.zip | |
Avoid dll hijacking
Load sensapi.dll only from system directory where it should normally
be and not from any random place.
| -rw-r--r-- | modules/windows-sens/evolution-windows-sens.c | 27 |
1 files changed, 26 insertions, 1 deletions
diff --git a/modules/windows-sens/evolution-windows-sens.c b/modules/windows-sens/evolution-windows-sens.c index 469087ba3e..536ff06ff4 100644 --- a/modules/windows-sens/evolution-windows-sens.c +++ b/modules/windows-sens/evolution-windows-sens.c @@ -457,6 +457,8 @@ static const gchar * add_curly_braces_to_uuid (const gchar * string_uuid) return curly_braced_uuid_string; } +#define SENSAPI_DLL "sensapi.dll" + static void windows_sens_constructed (GObject *object) { @@ -549,7 +551,27 @@ windows_sens_constructed (GObject *object) IsNetworkAlive_t pIsNetworkAlive = NULL; - HMODULE hDLL=LoadLibrary ("sensapi.dll"); + char *buf = NULL; + char dummy; + int n, k; + HMODULE hDLL = NULL; + + n = GetSystemDirectory (&dummy, 0); + + if (n <= 0) + goto cleanup; + + buf = g_malloc (n + 1 + strlen (SENSAPI_DLL)); + k = GetSystemDirectory (buf, n); + + if (k == 0 || k > n) + goto cleanup; + + if (!G_IS_DIR_SEPARATOR (buf[strlen (buf) -1])) + strcat (buf, G_DIR_SEPARATOR_S); + strcat (buf, SENSAPI_DLL); + + hDLL=LoadLibrary (buf); if ((pIsNetworkAlive=(IsNetworkAlive_t) GetProcAddress (hDLL, "IsNetworkAlive"))) { DWORD Network; @@ -559,6 +581,9 @@ windows_sens_constructed (GObject *object) FreeLibrary (hDLL); e_shell_set_network_available (shell, alive); + +cleanup: + g_free (buf); } } |