aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeffrey Stedfast <fejj@ximian.com>2004-06-18 00:13:47 +0800
committerJeffrey Stedfast <fejj@src.gnome.org>2004-06-18 00:13:47 +0800
commitd4549ad01b884201e4f6bd1f34fc39c23abe79a1 (patch)
treebc3bb8794a6beb6464117931c0e934c774ccc86a
parentba90a99563e614a011cdde69761272363a4aba01 (diff)
downloadgsoc2013-evolution-d4549ad01b884201e4f6bd1f34fc39c23abe79a1.tar.gz
gsoc2013-evolution-d4549ad01b884201e4f6bd1f34fc39c23abe79a1.tar.zst
gsoc2013-evolution-d4549ad01b884201e4f6bd1f34fc39c23abe79a1.zip
Thanks to Christian Kellner for pointing out these bugs (and submitting
2004-06-17 Jeffrey Stedfast <fejj@ximian.com> Thanks to Christian Kellner for pointing out these bugs (and submitting the original patch for service_setv) * camel-service.c (service_setv): Don't use (tag & CAMEL_ARG_IGNORE) to determine if we should ignore this tag. CAMEL_ARG_IGNORE is not a bit flag. * providers/imap/camel-imap-store.c (imap_setv): Don't use (tag & CAMEL_ARG_IGNORE) to determine if we should ignore this tag. CAMEL_ARG_IGNORE is not a bit flag. svn path=/trunk/; revision=26392
-rw-r--r--camel/ChangeLog13
-rw-r--r--camel/camel-service.c4
2 files changed, 10 insertions, 7 deletions
diff --git a/camel/ChangeLog b/camel/ChangeLog
index de5a6638f9..6698923e6a 100644
--- a/camel/ChangeLog
+++ b/camel/ChangeLog
@@ -1,8 +1,15 @@
2004-06-17 Jeffrey Stedfast <fejj@ximian.com>
- * providers/imap/camel-imap-store.c (imap_setv): Only ignore if
- (tag & CAMEL_ARG_TAG) == CAMEL_ARG_IGNORE, not if (tag &
- CAMEL_ARG_IGNORE) is true.
+ Thanks to Christian Kellner for pointing out these bugs (and
+ submitting the original patch for service_setv)
+
+ * camel-service.c (service_setv): Don't use (tag &
+ CAMEL_ARG_IGNORE) to determine if we should ignore this
+ tag. CAMEL_ARG_IGNORE is not a bit flag.
+
+ * providers/imap/camel-imap-store.c (imap_setv): Don't use (tag &
+ CAMEL_ARG_IGNORE) to determine if we should ignore this
+ tag. CAMEL_ARG_IGNORE is not a bit flag.
2004-06-16 Jeffrey Stedfast <fejj@ximian.com>
diff --git a/camel/camel-service.c b/camel/camel-service.c
index bb43b60a57..229f0d2893 100644
--- a/camel/camel-service.c
+++ b/camel/camel-service.c
@@ -161,10 +161,6 @@ service_setv (CamelObject *object, CamelException *ex, CamelArgV *args)
for (i = 0; i < args->argc; i++) {
tag = args->argv[i].tag;
- /* make sure this arg wasn't already handled */
- if (tag & CAMEL_ARG_IGNORE)
- continue;
-
/* make sure this is an arg we're supposed to handle */
if ((tag & CAMEL_ARG_TAG) <= CAMEL_SERVICE_ARG_FIRST ||
(tag & CAMEL_ARG_TAG) >= CAMEL_SERVICE_ARG_FIRST + 100)