diff options
| author | Matthew Barnes <mbarnes@redhat.com> | 2006-08-23 16:38:52 +0800 |
|---|---|---|
| committer | Andre Klapper <aklapper@src.gnome.org> | 2006-08-23 16:38:52 +0800 |
| commit | 40f0681b4fee6bf4965b16fdb39c1973e23fb9b0 (patch) | |
| tree | f8f8575b83c957bf936ee87c3e77a8e5ee31505e | |
| parent | 27928c2f6ca528e5b0dd50397efc7479b121985c (diff) | |
| download | gsoc2013-evolution-40f0681b4fee6bf4965b16fdb39c1973e23fb9b0.tar.gz gsoc2013-evolution-40f0681b4fee6bf4965b16fdb39c1973e23fb9b0.tar.zst gsoc2013-evolution-40f0681b4fee6bf4965b16fdb39c1973e23fb9b0.zip | |
improve GError initialization code - fixes bug 352423. committed by Andre
2006-08-23 Matthew Barnes <mbarnes@redhat.com>
* plugins/mailing-list-actions/mailing-list-actions.c:
* widgets/misc/e-multi-config-dialog.c:
improve GError initialization code - fixes bug 352423.
committed by Andre Klapper
svn path=/trunk/; revision=32638
| -rw-r--r-- | plugins/mailing-list-actions/ChangeLog | 6 | ||||
| -rw-r--r-- | plugins/mailing-list-actions/mailing-list-actions.c | 3 | ||||
| -rw-r--r-- | widgets/misc/ChangeLog | 6 | ||||
| -rw-r--r-- | widgets/misc/e-multi-config-dialog.c | 4 |
4 files changed, 14 insertions, 5 deletions
diff --git a/plugins/mailing-list-actions/ChangeLog b/plugins/mailing-list-actions/ChangeLog index 5592976980..01fefc4531 100644 --- a/plugins/mailing-list-actions/ChangeLog +++ b/plugins/mailing-list-actions/ChangeLog @@ -1,3 +1,9 @@ +2006-08-23 Matthew Barnes <mbarnes@redhat.com> + + * mailing-list-actions.c: + fix an uninitialized GError - fixes bug 352423. + committed by Andre Klapper + 2006-07-08 Matthew Barnes <mbarnes@redhat.com> * org-gnome-mailing-list-actions.xml: Fixing header capitalization diff --git a/plugins/mailing-list-actions/mailing-list-actions.c b/plugins/mailing-list-actions/mailing-list-actions.c index aa7fd6440d..f8ae698a80 100644 --- a/plugins/mailing-list-actions/mailing-list-actions.c +++ b/plugins/mailing-list-actions/mailing-list-actions.c @@ -99,7 +99,6 @@ void emla_list_action_do (CamelFolder *folder, const char *uid, CamelMimeMessage const char* header = NULL, *headerpos; char *end, *url = NULL; int t; - GError *err; EMsgComposer *composer; int send_message_response; EAccount *account; @@ -160,7 +159,7 @@ void emla_list_action_do (CamelFolder *folder, const char *uid, CamelMimeMessage goto exit; } else { - err = NULL; + GError *err = NULL; gnome_url_show (url, &err); if (!err) goto exit; diff --git a/widgets/misc/ChangeLog b/widgets/misc/ChangeLog index 6b3ad957f8..51f5f1245c 100644 --- a/widgets/misc/ChangeLog +++ b/widgets/misc/ChangeLog @@ -1,3 +1,9 @@ +2006-08-23 Matthew Barnes <mbarnes@redhat.com> + + * e-multi-config-dialog.c: + improve GError initialization code - fixes bug 352423. + committed by Andre Klapper + 2006-08-07 Ushveen Kaur <kushveen@novell.com> ** Fix for bug #347238 diff --git a/widgets/misc/e-multi-config-dialog.c b/widgets/misc/e-multi-config-dialog.c index 607a29a7d4..60f9256705 100644 --- a/widgets/misc/e-multi-config-dialog.c +++ b/widgets/misc/e-multi-config-dialog.c @@ -186,12 +186,10 @@ static void impl_response (GtkDialog *dialog, int response_id) { EMultiConfigDialog *multi_config_dialog; - GError *error; + GError *error = NULL; multi_config_dialog = E_MULTI_CONFIG_DIALOG (dialog); - error = NULL; - switch (response_id) { case GTK_RESPONSE_HELP: gnome_help_display_desktop (NULL, |