diff options
| author | Federico Mena Quintero <federico@helixcode.com> | 2000-11-25 07:51:35 +0800 |
|---|---|---|
| committer | Federico Mena Quintero <federico@src.gnome.org> | 2000-11-25 07:51:35 +0800 |
| commit | 6dbbc8029fcde97f504d7850b36282c91b2a4dc6 (patch) | |
| tree | 425084e867c4b233d8e6fafafa15c8a208b17797 | |
| parent | 39dc8f4fc8a9e459689ee61a197270d8e23e68de (diff) | |
| download | gsoc2013-evolution-6dbbc8029fcde97f504d7850b36282c91b2a4dc6.tar.gz gsoc2013-evolution-6dbbc8029fcde97f504d7850b36282c91b2a4dc6.tar.zst gsoc2013-evolution-6dbbc8029fcde97f504d7850b36282c91b2a4dc6.zip | |
DOH, fixed reversed test for the presence of the icalcomp's parent. This
2000-11-24 Federico Mena Quintero <federico@helixcode.com>
* cal-util/cal-component.c (free_icalcomponent): DOH, fixed
reversed test for the presence of the icalcomp's parent. This was
causing memory leaks in the Wombat and elsewhere.
* pcs/cal-backend.c (cal_backend_set_node_timet): Plug leak.
svn path=/trunk/; revision=6661
| -rw-r--r-- | calendar/ChangeLog | 8 | ||||
| -rw-r--r-- | calendar/cal-util/cal-component.c | 2 | ||||
| -rw-r--r-- | calendar/pcs/cal-backend.c | 1 |
3 files changed, 10 insertions, 1 deletions
diff --git a/calendar/ChangeLog b/calendar/ChangeLog index 68698a4f0f..f942c4d272 100644 --- a/calendar/ChangeLog +++ b/calendar/ChangeLog @@ -1,5 +1,13 @@ 2000-11-24 Federico Mena Quintero <federico@helixcode.com> + * cal-util/cal-component.c (free_icalcomponent): DOH, fixed + reversed test for the presence of the icalcomp's parent. This was + causing memory leaks in the Wombat and elsewhere. + + * pcs/cal-backend.c (cal_backend_set_node_timet): Plug leak. + +2000-11-24 Federico Mena Quintero <federico@helixcode.com> + * pcs/cal-backend-file.c (scan_vcalendar): Use the new libical external iterators (icalcomponent_begin_component() and friends); the internal iterators are deprecated. diff --git a/calendar/cal-util/cal-component.c b/calendar/cal-util/cal-component.c index a60333589c..05c84f1233 100644 --- a/calendar/cal-util/cal-component.c +++ b/calendar/cal-util/cal-component.c @@ -211,7 +211,7 @@ free_icalcomponent (CalComponent *comp) /* Free the icalcomponent */ - if (icalcomponent_get_parent (priv->icalcomp) != NULL) + if (icalcomponent_get_parent (priv->icalcomp) == NULL) icalcomponent_free (priv->icalcomp); priv->icalcomp = NULL; diff --git a/calendar/pcs/cal-backend.c b/calendar/pcs/cal-backend.c index f4d06518c1..43895cc554 100644 --- a/calendar/pcs/cal-backend.c +++ b/calendar/pcs/cal-backend.c @@ -471,6 +471,7 @@ cal_backend_set_node_timet (xmlNodePtr node, const char *name, time_t t) tstring = g_strdup_printf ("%ld", t); xmlSetProp (node, name, tstring); + g_free (tstring); } static void |