Don't warn if calendar isn't loaded... Doesn't seem to hurt, but this

2003-02-23  Hans Petter Jansson  <hpj@ximian.com>

	* cal-client/cal-client.c (cal_client_is_read_only): Don't warn
	if calendar isn't loaded... Doesn't seem to hurt, but this should
	probably be investigated further.

	* gui/dialogs/comp-editor-util.c (comp_editor_contacts_to_widget):
	If we have no contacts, don't bother trying to set them in the
	widget. Used to pass a NULL list, which would lead to much anxiety
	in callees.

	* gui/dialogs/meeting-page.c (meeting_page_fill_widgets):
	If we have no potential organizers, emit a sensible warning.

	* gui/dialogs/task-page.c (init_widgets): Don't try to connect to
	the "changed" signal of the GtkTextView -- we listen to the
	GtkTextBuffer now.

svn path=/trunk/; revision=20019

5 files changed, 28 insertions, 5 deletions

diff --git a/calendar/ChangeLog b/calendar/ChangeLog
index 09a69ce0f8..826a6c5f48 100644
--- a/calendar/ChangeLog
+++ b/calendar/ChangeLog
@@ -1,3 +1,21 @@
+2003-02-23  Hans Petter Jansson  <hpj@ximian.com>
+
+	* cal-client/cal-client.c (cal_client_is_read_only): Don't warn
+	if calendar isn't loaded... Doesn't seem to hurt, but this should
+	probably be investigated further.
+
+	* gui/dialogs/comp-editor-util.c (comp_editor_contacts_to_widget):
+	If we have no contacts, don't bother trying to set them in the
+	widget. Used to pass a NULL list, which would lead to much anxiety
+	in callees.
+
+	* gui/dialogs/meeting-page.c (meeting_page_fill_widgets):
+	If we have no potential organizers, emit a sensible warning.
+
+	* gui/dialogs/task-page.c (init_widgets): Don't try to connect to
+	the "changed" signal of the GtkTextView -- we listen to the
+	GtkTextBuffer now.
+
 2003-02-20  Not Zed  <NotZed@Ximian.com>
 
 	* gui/e-itip-control.c (destroy): dont unref accounts anymore.
@@ -144,7 +162,7 @@
 	* cal-client/cal-client.c (get_default_uri): Use the proper path
 	to get the default folder uri's.
 
-2003-02-23  Hans Petter Jansson  <hpj@ximan.com>
+2003-02-23  Hans Petter Jansson  <hpj@ximian.com>
 
 	* gui/gnome-cal.c (backend_died_cb): Appease the compiler.
 	(gnome_calendar_update_paned_quanta): Don't actually try to set
diff --git a/calendar/cal-client/cal-client.c b/calendar/cal-client/cal-client.c
index fd235e1d3c..89579a34a0 100644
--- a/calendar/cal-client/cal-client.c
+++ b/calendar/cal-client/cal-client.c
@@ -1128,7 +1128,8 @@ cal_client_is_read_only (CalClient *client)
 
 	priv = client->priv;
 
-	g_return_val_if_fail (priv->load_state == CAL_CLIENT_LOAD_LOADED, FALSE);
+	if (priv->load_state != CAL_CLIENT_LOAD_LOADED)
+		return FALSE;
 
 	CORBA_exception_init (&ev);
 	read_only = GNOME_Evolution_Calendar_Cal_isReadOnly (priv->cal, &ev);
diff --git a/calendar/gui/dialogs/comp-editor-util.c b/calendar/gui/dialogs/comp-editor-util.c
index 4e68d52022..fdb8e04b78 100644
--- a/calendar/gui/dialogs/comp-editor-util.c
+++ b/calendar/gui/dialogs/comp-editor-util.c
@@ -421,6 +421,9 @@ comp_editor_contacts_to_widget (GtkWidget *contacts_entry,
 	int i;
 
 	cal_component_get_contact_list (comp, &contact_list);
+	if (!contact_list)
+		return;
+
 	dest_array = g_ptr_array_new ();
 	for (elem = contact_list; elem; elem = elem->next) {
 		CalComponentText *t = elem->data;
diff --git a/calendar/gui/dialogs/meeting-page.c b/calendar/gui/dialogs/meeting-page.c
index d7c1320704..bb42eb2d03 100644
--- a/calendar/gui/dialogs/meeting-page.c
+++ b/calendar/gui/dialogs/meeting-page.c
@@ -319,7 +319,10 @@ meeting_page_fill_widgets (CompEditorPage *page, CalComponent *comp)
 	priv->comp = cal_component_clone (comp);
 	
 	/* List the user identities for default organizers */
-	gtk_combo_set_popdown_strings (GTK_COMBO (priv->organizer), priv->address_strings);
+	if (priv->address_strings)
+		gtk_combo_set_popdown_strings (GTK_COMBO (priv->organizer), priv->address_strings);
+	else
+		g_warning ("No potential organizers!");
 
 	/* If there is an existing organizer show it properly */
 	if (cal_component_has_organizer (comp)) {
diff --git a/calendar/gui/dialogs/task-page.c b/calendar/gui/dialogs/task-page.c
index 0e2ae28d5f..64eb70861e 100644
--- a/calendar/gui/dialogs/task-page.c
+++ b/calendar/gui/dialogs/task-page.c
@@ -895,8 +895,6 @@ init_widgets (TaskPage *tpage)
 	g_signal_connect ((text_buffer), "changed",
 			  G_CALLBACK (field_changed_cb), tpage);
 
-	g_signal_connect((priv->description), "changed",
-			    G_CALLBACK (field_changed_cb), tpage);
 	g_signal_connect((priv->categories), "changed",
 			    G_CALLBACK (field_changed_cb), tpage);