aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Toshok <toshok@ximian.com>2004-01-23 07:44:35 +0800
committerChris Toshok <toshok@src.gnome.org>2004-01-23 07:44:35 +0800
commit93e268731dad2c7529879ac99aef1e1ab216463d (patch)
treed3e8187bed29a4aec750ebc4e4b4a38e972caa67
parentc9b56375fe7b21673fd813d3e957b64fe6f9f7f0 (diff)
downloadgsoc2013-evolution-93e268731dad2c7529879ac99aef1e1ab216463d.tar.gz
gsoc2013-evolution-93e268731dad2c7529879ac99aef1e1ab216463d.tar.zst
gsoc2013-evolution-93e268731dad2c7529879ac99aef1e1ab216463d.zip
[ fixes bug #53184 ] handle the fact that the xml 1.4 spits out contains
2004-01-22 Chris Toshok <toshok@ximian.com> [ fixes bug #53184 ] * gui/component/addressbook-migrate.c (migrate_contacts): handle the fact that the xml 1.4 spits out contains unescaped ';'s in the EMAIL attributes for mailing lists. svn path=/trunk/; revision=24374
-rw-r--r--addressbook/ChangeLog7
-rw-r--r--addressbook/gui/component/addressbook-migrate.c30
2 files changed, 37 insertions, 0 deletions
diff --git a/addressbook/ChangeLog b/addressbook/ChangeLog
index ffd2fab031..e656ad2861 100644
--- a/addressbook/ChangeLog
+++ b/addressbook/ChangeLog
@@ -1,5 +1,12 @@
2004-01-22 Chris Toshok <toshok@ximian.com>
+ [ fixes bug #53184 ]
+ * gui/component/addressbook-migrate.c (migrate_contacts): handle
+ the fact that the xml 1.4 spits out contains unescaped ';'s in the
+ EMAIL attributes for mailing lists.
+
+2004-01-22 Chris Toshok <toshok@ximian.com>
+
[ fixes bug #52944 ]
* gui/component/addressbook-migrate.c (migrate_contacts): do some
massaging of contacts as we import them, to fix up the differences
diff --git a/addressbook/gui/component/addressbook-migrate.c b/addressbook/gui/component/addressbook-migrate.c
index 60b87d4dd6..1514e72434 100644
--- a/addressbook/gui/component/addressbook-migrate.c
+++ b/addressbook/gui/component/addressbook-migrate.c
@@ -283,6 +283,36 @@ migrate_contacts (EBook *old_book, EBook *new_book)
"VOICE");
attr = attr->next;
}
+ /* this is kinda gross. The new vcard parser
+ needs ';'s to be escaped by \'s. but the
+ 1.4 vcard generator would put unescaped xml
+ (including entities like &gt;) in the value
+ of attributes, so we need to go through and
+ escape those ';'s. */
+ else if (!strcmp ("EMAIL", e_vcard_attribute_get_name (a))) {
+ GList *v = e_vcard_attribute_get_values (a);
+
+ if (v && v->data) {
+ if (!strncmp ((char*)v->data, "<?xml", 5)) {
+ /* k, this is the nasty part. we glomb all the
+ value strings back together again (if there is
+ more than one), then work our magic */
+ GString *str = g_string_new ("");
+ while (v) {
+ g_string_append (str, v->data);
+ if (v->next)
+ g_string_append_c (str, ';');
+ v = v->next;
+ }
+
+ e_vcard_attribute_remove_values (a);
+ e_vcard_attribute_add_value (a, str->str);
+ g_string_free (str, TRUE);
+ }
+ }
+
+ attr = attr->next;
+ }
else {
attr = attr->next;
}
class='deletions'>-0/+33 * - Update to 4.4miwi2015-12-244-10/+10 * Update Calligra to 2.9.10.rakuco2015-12-226-47/+44 * Update to 5.0.4.jkim2015-12-182-8/+8 * mark some of the ports that don't build on powerpc64 for meswills2015-12-141-0/+2 * eric6 ports: Update to version 6.1.0.bsam2015-12-071-2/+2 * - Add LICENSEamdmi32015-12-071-1/+10 * - Add LICENSEamdmi32015-12-071-4/+8 * - Clarify LICENSEamdmi32015-12-051-2/+5 * - Clarify LICENSEamdmi32015-12-051-2/+5 * - Add LICENSEamdmi32015-12-051-3/+4 * - Add LICENSEamdmi32015-12-051-1/+8 * - Switch to options helpersamdmi32015-12-051-3/+3 * Remove expired ports:rene2015-11-2947-959/+0 * Fix ports that confused the meaning of WRKDIR and WRKSRC.mat2015-11-052-3/+3 * - Mark MAKE_JOBS_UNSAFE, fails in parallel build:amdmi32015-11-051-4/+3 * Update to 5.0.3.jkim2015-11-042-8/+8 * Chase chinese/cce expirationantoine2015-10-261-0/+3 * Deprecate ports broken for more than 6 monthsantoine2015-10-266-0/+12 * Improve shebangfix frameworkamdmi32015-10-192-2/+0 * - Add LICENSE_FILEsunpoet2015-10-181-0/+1 * - Use USES=localbasesunpoet2015-10-181-2/+1 * - Use USES=localbasesunpoet2015-10-181-2/+1 * - Update to 0.22sunpoet2015-10-162-3/+4 * Update to 1.7.2.delphij2015-10-053-3/+4 * Update to 0.3.2.delphij2015-10-054-14/+5 * Update to 1.2.0.delphij2015-10-053-7/+11 * - Update to 4.3.1sunpoet2015-10-012-5/+4 * - Update to 4.3.1sunpoet2015-10-012-5/+4 * Remove the chinese specific version of joe's editorbapt2015-09-262-18/+0 * Specify correctly @post* for gtk-query-immodulesbapt2015-09-264-10/+10 * Update to 5.0.2.jkim2015-09-244-12/+12 * - Add NO_ARCHamdmi32015-09-242-2/+3 * Remove build dependency on the python symlinkantoine2015-09-231-2/+3 * Typos, whitespace and capitalization fixes (A-F).olgeni2015-09-212-2/+2 * - Add NO_ARCHsunpoet2015-09-181-0/+1 * - Add NO_ARCHsunpoet2015-09-181-0/+1 * Make it so that the default Perl is always called perl5.mat2015-09-142-5/+5 * - Fix PORTREVISION to match master port (mail/mutt)sunpoet2015-09-131-1/+1 * eric6 ports: Update to version 6.0.9.bsam2015-09-121-2/+2 * Uses/iconv.mk: Set iconv-related CMake variables.rakuco2015-09-032-11/+1 * Remove BROKEN on powerpc statements: both these ports build and install fine.danfe2015-09-032-4/+0 * - Allow concurrent installation (USE_PYTHON=concurrent)sunpoet2015-09-031-1/+1 * Update LibreOffice to 5.0.1.jkim2015-09-022-8/+8 * - Update to 4.3sunpoet2015-08-312-3/+4 * - Update to 4.3sunpoet2015-08-312-3/+4 * Reset maintainership per mail on freebsd-ports@ listjbeich2015-08-312-2/+2 * Convert ports to use the options helpers in categories [abc]*, and minor fixes.mat2015-08-1913-257/+92 * devel/eric6 and eric6 i18n files: update to version 6.0.8bsam2015-08-181-2/+2 * Remove UNIQUENAME and LATEST_LINK.mat2015-08-172-4/+0 * - Strip shared librarysunpoet2015-08-171-1/+4 * - Strip shared librarysunpoet2015-08-171-1/+4 * Update to 4.2.4flo2015-08-072-3/+3 * - Don't use / in sed regexps to allow paths, unbreaking cross-buildsamdmi32015-08-051-3/+3 * Part 1 of adding USE_GNOME=intltool to ports that require it.kwm2015-08-031-1/+1 * By default libtool replaces -export-symbols <file> with -retain-symbols-filetijl2015-08-022-2/+2 * Switch default python_CMD used by shebangfix to ${PYTHON_CMD} for portsantoine2015-07-301-1/+0 * chinese/pcmanx: fix LIB_DEPENDS typorobak2015-07-201-2/+2 * Convert code in bsd.port.mk for USE_GHOSTSCRIPT* to USES=ghostscript.kwm2015-07-171-1/+1 * After r390893, chmod u+w/u-w for stripping perl XS modules is unnecessary,adamw2015-06-291-2/+0 * - Update to 4.2.2sunpoet2015-06-282-4/+4 * - Use DISTVERSIONSUFFIX instead of DISTNAMEsunpoet2015-06-281-1/+1 * - Update to 11.3sunpoet2015-06-283-14/+6 * - Update to 1.18sunpoet2015-06-283-14/+6 * - Update to 11.3sunpoet2015-06-284-50/+13 * Start removing MASTER_SITE_SUBDIR=CPAN:username where possible. Theadamw2015-06-241-1/+0 * Reset maintainership for obrienerwin2015-06-131-1/+1 * Set vim's default encoding to utf-8 [1].kevlo2015-06-083-3/+38 * - Style improvementsamdmi32015-06-081-8/+4 * - Add LICENSEamdmi32015-06-031-13/+9 * - Strip binaryamdmi32015-05-281-1/+9 * - Strip libraryamdmi32015-05-281-1/+5 * - Strip libraryamdmi32015-05-281-1/+5 * - Add LICENSEamdmi32015-05-281-11/+8 * - Don't cat pkg-message from Makefilesamdmi32015-05-272-6/+0 * - Update to 0.21sunpoet2015-05-242-4/+3 * Remove $FreeBSD$ from patches files in categories a-j.mat2015-05-221-3/+0 * Replace most occurences of github.com in MASTER_SITES with USE_GITHUB usage.mat2015-05-194-8/+10 * - Use DISTVERSIONPREFIX instead of DISTNAMEsunpoet2015-05-161-1/+1 * - Use DISTVERSIONPREFIX instead of DISTNAMEsunpoet2015-05-161-1/+1 * - Use DISTVERSIONPREFIX instead of DISTNAMEsunpoet2015-05-161-1/+1 * mail/mutt: update patchesjbeich2015-05-161-1/+1 * MASTER_SITES cleanup.mat2015-05-1410-13/+9 * Cleanup DIST* variables.mat2015-05-125-9/+7 * - Drop @dirrm* from plistamdmi32015-05-111-3/+0 * - Simplify MASTER_SITESamdmi32015-05-111-2/+6 * - Don't install static libraries with INSTALL_LIB (part 2/2)amdmi32015-05-092-3/+3 * - Update to 4.2.2sunpoet2015-05-092-3/+3 * Reassign chinese/ perl modules to perl@.adamw2015-05-0911-12/+12 * eric6 ports: Update to version 6.0.5.bsam2015-05-081-2/+2 * Update ports in the [bcd]* categories to not use GH_COMMIT.mat2015-05-068-17/+9 * Due to the disabling of the bugzilla account, reset maintainership ofeadler2015-05-041-1/+1 * chinese/librime: unbreak build on 8.x/9.x (libstdc++ 4.2+)jbeich2015-05-021-1/+1 * - Update to 4.1.4sunpoet2015-04-302-3/+3 * - Update to 4.1.2sunpoet2015-04-262-3/+3 * - Update to 4.2sunpoet2015-04-262-3/+3 * Unbreak build on FreeBSD 8.x/9.x and DragonFlyjbeich2015-04-262-1/+12 * Update to 4.3.7.jkim2015-04-262-8/+8 * Update icu to 55.1bapt2015-04-241-0/+1 * - Remove libtool hacks and patches that are now handled by USES=libtooltijl2015-04-181-4/+0 * chinese/librime: Adjust patch to support DragonFly toomarino2015-04-181-9/+9 * Pass maintainership to enlightenment@.olgeni2015-04-171-1/+1 * converters/libiconv:tijl2015-04-152-2/+21 * ${ENV} does not exist, it is called ${SETENV}.mat2015-04-131-1/+1 * chinese/libtabe: Unbreak fetch (slightly different distfile)marino2015-04-093-26/+24 * Update master site and mark as unbroken.kevlo2015-04-091-4/+2 * eric6 ports: Update to version 6.0.4.bsam2015-04-091-2/+2 * Remove tar:xz from USES.vanilla2015-04-072-3/+3 * 1: upgrade to 2.0.4rc3.vanilla2015-04-076-66/+70 * - Unbreak this portsunpoet2015-04-061-1/+0 * Mark as broken unfetchable portsbapt2015-04-0610-0/+10 * - Bump PORTREVISION to match master port (mail/mutt)sunpoet2015-04-041-1/+1 * Fix build when building in an environment with old version of fcitxdelphij2015-04-042-2/+12 * Remove OSVERSION checks that do not make sense any more.mat2015-04-033-41/+0 * chinese/fcitx: update 4.2.8.5 -> 4.2.8.6robak2015-04-022-3/+3 * - remove do_nada from targetjgh2015-04-021-3/+1 * - remove do_nada from targetjgh2015-04-021-1/+1 * - remove do_nada from targetjgh2015-04-021-3/+1 * Add ibus-libpinyin 1.7.1, intelligent Pinyin engine based on libpinyindelphij2015-04-015-0/+119 * Add a missing build dependencyantoine2015-03-311-1/+1 * Major update to libpinyin, fcitx and their add ons:delphij2015-03-3185-431/+893 * Use MASTERDIR's distinfo for chinese/joe so that future upgrades ofmi2015-03-282-6/+3 * - Fix install from non-rootamdmi32015-03-272-19/+6 * chinese/libtabe: Add DragonFly supportmarino2015-03-261-6/+112 * Actually make it find fonts.jkim2015-03-241-1/+1 * Fix build.jkim2015-03-241-1/+2 * Fix MAKE_CMD to be scons after r381976bdrewery2015-03-231-1/+1 * Fix dependency detectionbapt2015-03-221-1/+1 * Make fonts repecting XDGbapt2015-03-2212-54/+31 * Fix renamed distfiles missed in r381688. Also fix the GHR ports updated inbdrewery2015-03-201-2/+2 * Remove GITHUB_RELEASE MASTER_SITE from r375010 as it is now redundant with GI...bdrewery2015-03-201-1/+0 * - Strip libraryamdmi32015-03-171-1/+6 * - Update to 1.4.14sunpoet2015-03-154-21/+41 * Some OCD cleanups on some of the perl@ ports.adamw2015-03-136-6/+6 * - Add LICENSEsunpoet2015-03-132-5/+5 * Update KDE SC to 4.14.3alonso2015-03-123-4/+5 * No need to export a KDE path since r344893 has switched KDE4_PREFIX tokevlo2015-03-102-0/+13 * Eric6 localization files.bsam2015-03-083-0/+10 * - Clarify LICENSEamdmi32015-03-052-1/+4 * - Remove unneeded MAN3amdmi32015-03-041-2/+0 * Remove Authors from pkg-descrbapt2015-03-032-4/+0 * Fix runtime error with wrong datadir.vanilla2015-02-262-0/+16 * - Update to 4.3.6.jkim2015-02-212-8/+8 * Unbreak on headantoine2015-02-151-3/+7 * Fix build on 10 (makeinfo issue)vanilla2015-02-152-5/+23 * 1: Upgrade to 0.4.0.vanilla2015-02-097-53/+37 * Unbreakantoine2015-02-082-31/+24 * - Strip shared librarysunpoet2015-01-201-0/+1 * Drop maintainership as I no longer use these software nor have time andrafan2015-01-177-7/+7 * - Update to 4.1sunpoet2015-01-162-3/+3 * Add missing USE_OPENSSL=yestijl2015-01-151-1/+1 * - Bump PORTREVISION to match master port (mail/mutt) and remove false alarm o...sunpoet2014-12-301-1/+1 * Remove gnomehack which was unused anywaybapt2014-12-251-11/+5 * - Update to 4.1sunpoet2014-12-242-3/+3 * Update "BSD" license for buganini's portsfeld2014-12-233-3/+4 * - Update to 0.13sunpoet2014-12-213-9/+6 * Cleanup plistbapt2014-12-212-2/+0 * Update to 4.3.5.jkim2014-12-192-8/+8 * Replace USES=libtool:oldver with USES=libtool or USES=libtool:keepla intijl2014-12-091-1/+1 * Finish resetting maintainershipbapt2014-12-033-3/+3 * Update to 4.3.4.jkim2014-11-272-8/+8 * Change the way Perl modules are installed, update the default Perl to 5.18.mat2014-11-2638-40/+36 * - While I'm here, update to 4.0.1sunpoet2014-11-252-4/+3 * - While I'm here, update to 4.0.1sunpoet2014-11-252-4/+3 * - Remove a few remaining $Id$ from pkg-plistsak2014-11-071-1/+0 * Update to 4.3.3.jkim2014-11-012-8/+8 * Cleanup plistbapt2014-10-20