aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPeter Williams <peterw@src.gnome.org>2000-08-30 06:16:15 +0800
committerPeter Williams <peterw@src.gnome.org>2000-08-30 06:16:15 +0800
commit8b546f3dfa39bceb5d28c2b9b09f3445b46b6b6d (patch)
tree1d52431e9e432aff12f60e8593c352e156f7ee80
parentda570c66609a9baea34d4899c4ca7e1f8329d471 (diff)
downloadgsoc2013-evolution-8b546f3dfa39bceb5d28c2b9b09f3445b46b6b6d.tar.gz
gsoc2013-evolution-8b546f3dfa39bceb5d28c2b9b09f3445b46b6b6d.tar.zst
gsoc2013-evolution-8b546f3dfa39bceb5d28c2b9b09f3445b46b6b6d.zip
Fixing a spurious unref, or creating a circular reference? You decide.
svn path=/trunk/; revision=5104
-rw-r--r--mail/ChangeLog5
-rw-r--r--mail/folder-browser.c7
2 files changed, 12 insertions, 0 deletions
diff --git a/mail/ChangeLog b/mail/ChangeLog
index e5c84919b8..5b165ed3c2 100644
--- a/mail/ChangeLog
+++ b/mail/ChangeLog
@@ -1,3 +1,8 @@
+2000-08-29 Peter Williams <peterw@helixcode.com>
+
+ * folder-browser.c (folder_browser_new): Ref the Evolution_Shell.
+ Is this correct, or is it a circular reference?
+
2000-08-29 Dan Winship <danw@helixcode.com>
* mail-ops.c (mail_do_send_mail): Update this and related
diff --git a/mail/folder-browser.c b/mail/folder-browser.c
index 8279624e4c..65ca9cf114 100644
--- a/mail/folder-browser.c
+++ b/mail/folder-browser.c
@@ -441,12 +441,19 @@ folder_browser_new (Evolution_Shell shell)
{
static int serial;
FolderBrowser *folder_browser = gtk_type_new (folder_browser_get_type ());
+ CORBA_Environment ev;
my_folder_browser_init (GTK_OBJECT (folder_browser));
folder_browser->uri = NULL;
folder_browser->serial = serial++;
folder_browser->shell = shell;
+#warning "is this a circular reference???"
+
+ CORBA_exception_init (&ev);
+ Bonobo_Unknown_ref (shell, &ev);
+ CORBA_exception_free (&ev);
+
return GTK_WIDGET (folder_browser);
}