aboutsummaryrefslogtreecommitdiffstats
path: root/camel
diff options
context:
space:
mode:
authorDan Winship <danw@src.gnome.org>2000-07-02 06:10:22 +0800
committerDan Winship <danw@src.gnome.org>2000-07-02 06:10:22 +0800
commit00d1c1c3335a6d1d7cb342b77923b8869e6e631c (patch)
treea4ef46e64e70c0a9b9d8cb7e4d18e0190f7d5fa1 /camel
parent25e3c025f6d1ebfe39e3e3b68ad8c1a48883991c (diff)
downloadgsoc2013-evolution-00d1c1c3335a6d1d7cb342b77923b8869e6e631c.tar.gz
gsoc2013-evolution-00d1c1c3335a6d1d7cb342b77923b8869e6e631c.tar.zst
gsoc2013-evolution-00d1c1c3335a6d1d7cb342b77923b8869e6e631c.zip
fix the CAPA-parsing code to not get into an infinite loop.
* providers/pop3/camel-pop3-store.c (connect_to_server): fix the CAPA-parsing code to not get into an infinite loop. svn path=/trunk/; revision=3849
Diffstat (limited to 'camel')
-rw-r--r--camel/ChangeLog5
-rw-r--r--camel/providers/pop3/camel-pop3-store.c6
2 files changed, 9 insertions, 2 deletions
diff --git a/camel/ChangeLog b/camel/ChangeLog
index 90cac0d0ee..a8f4b721ca 100644
--- a/camel/ChangeLog
+++ b/camel/ChangeLog
@@ -1,3 +1,8 @@
+2000-07-01 Dan Winship <danw@helixcode.com>
+
+ * providers/pop3/camel-pop3-store.c (connect_to_server): fix the
+ CAPA-parsing code to not get into an infinite loop.
+
2000-07-01 Jeffrey Stedfast <fejj@helixcode.com>
* providers/imap/camel-imap-folder.c (imap_get_message): Fixed
diff --git a/camel/providers/pop3/camel-pop3-store.c b/camel/providers/pop3/camel-pop3-store.c
index bdfe8dd36e..636172bb94 100644
--- a/camel/providers/pop3/camel-pop3-store.c
+++ b/camel/providers/pop3/camel-pop3-store.c
@@ -292,9 +292,9 @@ connect_to_server (CamelService *service, gboolean real, CamelException *ex)
if (!strncmp (p, "IMPLEMENTATION ", 15)) {
store->implementation =
g_strndup (p + 15, len - 15);
- } else if (!strncmp (p, "TOP", len))
+ } else if (len == 3 && !strncmp (p, "TOP", 3))
store->supports_top = TRUE;
- else if (!strncmp (p, "UIDL", len))
+ else if (len == 4 && !strncmp (p, "UIDL", 4))
store->supports_uidl = TRUE;
else if (!strncmp (p, "LOGIN-DELAY ", 12))
store->login_delay = atoi (p + 12);
@@ -304,6 +304,8 @@ connect_to_server (CamelService *service, gboolean real, CamelException *ex)
store->expires = TRUE;
p += len;
+ if (*p)
+ p++;
}
g_free (buf);
d>2001-04-252-352/+407 * Add accelerators to the context menu. (on_right_click): UseDan Winship2001-04-253-28/+73 * Bump up the gal requirementDan Winship2001-04-252-1/+5 * Updated russian translation.Valek Frob2001-04-242-480/+548 * Updated tr.poFatih Demir2001-04-242-611/+835 * UpdateKjartan Maraas2001-04-241-2/+3 * Added #include <glib.h> and moved corresponding local headers to the top.Kjartan Maraas2001-04-247-10/+30 * Added #include <glib.h>.Kjartan Maraas2001-04-243-1/+9 * Added #include <glib.h> and move corresponding local headers to the top toKjartan Maraas2001-04-246-8/+17 * remove prototype for e_gethostbyname_init.Chris Toshok2001-04-243-41/+43 * Removed attempts to use Radek's evil <DATA> hacks, which were just causingJon Trowbridge2001-04-248-145/+294 * Documented this function properly.Christopher James Lahey2001-04-243-118/+159 * Added get_cell_geometry method.Christopher James Lahey2001-04-248-9/+122 * Add camel-vee-folder.h and camel-digest-folder.hJeffrey Stedfast2001-04-242-0/+4 * New class that can be used to browse a multipart/digest message as if itJeffrey Stedfast2001-04-245-1/+366 * Changed dependency for install-data-local from "evolution" toJon Trowbridge2001-04-244-2/+12 * Include glib.h, so that the g_warning in e_gethostbyname_r will be treatedJon Trowbridge2001-04-242-0/+7 * #include gnome-window-icon.hJeffrey Stedfast2001-04-242-0/+5 * Added mail/message-browser.c and removed mail/mail-view.cJeffrey Stedfast2001-04-242-1/+6 * Use the message-browser widget rather than the mail-view window.Jeffrey Stedfast2001-04-2411-267/+425 * Port builddir != srcdir patch from the evolution-0-10-branch.Ettore Perazzoli2001-04-2412-14/+40 * Added #include <stdlib.h>.Christopher James Lahey2001-04-241-0/+1 * Made it so that if a message is from the last 8 hours, it only prints theChristopher James Lahey2001-04-241-5/+21 * Make pixbuf columns show their title if there is space.Christopher James Lahey2001-04-241-2/+23 * Remove UNICODE_CFLAGS (e_text_test_LDADD, e_entry_test_LDADD,Dan Winship2001-04-241-43/+42 * Updated Norwegian translation.Kjartan Maraas2001-04-242-798/+1127 * remove UNICODE_CFLAGSDan Winship2001-04-241-21/+20 * bump to 0.7.99.1, add gal/unicode/Makefile. gal no longer internallyDan Winship2001-04-242-52/+53 * Append a "/" to the result of g_get_home_dir so gets the default dir itDan Winship2001-04-242-2/+9 * Re-commit ChangeLog.Ettore Perazzoli2001-04-242-4/+0 * Documentation building fixes merged from the evolution-0-10-branch:Ettore Perazzoli2001-04-2413-38/+76 * Updated translationMatthias Warkus2001-04-232-628/+673 * Updated Hungarian translation (andras)Szabolcs Ban2001-04-232-1088/+768 * add e-host-utils.[ch]Chris Toshok2001-04-234-0/+188 * ugh, don't bother checking if the header values are non-NULL - it doesn't hur...Jeffrey Stedfast2001-04-232-14/+3 * Only set the X-Evolution-* header if that value is non-NULL.Jeffrey Stedfast2001-04-233-12/+33 * We need to link in more than just libnspr4, we also need libpthread.Jeffrey Stedfast2001-04-232-3/+9 * Make sure we have a context before we try and use it.Jeffrey Stedfast2001-04-232-2/+10 * Oops, don't use the return value of iconv() as a string length, it onlyJeffrey Stedfast2001-04-233-3/+10 * Changed GTK_INCLUDEDIR to EXTRA_GNOME_CFLAGS.Mikael Hallendal2001-04-232-1/+6 * Added save_source_data here.Christopher James Lahey2001-04-222-0/+7 * Translations from keldKeld Jørn Simonsen2001-04-221-2495/+2584 * translate "Things to do" etc. and convert them to utf8. Changed some linkGediminas Paulauskas2001-04-222-13/+24 * use system = EVOLUTION_DATADIR "/file" instead of g_strdup_printf. RenameGediminas Paulauskas2001-04-228-34/+41 * Set window_icon of the Composer window to be compose-message.pngDuncan Mak2001-04-222-1/+10 * Set window_icon of the splash screen to "evolution.png"Duncan Mak2001-04-222-0/+6 * Added in "compose-messages.png" in the Makefile of evolution/artDuncan Mak2001-04-222-0/+5 * Properly convert to utf8. (Bug #2256) (build_quick_add_dialog): ProperlyJon Trowbridge2001-04-223-12/+46 * Translations from KeldKenneth Christiansen2001-04-221-1066/+3613 * I get "cannot obtain lock on directory /cvs/gnome/..../.deps: no such file or...Gediminas Paulauskas2001-04-221-0/+1 * For Dirk-Jan C. Binnema <dirkjan@gnome.org> :Almer S. Tigelaar2001-04-212-35/+41 * Convert the result of g_get_real_name() from the locale charset to UTF8.Dan Winship2001-04-212-1/+7 * Implemented using the secmime.h convenience functions. (smime_clearsign):Jeffrey Stedfast2001-04-214-15/+754 * Use a CamelPgpType. (mail_config_get_pgp_type): Return a CamelPgpType.Jeffrey Stedfast2001-04-213-6/+90 * changed path to the importer header files, since we've had reports thatDamon Chaplin2001-04-214-6/+18 * Fix a dumb thinko in my 04-11 patch.Dan Winship2001-04-212-1/+6 * Pull up fix for translation of filter direction drop down menu from theKjartan Maraas2001-04-212-1/+12 * Convert subject from utf8 before passing it on.Dan Winship2001-04-202-5/+18 * Fixed typoHector Garcia2001-04-202-36/+38 * Fixed bug that prevented new translationsHector Garcia2001-04-202-4/+22 * Updated Spanish TranslationHector Garcia2001-04-2032-466/+808 * Limit total matches, for better performance on slow machines. It isJon Trowbridge2001-04-204-29/+98 * Update Hungarian translation (andras)Szabolcs Ban2001-04-202-605/+550 * Submit a signal even if there are no extras.Christopher James Lahey2001-04-203-44/+132 * #if 0'd out my not-working selection codeGediminas Paulauskas2001-04-202-0/+11 * Updates from Clara TattoniChristopher R. Gabriel2001-04-202-2034/+3045 * Turned off information expanders (tooltips) in ETable by default. TurnChristopher James Lahey2001-04-201-7/+9 * Implemented. (pkcs7_clearsign): Implemented. (get_zero_len_passwd):Jeffrey Stedfast2001-04-202-5/+159 * Implemented. (pkcs7_clearsign): Implemented. (get_zero_len_passwd):Jeffrey Stedfast2001-04-202-7/+307 * Updated Japanese translation.Akira TAGOH2001-04-202-237/+270 * ">From" is not a citation unless the previous or following line is aDan Winship2001-04-192-7/+44 * Make this more raw: don't do URLs and citations.Dan Winship2001-04-192-3/+12 * Fixed two fatal errors.Richard Hult2001-04-192-2/+6 * missed this with the last commit (pop3 and imap memory leaks)Dan Winship2001-04-191-0/+14 * Don't need to dup the string: the relevant gnome-dialog routine alreadyDan Winship2001-04-193-1/+17 * Plug memory leaks.Dan Winship2001-04-1914-21/+62 * Free base_url and storage_path.Dan Winship2001-04-193-5/+33 * Implemented. (resend_msg): Use is_sent_folder().Jeffrey Stedfast2001-04-192-2/+66 * Free some things that weren't getting freed.Dan Winship2001-04-192-3/+10 * For Dirk-Jan C. Binnema <dirkjan@gnome.org> :Almer S. Tigelaar2001-04-192-866/+786 * Commit the stupid "File -> New Evolution Window" change that got lostEttore Perazzoli2001-04-191-3/+2 * Hot builddir != srcdir loving action.Ettore Perazzoli2001-04-194-1/+15 * Disable the Python stuff and the tests for now. They are broken andEttore Perazzoli2001-04-182-1/+6 * Prepend `$(srcdir)' to the list of libicalss headers to be combined.Ettore Perazzoli2001-04-182-11/+16 * Fix the building of ical.h. Again.Ettore Perazzoli2001-04-182-6/+16 * Re-commit ChangeLog for yesterday's changes to the "New" menu. It wasEttore Perazzoli2001-04-181-0/+9 * #include <unistd.h>Ettore Perazzoli2001-04-182-0/+6 * Connect to the "changed" signal of the categories entry so that they willFederico Mena Quintero2001-04-184-9/+53 * New source files to handle Pkcs7 encryption, decryption, signing, andJeffrey Stedfast2001-04-184-0/+330 * Updated Spanish translationHector Garcia2001-04-182-582/+367 * more auto-indentation magicRadek Doulik2001-04-182-0/+9 * more memory leaksDan Winship2001-04-184-2/+14 * s/helixcode/ximian (How I missed this page on the first go-round I don'tAaron Weber2001-04-188-38/+48 * the libical action stuff uses enums rather than strings to enumerate theJP Rosevear2001-04-182-15/+36 * Proxy events to the tooltip object properly.Christopher James Lahey2001-04-182-0/+55 * The perl script generated files changed between releasesJP Rosevear2001-04-1811-1753/+949 * Hopefully this does itJP Rosevear2001-04-183-471/+0 * Still moreJP Rosevear2001-04-181-1/+0 * Remove more generated files. Apparently i forgot to run make maintainerJP Rosevear2001-04-182-4272/+0 * Removing autogenerated filesJP Rosevear2001-04-189-2282/+0 * Finish merge of new libical 0.23a versionJP Rosevear2001-04-1840-3116/+3303 * This commit was generated by cvs2svn to compensate for changes in r9415,JP Rosevear2001-04-1816-424/+189 * Initial revisionJP Rosevear2001-04-1845-0/+12569 * Pull up fix from the branch:Ettore Perazzoli2001-04-182-1/+6 * Pull up fix from the branch:Ettore Perazzoli2001-04-1810-14/+30 * Pull up fix from the branch:Ettore Perazzoli2001-04-182-0/+7 * Updated Slovak translationStano Visnovsky2001-04-172-595/+737 * Updated Finnish translationjjranta2001-04-172-322/+334 * Updated Japanese translation.Akira TAGOH2001-04-172-551/+881 * don't use g_return'sJeffrey Stedfast2001-04-171-2/+3 * Add EXTRA_GNOME_CFLAGS, for gal.Dan Winship2001-04-172-0/+5 * Don't we want to tell where we are by using the start of the message? IJeffrey Stedfast2001-04-17