aboutsummaryrefslogtreecommitdiffstats
path: root/e-util
diff options
context:
space:
mode:
authorDavid Woodhouse <David.Woodhouse@intel.com>2010-09-17 21:05:13 +0800
committerDavid Woodhouse <David.Woodhouse@intel.com>2010-09-17 21:05:13 +0800
commitb79bf3d187cabd11df74d2e6e414e41ae637f307 (patch)
treee57eab06b64b6074a4115cd33a326a7321c242bf /e-util
parenta4eb9cc4d2878910f1cee45734fac75728603af7 (diff)
downloadgsoc2013-evolution-b79bf3d187cabd11df74d2e6e414e41ae637f307.tar.gz
gsoc2013-evolution-b79bf3d187cabd11df74d2e6e414e41ae637f307.tar.zst
gsoc2013-evolution-b79bf3d187cabd11df74d2e6e414e41ae637f307.zip
Bug 628522 - invalid access off end of array in e_bit_array_delete()
Diffstat (limited to 'e-util')
-rw-r--r--e-util/e-bit-array.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/e-util/e-bit-array.c b/e-util/e-bit-array.c
index 842361d0f2..d8aa620c8d 100644
--- a/e-util/e-bit-array.c
+++ b/e-util/e-bit-array.c
@@ -75,10 +75,11 @@ e_bit_array_delete_real (EBitArray *eba, gint row, gboolean move_selection_mode)
gint i;
gint last;
gint selected = FALSE;
- if (eba->bit_count >= 0) {
+
+ if (eba->bit_count > 0) {
guint32 bitmask;
box = row >> 5;
- last = eba->bit_count >> 5;
+ last = (eba->bit_count - 1) >> 5;
/* Build bitmasks for the left and right half of the box */
bitmask = BITMASK_RIGHT (row) >> 1;
=f3ef291a1d1087f8832421cfcbf7a54385b94dfb'>o/~ Everybody was distfile sizing! o/~kris2004-03-221-0/+1 * Chase MASTER_SITE and project websitekris2004-02-132-2/+2 * Use PLIST_FILES (bento-tested, marcus-reviewed).trevor2004-02-0604-05-28 19:53:48 +0800'>2004-05-281-0/+3 * Give up maintaining msyslog.anders2004-05-281-1/+1 * Bump PORTREVISION on all ports that depend on gettext to aid with upgrading.marcus2004-02-041-1/+1 * Create directories mode 755, not 775kris2003-04-201-2/+2 * Clear moonlight beckons.ade2003-03-071-0/+1 * Update to 1.08f final.anders2003-01-051-8/+3 * Chase libpq version bump.seanc2003-01-041-1/+2 * On request of DougB@, change of USE_PERL5 to USE_PERL5_RUN.edwin2002-11-191-1/+1 * sysutils/msyslog needs perl to configure, -> USE_PERL5=yesedwin2002-11-161-0/+1 * lang/fpc needed perl to complete its install, the others are renamingedwin2002-11-091-2/+3 * Move libs to alat dir like msyslog/audit defaults to.anders2002-03-251-2/+3 * Update to version 1.08f.anders2002-03-241-5/+10 * Set maintainer to ports@FreeBSD.orgpetef2001-10-071-1/+1 * - update to version 1.07petef2001-08-291-30/+14