diff options
| author | Milan Crha <mcrha@redhat.com> | 2013-11-15 16:06:57 +0800 |
|---|---|---|
| committer | Milan Crha <mcrha@redhat.com> | 2013-11-15 16:06:57 +0800 |
| commit | 570c6374806d0f1ec59cf7a72543efe6b5b637be (patch) | |
| tree | c5390b1fcb73f30c28bf37168add9bf1dc622b42 /modules/backup-restore | |
| parent | 1be51f232560f864ba8795a38e55d472b5b0e2b3 (diff) | |
| download | gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.gz gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.tar.zst gsoc2013-evolution-570c6374806d0f1ec59cf7a72543efe6b5b637be.zip | |
Fix/mute issues found by Coverity scan
This makes the code free of Coverity scan issues.
It is sometimes quite pedantic and expects/suggests some
coding habits, thus certain changes may look weird, but for a good
thing, I hope. The code is also tagged with Coverity scan
suppressions, to keep the code as is and hide the warning too.
Also note that Coverity treats g_return_if_fail(), g_assert() and
similar macros as unreliable, and it's true these can be disabled
during the compile time, thus it brings in other set of 'weird'
changes.
Diffstat (limited to 'modules/backup-restore')
| -rw-r--r-- | modules/backup-restore/evolution-backup-tool.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/modules/backup-restore/evolution-backup-tool.c b/modules/backup-restore/evolution-backup-tool.c index 3ca07ecea2..d164d8b216 100644 --- a/modules/backup-restore/evolution-backup-tool.c +++ b/modules/backup-restore/evolution-backup-tool.c @@ -98,7 +98,7 @@ static GOptionEntry options[] = { #define d(x) #define print_and_run(x) \ - G_STMT_START { g_message ("%s", x); system (x); } G_STMT_END + G_STMT_START { g_message ("%s", x); if (system (x) == -1) g_warning ("%s: Failed to execute '%s'", G_STRFUNC, (x)); } G_STMT_END static gboolean check (const gchar *filename, gboolean *is_new_format); |