aboutsummaryrefslogtreecommitdiffstats
path: root/plugins/exchange-operations
diff options
context:
space:
mode:
authorSushma Rai <rsushma@src.gnome.org>2006-02-06 16:53:21 +0800
committerSushma Rai <rsushma@src.gnome.org>2006-02-06 16:53:21 +0800
commit90e3e5497f9b6b7555036c776c77f2c81a4c839d (patch)
treeb37a8550dee6911bbe256d310455bfe134ff67b3 /plugins/exchange-operations
parent3c44c1e40dd87f7869f19c1ab82fcdcfdf2b720f (diff)
downloadgsoc2013-evolution-90e3e5497f9b6b7555036c776c77f2c81a4c839d.tar.gz
gsoc2013-evolution-90e3e5497f9b6b7555036c776c77f2c81a4c839d.tar.zst
gsoc2013-evolution-90e3e5497f9b6b7555036c776c77f2c81a4c839d.zip
Fixed memory leaks. Fixes #329251.
svn path=/trunk/; revision=31418
Diffstat (limited to 'plugins/exchange-operations')
-rw-r--r--plugins/exchange-operations/ChangeLog20
-rw-r--r--plugins/exchange-operations/exchange-calendar.c6
-rw-r--r--plugins/exchange-operations/exchange-contacts.c4
-rw-r--r--plugins/exchange-operations/exchange-permissions-dialog.c6
4 files changed, 32 insertions, 4 deletions
diff --git a/plugins/exchange-operations/ChangeLog b/plugins/exchange-operations/ChangeLog
index 80a84cc338..36d4df9009 100644
--- a/plugins/exchange-operations/ChangeLog
+++ b/plugins/exchange-operations/ChangeLog
@@ -1,3 +1,13 @@
+2006-02-06 Sushma Rai <rsushma@novell.com>
+
+ * exchange-permissions-dialog.c (exchange_permissions_dialog_new):
+ Initializing nresults to zero and freeing E2kResult.
+
+ * exchange-calendar.c (e_exchange_calendar_commit): Freeing authtype.
+
+ * exchange-contacts.c (e_exchange_contacts_commit): Similar.
+ Fixes #329251.
+
2006-02-05 Karsten Bräckelmann <guenther@rudersport.de>
* exchange-user-dialog.c (e2k_user_dialog_construct):
@@ -6,6 +16,16 @@
2006-02-03 Sushma Rai <rsushma@novell.com>
+ * exchange-permissions-dialog.c (exchange_permissions_dialog_new):
+ Freeing E2kResult.
+
+ * exchange-calendar.c (e_exchange_calendar_commit): Freeing authtype.
+
+ * exchange-contacts.c (e_exchange_contacts_commit): similar.
+ See #329251.
+
+2006-02-03 Sushma Rai <rsushma@novell.com>
+
* exchange-folder.c (org_gnome_exchange_folder_subscription): Moved
discovering the shared folder, opening that folder and error handling
out to create_folder_subscription_dialog().
diff --git a/plugins/exchange-operations/exchange-calendar.c b/plugins/exchange-operations/exchange-calendar.c
index 7dfc767222..f0ebfb80e9 100644
--- a/plugins/exchange-operations/exchange-calendar.c
+++ b/plugins/exchange-operations/exchange-calendar.c
@@ -397,8 +397,10 @@ e_exchange_calendar_commit (EPlugin *epl, EConfigTarget *target)
e_source_set_relative_uri (source, ruri);
e_source_set_property (source, "username", username);
e_source_set_property (source, "auth-domain", "Exchange");
- if (authtype)
- e_source_set_property (source, "auth-type", authtype);
+ if (authtype) {
+ e_source_set_property (source, "auth-type", authtype);
+ g_free (authtype);
+ }
e_source_set_property (source, "auth", "1");
if (!calendar_src_exists) {
diff --git a/plugins/exchange-operations/exchange-contacts.c b/plugins/exchange-operations/exchange-contacts.c
index 46ab1f8f7a..164a314549 100644
--- a/plugins/exchange-operations/exchange-contacts.c
+++ b/plugins/exchange-operations/exchange-contacts.c
@@ -365,8 +365,10 @@ e_exchange_contacts_commit (EPlugin *epl, EConfigTarget *target)
e_source_set_relative_uri (source, ruri);
e_source_set_property (source, "username", username);
e_source_set_property (source, "auth-domain", "Exchange");
- if (authtype)
+ if (authtype) {
e_source_set_property (source, "auth-type", authtype);
+ g_free (authtype);
+ }
e_source_set_property (source, "auth", "plain/password");
if (!contacts_src_exists) {
diff --git a/plugins/exchange-operations/exchange-permissions-dialog.c b/plugins/exchange-operations/exchange-permissions-dialog.c
index b8a3fd45a4..9c9aaefb50 100644
--- a/plugins/exchange-operations/exchange-permissions-dialog.c
+++ b/plugins/exchange-operations/exchange-permissions-dialog.c
@@ -169,7 +169,7 @@ exchange_permissions_dialog_new (ExchangeAccount *account,
char *title;
E2kHTTPStatus status;
E2kResult *results;
- int nresults;
+ int nresults = 0;
xmlNode *xml_form;
GByteArray *binary_form;
@@ -229,6 +229,8 @@ exchange_permissions_dialog_new (ExchangeAccount *account,
lose:
e_error_run (GTK_WINDOW (parent), ERROR_DOMAIN ":perm-read-error", NULL);
gtk_widget_destroy (GTK_WIDGET (dialog));
+ if (nresults)
+ e2k_results_free (results, nresults);
return;
}
@@ -245,6 +247,8 @@ exchange_permissions_dialog_new (ExchangeAccount *account,
setup_user_list (dialog);
gtk_widget_show (GTK_WIDGET (dialog));
+ if (nresults)
+ e2k_results_free (results, nresults);
}
static void