aboutsummaryrefslogtreecommitdiffstats
path: root/shell
diff options
context:
space:
mode:
authorEttore Perazzoli <ettore@src.gnome.org>2001-10-26 06:28:13 +0800
committerEttore Perazzoli <ettore@src.gnome.org>2001-10-26 06:28:13 +0800
commitfb5bec84e981634dc04575eda4e4149b3c536923 (patch)
tree61d455af1708a711100167d25fc896423de77b43 /shell
parent5fe02094b8afe4210e7e720b5fc62b29d91efb95 (diff)
downloadgsoc2013-evolution-fb5bec84e981634dc04575eda4e4149b3c536923.tar.gz
gsoc2013-evolution-fb5bec84e981634dc04575eda4e4149b3c536923.tar.zst
gsoc2013-evolution-fb5bec84e981634dc04575eda4e4149b3c536923.zip
Handle failure from XGetClassHint properly. Also, free res_name and
* e-shell.c (impl_Shell_selectUserFolder): Handle failure from XGetClassHint properly. Also, free res_name and res_class in case of success. Fixes #13554. svn path=/trunk/; revision=14104
Diffstat (limited to 'shell')
-rw-r--r--shell/ChangeLog6
-rw-r--r--shell/e-shell.c10
2 files changed, 12 insertions, 4 deletions
diff --git a/shell/ChangeLog b/shell/ChangeLog
index 8176a45f0a..a2e060900c 100644
--- a/shell/ChangeLog
+++ b/shell/ChangeLog
@@ -1,5 +1,11 @@
2001-10-25 Ettore Perazzoli <ettore@ximian.com>
+ * e-shell.c (impl_Shell_selectUserFolder): Handle failure from
+ XGetClassHint properly. Also, free res_name and res_class in case
+ of success. Fixes #13554.
+
+2001-10-25 Ettore Perazzoli <ettore@ximian.com>
+
* e-storage-set-view.c (etree_icon_at): Don't display an icon for
storages that have subfolders.
diff --git a/shell/e-shell.c b/shell/e-shell.c
index bfce4e473a..017ee41901 100644
--- a/shell/e-shell.c
+++ b/shell/e-shell.c
@@ -483,10 +483,12 @@ impl_Shell_selectUserFolder (PortableServer_Servant servant,
e_set_dialog_parent_from_xid (GTK_WINDOW (folder_selection_dialog), parent_xid);
- XGetClassHint (GDK_DISPLAY (), (Window) parent_xid, &class_hints);
-
- gtk_window_set_wmclass (GTK_WINDOW (folder_selection_dialog),
- class_hints.res_name, class_hints.res_class);
+ if (XGetClassHint (GDK_DISPLAY (), (Window) parent_xid, &class_hints)) {
+ gtk_window_set_wmclass (GTK_WINDOW (folder_selection_dialog),
+ class_hints.res_name, class_hints.res_class);
+ XFree (class_hints.res_name);
+ XFree (class_hints.res_class);
+ }
gtk_widget_show (folder_selection_dialog);
Convert a bunch of USE_BZIP2 to USES=tar:bzip2adamw2014-07-301-2/+1 * Rename all patches that contain '::' as a path separator, and useadamw2014-07-303-0/+0 * Modernize LIB_DEPENDSbapt2014-07-151-6/+6 * Convert GMAKE to MAKE_CMDbapt2014-06-251-5/+5 * support LDFLAGS (fixes libghemical)maho2014-03-252-11/+6 * Update the default version of GCC used in the Ports Collection fromgerald2014-03-111-1/+1 * Convert all USE_FORTRAN=yes to "USES=fortran, USE_GCC=yes". In most casestijl2014-02-171-13/+9 * Update to libmpc version 1.0.1 which brings the following fixes:gerald2013-10-261-1/+1 * Add NO_STAGE all over the place in preparation for the staging support (cat: ...bapt2013-09-211-5/+2 * - convert to the new perl5 frameworkaz2013-09-161-2/+1 * Rectify USE_TEX to support both of teTeX and TeXLive.hrs2013-05-121-1/+1 * Remove *_DEPENDS from ports which depend on teTeX and add USE_TEX=tetexhrs2013-05-061-1/+1 * Fix recent build on tinderbox. Somehow "sc_PsiCCSD_T.3" is notmaho2013-01-082-7/+10 * - update png to 1.5.10dinoex2012-06-011-1/+1 * adjust linking and comments in dependent ports after the math/atlas update;bf2011-11-221-3/+3 * Chase the upgrade of MPICH2.thierry2011-02-26