aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--mail/ChangeLog12
-rw-r--r--mail/mail-local.c3
-rw-r--r--mail/message-browser.c13
3 files changed, 17 insertions, 11 deletions
diff --git a/mail/ChangeLog b/mail/ChangeLog
index a685ad6b77..67cdf4160b 100644
--- a/mail/ChangeLog
+++ b/mail/ChangeLog
@@ -1,3 +1,15 @@
+2001-05-29 Jason Leach <jleach@ximian.com>
+
+ * message-browser.c (message_browser_new): one-line fix for bug
+ #2536: File->Close in message viewer doesn't work.
+ (message_browser_new): Also replaced like 4 lines of code with a
+ one-liner featuring gnome_app_create_toolbar_with_data().
+
+2001-05-28 Jason Leach <jleach@ximian.com>
+
+ * mail-local.c (load_metainfo): Don't need to check if (foo!=NULL)
+ before doing an xmlFreeDoc().
+
2001-05-28 Dan Winship <danw@ximian.com>
* mail-format.c (write_text_header): Fix a bug that could cause a
diff --git a/mail/mail-local.c b/mail/mail-local.c
index 0805fd38a2..570fc9847b 100644
--- a/mail/mail-local.c
+++ b/mail/mail-local.c
@@ -129,8 +129,7 @@ load_metainfo(const char *path)
meta->format = g_strdup("mbox"); /* defaults */
meta->name = g_strdup("mbox");
meta->indexed = TRUE;
- if (doc)
- xmlFreeDoc(doc);
+ xmlFreeDoc(doc);
return meta;
}
diff --git a/mail/message-browser.c b/mail/message-browser.c
index 8bd4470235..f3de72806a 100644
--- a/mail/message-browser.c
+++ b/mail/message-browser.c
@@ -256,7 +256,7 @@ set_default_size (GtkWidget *widget)
GtkWidget *
message_browser_new (const GNOME_Evolution_Shell shell, const char *uri, const char *uid)
{
- GtkWidget *toolbar, *vbox;
+ GtkWidget *vbox;
MessageBrowser *new;
FolderBrowser *fb;
@@ -265,14 +265,9 @@ message_browser_new (const GNOME_Evolution_Shell shell, const char *uri, const c
gnome_app_construct (GNOME_APP (new), "Evolution", "");
gtk_object_set_data_full (GTK_OBJECT (new), "uid", g_strdup (uid), g_free);
-
- toolbar = gtk_toolbar_new (GTK_ORIENTATION_HORIZONTAL, GTK_TOOLBAR_BOTH);
- gnome_app_fill_toolbar_with_data (GTK_TOOLBAR (toolbar),
- message_browser_toolbar,
- NULL, new);
-
- gnome_app_set_toolbar (GNOME_APP (new), GTK_TOOLBAR (toolbar));
- gnome_app_create_menus (GNOME_APP (new), message_browser_menubar);
+
+ gnome_app_create_toolbar_with_data (GNOME_APP (new), message_browser_toolbar, new);
+ gnome_app_create_menus_with_data (GNOME_APP (new), message_browser_menubar, new);
fb = FOLDER_BROWSER (folder_browser_new (shell));
new->fb = fb;
letions'>-0/+179 * Always build with JIT supportmm2012-09-171-5/+2 * - Chase new spidermonkey location [1]beat2012-09-172-55/+53 * - Update to 0.40jadawin2012-09-172-3/+3 * - update to 4.4.2rm2012-09-174-19/+12 * - Update to 1.49jadawin2012-09-172-3/+3 * fixed a FreeBSD 9.x build issuedaichi2012-09-174-7/+14 * Update to 0.05070421lth2012-09-172-4/+5 * - update to 0.10.20bapt2012-09-172-3/+3 * - Update to 0.7.0wen2012-09-174-10/+10 * - update openimageio to 1.0.9rm2012-09-176-12/+18 * - Fix build on PowerPCswills2012-09-174-24/+40 * Password management should be simple and follow Unix philosophy. With pass, eachswills2012-09-178-0/+1512 * - Update to 1.4.15swills2012-09-172-14/+35 * Convert to optionsngeadler2012-09-171-19/+19 * drop maintainershipbapt2012-09-171-6/+2 * - Mark as deprecated. Upstream disappeared (domain has expired), doesn't work onrm2012-09-171-0/+4 * - drop maintainershipdinoex2012-09-171-1/+1 * - drop maintainershipdinoex2012-09-171-1/+1 * - drop maintainershipdinoex2012-09-172-2/+2 * Unbreak by setting another MASTER_SITE.rakuco2012-09-171-3/+1 * Adds support for the Jabber (XMPP) protocol to Licq. Still in earlydinoex2012-09-173-0/+47 * - Update Calligra Suite to 2.5.2.avilla2012-09-1730-57/+75 * Add p5-Version-Next 0.002, increment module version numbers simply andlth2012-09-175-0/+35 * - fix fetch by commenting out CHEESESHOP mirrorsrm2012-09-173-7/+6 * - Update to 2.2.0bdrewery2012-09-172-4/+4 * - use OPTIONS_DEFINEdinoex2012-09-171-11/+11 * - Defauls of webalizer changeddinoex2012-09-171-0/+6 * Update to 0.4003lth2012-09-172-4/+3 * - use OPTIONS_DEFINE in master portdinoex2012-09-171-2/+0 * - use OPTIONS_DEFINEdinoex2012-09-172-20/+35 * Add p5-MooseX-AttributeShortcuts 0.015, shorthand for common attributelth2012-09-175-0/+39 * Add p5-Test-Moose-More 0.011, more tools for testing Moose packages.lth2012-09-175-0/+37 * - use OPTIONS_DEFINEdinoex2012-09-161-6/+8 * - use OPTIONS_DEFINEdinoex2012-09-161-5/+6 * - use OPTIONS_DEFINEdinoex2012-09-161-24/+25 * - pass maintainership to new volunteerrm2012-09-161-1/+1 * - use OPTIONS_DEFINEdinoex2012-09-161-2/+2 * - use OPTIONS_DEFINEdinoex2012-09-161-4/+6 * Add p5-Moose-Test 0.01, a Test Runner for the Moose test suite.lth2012-09-165-0/+37 * - use OPTIONS_DEFINEdinoex2012-09-162-17/+9 * - use OPTIONS_DEFINEdinoex2012-09-161-6/+7 * - use OPTIONS_DEFINEdinoex2012-09-161-6/+6 * Reduce number of hardcoded port name (where appropriate).danfe2012-09-161-4/+4 * - bump PORTREVISION because of changes in previous commitrm2012-09-161-0/+1 * - update dependency version on databases/py-whisperrm2012-09-165-29/+31 * BitchX, an ass-kicking IRC client, is out of limbo and back on the track!danfe2012-09-1610-1219/+77 * Update to 0.6.0.rakuco2012-09-166-77/+270 * Accepts the new svn_revision tag in the removed ports xml database.crees2012-09-161-5/+11 * Update to 0.32lth2012-09-162-3/+3 * Update to 0.30lth2012-09-162-3/+3 * Gjiten is a Japanese dictionary program for GNOME.culot2012-09-165-0/+121 * - fix buildrm2012-09-161-0/+20 * Fix path to the tix dependency.rakuco2012-09-161-1/+1 * Point shebang in a perl script to ${PERL} in order to solve a build problem ifehaupt2012-09-161-0/+1 * Update to 3.7 beta 24johans2012-09-162-3/+3 * - Revert patch for CVE-2012-0946 to its original form and apply both CVEdanfe2012-09-162-21/+9 * Atttempt to fix build.linimon2012-09-161-1/+1 * - Update to 0.13culot2012-09-162-3/+3 * - Update to 0.04culot2012-09-162-3/+6 * - Update to 1.08culot2012-09-162-3/+3 * - Update to 0.28culot2012-09-162-4/+4 * - Update to 0.053wen2012-09-162-3/+3 * - Update to 2.3.54.stephen2012-09-162-3/+3 * - Update to 1.2.1.stephen2012-09-162-3/+3 * - Covert to OptionsNGeadler2012-09-162-6/+7 * include newly 'awarded' CVEeadler2012-09-161-0/+1 * remove empty files / directories.eadler2012-09-165-0/+0 * ktorrent: Try enabling MAKE_JOBS_SAFE againrakuco2012-09-161-1/+1 * {lib}ktorrent: Follow the trend of not specifying library shversions in the d...rakuco2012-09-162-5/+5 * Remove pointless header lines from ports I created once upon a time.naddy2012-09-1621-94/+0 * Update to 0.1.5.naddy2012-09-162-8/+3 * Update to 1.0.1. Opus has now been standardized by the IETF as RFC 6716.naddy2012-09-164-17/+17 * Add vuxml for older versions of multimedia/vlc .nox2012-09-161-0/+30 * It requires some additional ruby libs build for ruby19.ume2012-09-152-2/+14 * - sync packetstorm mirrors list (remove two dead mirrors)rm2012-09-151-2/+0 * - Remove dead mirror from MASTER_SITE_QT.avilla2012-09-151-1/+0 * Covert to OptionsNGeadler2012-09-151-17/+19 * - Covert to OptionsNGeadler2012-09-152-11/+8 * - Update to 1.7culot2012-09-153-4/+13 * - Update to 0.47culot2012-09-152-4/+3 * - Update to 1.0.23 [1]ak2012-09-153-17/+18 * - Update to 1.33culot2012-09-152-3/+6 * - Update to 0.8culot2012-09-152-3/+6 * This module translates national characters into similar sounding latinrm2012-09-154-0/+30 * - Update to 0.7.0wen2012-09-153-4/+4 * - Update to 0.7.0wen2012-09-153-4/+4 * . Update to 2012.f.glewis2012-09-152-3/+3 * Tell the world about the recent bacula vulneadler2012-09-151-0/+31 * - Update to 20120914 snapshotbdrewery2012-09-152-4/+4 * Respect MOVEDLint's request to mark this port as aliveeadler2012-09-151-1/+0 * - update dependencies to use PYGAMEjgh2012-09-154-4/+4 * Simplify the previous commit a bit.jkim2012-09-152-3/+2 * - Update to 1.5.4.jkim2012-09-154-49/+65 * Add an option to build with Eclipse Java Compiler. It also addsjkim2012-09-153-1/+27 * - update to 0.8.9bapt2012-09-152-5/+4 * Upgrade to svn rev r163622. Several fixes to FreeBSD support for -pie andbrooks2012-09-157-225/+35 * - update bacula-server and bacula-docs to 5.2.12rm2012-09-154-8/+8 * - Update to 1.6-1tota2012-09-152-4/+3 * - disconnect japanese/postgresqlXX-man from the buildrm2012-09-152-4/+4 * - Convert to new options frameworkbdrewery2012-09-151-17/+15 * Remove unmaintained ports, that installs Japanese PostgreSQL man-pages forrm2012-09-1519-781/+3 * Update CMake to 2.8.9.rakuco2012-09-158-68/+24 * - Convert to new options frameworkbdrewery2012-09-151-16/+16 * - Convert to new options frameworkbdrewery2012-09-151-21/+19 * - Default to DAEMON modebdrewery2012-09-151-2/+4 * - update to 3.2.2jgh2012-09-152-9/+3 * - Convert to new options frameworkbdrewery2012-09-151-12/+14 * Add license.jkim2012-09-151-0/+2 * - Update to 1.0.2bdrewery2012-09-152-8/+6 * - Update to version 0.0.11 (alpha 11)madpilot2012-09-155-58/+38 * - Update to 0.99.jkim2012-09-154-168/+204 * Update from p303 to p304.cy2012-09-152-3/+3 * - Mark BROKEN: conflicting dependenciesbeat2012-09-151-0/+2 * - Switch to USE_GITHUB as it does work on non-taggedbdrewery2012-09-152-5/+4 * - Switch to USE_GITHUB/GH as the primary MASTER_SITE as itbdrewery2012-09-153-7/+10 * - Chase openmpi updatebeat2012-09-151-1/+2 * - Update zathura, zathura-djvu and zathura-pdf-poppler to 0.2.0madpilot2012-09-1510-34/+70 * Update to 0.1.3.madpilot2012-09-153-6/+12 * Convert to optionsngeadler2012-09-141-30/+25 * (1) Update to latest 1.7.6lev2012-09-147-109/+206 * - Update to 0.11culot2012-09-142-4/+10 * - USE_XLIB has gone from the Mk/bsd.*.mk the macro doesn't have any effectbapt2012-09-141-1/+0 * - Update to 1.9.4.2culot2012-09-142-3/+3 * - Update to 3.1.22culot2012-09-142-3/+3 * Upgrade to 3.13.7.vanilla2012-09-142-3/+3 * - put GDBM and QDBM options into an OPTIONS_SINGLE, the cannot be usedflo2012-09-141-2/+4 * - chase textproc/nltk update (upstream switched to setuptools)rm2012-09-141-1/+2 * - Update to 0.18jadawin2012-09-142-3/+3 * - Update to 1.05jadawin2012-09-142-4/+3 * Force to use GCC on FreeBSD 8.x, since with clang it builds fine,ale2012-09-141-0/+6 * This port adds the Carrier Module to the Tryton Application Platform.wen2012-09-145-0/+71 * This port adds the Project Revenue Module to the Tryton Application Platform.wen2012-09-145-0/+75 * - adjust run dependenciesjgh2012-09-141-17/+14 * This port adds the Project Plan Module to the Tryton Application Platform.wen2012-09-145-0/+74 * This port adds the Project Module to the Tryton Application Platform.wen2012-09-145-0/+74 * - add startup scriptjgh2012-09-142-12/+17 * Fix typo.linimon2012-09-141-2/+2 * Revert r302983. It cause another bug.sumikawa2012-09-142-50/+1 * - chase japanese/eb update, that I forgot in previous commitrm2012-09-142-9/+3 * - Update to 0.12sunpoet2012-09-143-5/+7 * - Update to 1.07sunpoet2012-09-143-5/+28 * This port adds the Dashboard Module to the Tryton Application Platform.wen2012-09-145-0/+77 * This port adds the Sale Module to the Tryton Application Platform.wen2012-09-145-0/+82 * - Update to 1.15.2sunpoet2012-09-142-7/+6 * trytond_purchase is the Purchase Module to the Tryton Application Platform.wen2012-09-145-0/+82 * - Update to 0.12sunpoet2012-09-14