aboutsummaryrefslogtreecommitdiffstats
path: root/addressbook
Commit message (Collapse)AuthorAgeFilesLines
* Put up an error dialog if there's an error while saving. If the personChristopher James Lahey2001-10-222-1/+26
| | | | | | | | | | | 2001-10-22 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/e-contact-save-as.c (save_it): Put up an error dialog if there's an error while saving. If the person hits cancel on the "file exists" dialog, don't close the file selection dialog. Fixes Ximian bug #7055. svn path=/trunk/; revision=13865
* right_click_up here when we let go of the popup.Christopher James Lahey2001-10-213-0/+9
| | | | | | | | | | | | | 2001-10-21 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (model_and_selection_free): right_click_up here when we let go of the popup. * gui/widgets/e-minicard-view.c (e_minicard_view_selection_event): right_click_up here. svn path=/trunk/; revision=13843
* Use an EEntry here instead of a GtkLabel. Fixes Ximian bug #7067.Christopher James Lahey2001-10-212-33/+29
| | | | | | | | | | 2001-10-21 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_add_section, e_select_names_set_default): Use an EEntry here instead of a GtkLabel. Fixes Ximian bug #7067. svn path=/trunk/; revision=13841
* Call e_addressbook_model_force_folder_bar_message when we activate theJon Trowbridge2001-10-214-2/+24
| | | | | | | | | | | | | | 2001-10-21 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c (control_activate_cb): Call e_addressbook_model_force_folder_bar_message when we activate the component. (Fixes bug #11749) * gui/widgets/e-addressbook-model.c (e_addressbook_model_force_folder_bar_message): Added. Forces emission of a folder_bar_message. svn path=/trunk/; revision=13840
* (e_select_names_set_default): don't forget to unref the oldstyle.Larry Ewing2001-10-212-1/+2
| | | | | | | | 2001-10-20 Larry Ewing <lewing@ximian.com> (e_select_names_set_default): don't forget to unref the oldstyle. svn path=/trunk/; revision=13839
* stick with the style font if the efont bold font does not exist.Larry Ewing2001-10-212-8/+24
| | | | | | | | | | 2001-10-20 Larry Ewing <lewing@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_set_default): stick with the style font if the efont bold font does not exist. svn path=/trunk/; revision=13838
* Fix memory leak.Jon Trowbridge2001-10-215-1/+21
| | | | | | | | | | | | | | | | | | 2001-10-20 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (name_style_query): Fix memory leak. * gui/widgets/e-addressbook-view.c (jump_to_letter): Free our string vector letter_v when we are done with it. * gui/contact-editor/e-contact-quick-add.c (edit_card): Unref our QuickAdd structure. * gui/component/e-address-popup.c (e_address_popup_construct): Unref our style after we are done with it. svn path=/trunk/; revision=13835
* We shouldn't leak the info returned by oaf_query.Jon Trowbridge2001-10-214-2/+17
| | | | | | | | | | | | | | | | 2001-10-20 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book.c (activate_factories_for_uri): We shouldn't leak the info returned by oaf_query. * gui/contact-editor/e-contact-quick-add.c (card_added_cb): Remove superfluous call to quick_add_unref. (editor_closed_cb): Remove superfluous call to quick_add_unref. * gui/component/select-names/e-select-names.c (esn_get_key_fn): We need to unref the card returned by e_addressbook_model_get_card. svn path=/trunk/; revision=13834
* Make LDAP servers non-user-creatable.Ettore Perazzoli2001-10-212-1/+6
| | | | | | | * gui/component/addressbook-component.c: Make LDAP servers non-user-creatable. svn path=/trunk/; revision=13833
* Check that the string we are checking for xml-ness is non-NULL.Jon Trowbridge2001-10-212-1/+4
| | | | | | | | | 2001-10-20 Jon Trowbridge <trow@ximian.com> * printing/e-contact-print.c (e_contact_print_card): Check that the string we are checking for xml-ness is non-NULL. svn path=/trunk/; revision=13830
* Filter out empty destinations. (also Bug #13036)Jon Trowbridge2001-10-214-12/+58
| | | | | | | | | | | | | | | | | | | | | 2001-10-20 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_importv): Filter out empty destinations. (also Bug #13036) * printing/e-contact-print.c (e_contact_build_style): Use gnome_font_new_closest; if gnome_font_new fails and returns NULL, our spacing gets all messed up. (Bug #10785) * gui/widgets/e-addressbook-view.c (e_addressbook_view_can_print): Allow printing if there are any cards in our view. The selection has nothing to do with it. * backend/ebook/e-destination.c (e_destination_is_empty): Check for strings that contain non-whitespace, rather than just looking for a non-zero first character. (Bug #13036) svn path=/trunk/; revision=13826
* Handle focus_change in event by selecting that contact. Fixes Ximian bugChristopher James Lahey2001-10-212-0/+17
| | | | | | | | | | 2001-10-20 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-minicard-view.c (e_minicard_view_selection_event): Handle focus_change in event by selecting that contact. Fixes Ximian bug #3024. svn path=/trunk/; revision=13825
* Repeatedly call gtk_main_quit here as long as there is a main loop around.Christopher James Lahey2001-10-202-2/+16
| | | | | | | | | | 2001-10-20 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook-component.c (owner_unset_cb): Repeatedly call gtk_main_quit here as long as there is a main loop around. This is an ugly hack around Ximian bug #11760. svn path=/trunk/; revision=13821
* Added #include <gal/widgets/e-unicode.h>.Christopher James Lahey2001-10-203-62/+101
| | | | | | | | | | | | | | 2001-10-20 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c: Added #include <gal/widgets/e-unicode.h>. * gui/widgets/e-minicard-control.c: Made this display the number of extra cards in the attachment as well as made it save them all to the local addressbook if the person selects the button. Fixes Ximian bug #9507. svn path=/trunk/; revision=13820
* Changed this to not grab on a right click. Fixes Ximian bug #12660.Christopher James Lahey2001-10-202-1/+10
| | | | | | | | | 2001-10-20 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-minicard.c (e_minicard_event): Changed this to not grab on a right click. Fixes Ximian bug #12660. svn path=/trunk/; revision=13818
* Pass the @folder_type to ::handleDrop.Ettore Perazzoli2001-10-202-1/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * e-storage-set-view.c (tree_drag_data_received): Pass the @folder_type to ::handleDrop. * evolution-shell-component-dnd.c (impl_GNOME_Evolution_ShellComponentDnd_DestinationFolder_handleMotion): New arg @folder_type. (impl_GNOME_Evolution_ShellComponentDnd_DestinationFolder_handleDrop): Likewise. * evolution-shell-component-dnd.h: Add @folder_type to `DndDestinationFolderHandleDropFn' and `DndDestinationFolderHandleMotionFn'. * e-storage-set-view.c (tree_drag_motion): Pass the folder type to `::handleMotion'. * Evolution-ShellComponentDnd.idl: Pass @folder_type in ::handleDrop and ::handleMotion. * component-factory.c (destination_folder_handle_motion): Get @folder_type here too [to match the changes in the EvolutionShellComponentDnd interface]. Also, remove a debugging message. (destination_folder_handle_drop): Likewise. * gui/component/addressbook-component.c (destination_folder_handle_motion): Get @folder_type here too [to match the changes in the EvolutionShellComponentDnd interface]. Also, remove a debugging message. (destination_folder_handle_drop): Likewise. svn path=/trunk/; revision=13807
* Translate labels in select-names option menu. (Bug #9604)Jon Trowbridge2001-10-203-2/+15
| | | | | | | | | | | | | 2001-10-18 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (add_menu_item): Translate labels in select-names option menu. (Bug #9604) * gui/search/e-addressbook-search-dialog.c (e_addressbook_search_dialog_init): Made the default window size slightly wider. (Bug #7516) svn path=/trunk/; revision=13795
* Made this take a const GList.Christopher James Lahey2001-10-193-4/+9
| | | | | | | | | 2001-10-18 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card.c, backend/ebook/e-card.h (e_card_list_get_vcard): Made this take a const GList. svn path=/trunk/; revision=13773
* Added. Check if our book is local or networked.Jon Trowbridge2001-10-192-0/+25
| | | | | | | | | | | | | | | | 2001-10-18 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (check_capabilities): Added. Check if our book is local or networked. (e_select_names_completion_book_ready): Call check_capabilities. (e_select_names_completion_new): Call check_capabilities. (e_select_names_completion_do_query): If we have a networked book, keep trying if we haven't been able to cache any cards --- our earlier attempts could have failed due to too many matches. (Bug #12932) svn path=/trunk/; revision=13762
* Lag our cardification on focus-out. This seems to help with the unintendedJon Trowbridge2001-10-193-5/+11
| | | | | | | | | | | | | | 2001-10-18 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (focus_out_cb): Lag our cardification on focus-out. This seems to help with the unintended cardifications that can result from the weird focus-out/focus-in events that get generated when the popup disappears. * backend/ebook/e-card-compare.c: Removed some debug spew. svn path=/trunk/; revision=13757
* grab focus in the Account entry when preparing the dialog, fixes #10406.Chris Toshok2001-10-182-0/+10
| | | | | | | | | | 2001-10-17 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-config.c (addressbook_source_dialog): grab focus in the Account entry when preparing the dialog, fixes #10406. svn path=/trunk/; revision=13734
* make sure to also add "ldap-contacts" folders to the option menu.Chris Toshok2001-10-182-1/+7
| | | | | | | | | 2001-10-17 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names.c (new_folder): make sure to also add "ldap-contacts" folders to the option menu. svn path=/trunk/; revision=13733
* sync all the fields we can, with out overwritingJP Rosevear2001-10-182-110/+369
| | | | | | | | | | | | 2001-10-17 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): sync all the fields we can, with out overwriting (local_record_from_ecard): write the fields to the pilot in priority order unless there are fields on the pilot we can't store, then fill in the fields as they are on the pilot svn path=/trunk/; revision=13728
* Did a bit of clean up here. Might fix some crashes, specifically XimianChristopher James Lahey2001-10-173-47/+57
| | | | | | | | | | | | 2001-10-17 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card.c (e_card_get_vobject): Did a bit of clean up here. Might fix some crashes, specifically Ximian bug #10164. * gui/widgets/e-addressbook-view.c (SPEC): Updated the model column numbers here. Fixes Ximian bug #12308. svn path=/trunk/; revision=13721
* add upgrade from 0.1 to 0.2, where we make sure id dbt's match vcard id's,Chris Toshok2001-10-172-29/+104
| | | | | | | | | | | | | | | | 2001-10-17 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_upgrade_db): add upgrade from 0.1 to 0.2, where we make sure id dbt's match vcard id's, fixes longstanding bug (#7406) where cards were not modifiable or removable after having been created during a 1-2 week long window in early betas. (PAS_BACKEND_FILE_VERSION): change to 0.2 (PAS_ID_PREFIX): #define this here. (pas_backend_file_create_unique_id): use PAS_ID_PREFIX instead of the string. svn path=/trunk/; revision=13720
* Check for no extensionIain Holmes2001-10-172-0/+9
| | | | svn path=/trunk/; revision=13710
* If card->id is NULL, return an empty string. (e_card_set_id): Don't allowJon Trowbridge2001-10-172-3/+12
| | | | | | | | | | | | | 2001-10-16 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card.c (e_card_get_id): If card->id is NULL, return an empty string. (e_card_set_id): Don't allow the card id to be set to NULL; use the empty string instead. (e_card_get_vobject): When building our vcard, pass in the empty string as the id if card->id is NULL. (Bug #10164) svn path=/trunk/; revision=13705
* don't set the phone info if it is blank (ecard_from_remote_record): saveJP Rosevear2001-10-172-10/+29
| | | | | | | | | | 2001-10-16 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (local_record_from_ecard): don't set the phone info if it is blank (ecard_from_remote_record): save up to 3 fax numbers svn path=/trunk/; revision=13694
* unref the book after we pass it off to evolution-addressbook.Chris Toshok2001-10-162-0/+23
| | | | | | | | | 2001-10-15 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (pas_backend_ldap_add_client): unref the book after we pass it off to evolution-addressbook. svn path=/trunk/; revision=13691
* unref op->view. (pas_backend_ldap_process_create_card): ref op->view.Chris Toshok2001-10-162-3/+39
| | | | | | | | | | | | | | | | 2001-10-15 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (create_card_dtor): unref op->view. (pas_backend_ldap_process_create_card): ref op->view. (remove_card_dtor): unref op->view. (pas_backend_ldap_process_remove_card): ref op->view. (modify_card_dtor): unref op->view. (pas_backend_ldap_process_modify_card): ref op->view. (ldap_search_dtor): unref op->view. (pas_backend_ldap_search): ref op->view. svn path=/trunk/; revision=13690
* make sure to unref the book_view here so we don't leak them.Chris Toshok2001-10-162-1/+15
| | | | | | | | | | 2001-10-15 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (pas_backend_ldap_process_get_book_view): make sure to unref the book_view here so we don't leak them. svn path=/trunk/; revision=13680
* Properly decide whether a property needs to be marked as QP by searchingChristopher James Lahey2001-10-152-9/+106
| | | | | | | | | | 2001-10-15 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card.c (addPropValueQP, addPropValueSets, e_card_get_vobject): Properly decide whether a property needs to be marked as QP by searching for '\n'. Fixes Ximian bug #3021. svn path=/trunk/; revision=13675
* Set the default file name here. Fixes Ximian bug #7053.Christopher James Lahey2001-10-152-4/+61
| | | | | | | | | | 2001-10-15 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/e-contact-save-as.c (e_contact_save_as, e_contact_list_save_as): Set the default file name here. Fixes Ximian bug #7053. svn path=/trunk/; revision=13674
* Added linebreaks to our "this shouldn't happen" dialog message. (BugJon Trowbridge2001-10-152-5/+12
| | | | | | | | | | 2001-10-14 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_hookup_shell_listeners): Added linebreaks to our "this shouldn't happen" dialog message. (Bug #12498)CVS: ---------------------------------------------------------------------- svn path=/trunk/; revision=13668
* Add a component name to the e_passwords_init() call.Jon Trowbridge2001-10-132-1/+6
| | | | | | | | | 2001-10-12 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook-factory.c (main): Add a component name to the e_passwords_init() call. svn path=/trunk/; revision=13644
* commit the importer originally from Michael M. Morrison, with fixups byChris Toshok2001-10-137-4/+699
| | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-12 Chris Toshok <toshok@ximian.com> * backend/ebook/evolution-ldif-importer.c: commit the importer originally from Michael M. Morrison, with fixups by toshok. * backend/ebook/Makefile.am (bin_PROGRAMS): add evolution-ldif-importer. (oaf_in_files): add GNOME_Evolution_Addressbook_LDIF_Importer.oaf.in. * backend/ebook/e-card-simple.h: add WANTS_HTML and IS_LIST. * backend/ebook/e-card-simple.c (field_data): add WANTS_HTML and IS_LIST. (e_card_simple_set): fix typo. * backend/ebook/.cvsignore: ignore GNOME_Evolution_Addressbook_LDIF_Importer.oaf and evolution-ldif-importer. * backend/ebook/GNOME_Evolution_Addressbook_LDIF_Importer.oaf.in: ldif importer oafinfo. svn path=/trunk/; revision=13627
* Added a boolean type here.Christopher James Lahey2001-10-133-0/+35
| | | | | | | | | 2001-10-12 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h: Added a boolean type here. svn path=/trunk/; revision=13624
* Check to see if the uri we are setting is the same as the current uri. IfJon Trowbridge2001-10-122-0/+16
| | | | | | | | | | | 2001-10-12 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (addressbook_model_set_uri): Check to see if the uri we are setting is the same as the current uri. If so, do nothing. (Bug #11324) svn path=/trunk/; revision=13620
* On second thought, that should be a less-than-or-equal... :)Jon Trowbridge2001-10-121-1/+1
| | | | svn path=/trunk/; revision=13612
* Added. Heuristic for whether or not we want to revert to an earlierJon Trowbridge2001-10-122-6/+46
| | | | | | | | | | | | 2001-10-11 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_reverting_is_a_good_idea): Added. Heuristic for whether or not we want to revert to an earlier cardified state. (e_destination_cardify): Don't be quite as aggressive about reverting to previous cardified states. (Bug #11890) svn path=/trunk/; revision=13610
* Changed these to use the new ref and unref functions for ECard auxillaryChristopher James Lahey2001-10-1214-164/+258
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-11 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c (e_card_simple_destroy, fill_in_info, e_card_simple_sync_card, e_card_simple_set_phone, e_card_simple_set_address, e_card_simple_set_delivery_address, file_as_get_style, file_as_set_style, e_card_simple_set, e_card_simple_set_arbitrary), gui/contact-editor/e-contact-editor-address.c (e_contact_editor_address_destroy, e_contact_editor_address_set_arg, e_contact_editor_address_get_arg), gui/contact-editor/e-contact-editor-fullname.c (e_contact_editor_fullname_destroy, e_contact_editor_fullname_set_arg, e_contact_editor_fullname_get_arg), gui/contact-editor/e-contact-editor.c (phone_entry_changed, address_text_changed, name_entry_changed, full_name_clicked, full_addr_clicked, fill_in_info): Changed these to use the new ref and unref functions for ECard auxillary types. * backend/ebook/e-card-simple.h: Added a comment. * backend/ebook/e-card-types.h: Added ref_count field to all the types. * backend/ebook/e-card.c, backend/ebook/e-card.h: Added ref and unref functions here for all the ECard auxillary types. Removed the corresponding free functions. Switched to using these functions where appropriate. * gui/component/addressbook-factory.c: #include <e-util/e-passwords.h> * gui/component/addressbook.c (load_uri_cb): const correctify. * gui/component/select-names/e-select-names-manager.c, gui/component/select-names/e-select-names.c: #include <addressbook/gui/component/addressbook.h> * gui/widgets/e-addressbook-model.c (modify_card): Removed an unnecessary ref here. svn path=/trunk/; revision=13604
* Don't need this any more.Dan Winship2001-10-122-16/+5
| | | | | | | * gui/component/select-names/e-select-names.c (update_folder): Don't need this any more. svn path=/trunk/; revision=13590
* Check that view->view != NULL. (save_contact_cb): Check that view->view !=Jon Trowbridge2001-10-116-55/+206
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-11 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c (new_contact_cb): Check that view->view != NULL. (save_contact_cb): Check that view->view != NULL. (search_cb): Check that view->view != NULL. (delete_contact_cb): Check that view->view != NULL. (print_cb): Check that view->view != NULL. (print_preview_cb): Check that view->view != NULL. (stop_loading_cb): Check that view->view != NULL. (cut_contacts_cb): Check that view->view != NULL. (copy_contacts_cb): Check that view->view != NULL. (paste_contacts_cb): Check that view->view != NULL. (select_all_contacts_cb): Check that view->view != NULL. (send_contact_cb): Check that view->view != NULL. (send_contact_to_cb): Check that view->view != NULL. (update_command_state): Check that view->view != NULL. Hold a reference to the AddressbookView for the duration of the function, in case we exit during bonobo-reentrancy. (addressbook_view_ref): Added. (addressbook_view_unref): Added. Simple ref counting for AddressbookView objects. (addressbook_view_clear): Zero out an AddressbookView. This is now separated from the deallocation of the AddressbookView object, so that we don't leave a dangling pointer if we exit during bonobo-reentrancy in update_command_state. (Which often seems to happen if we exit while addressbook operations are going on.) (destroy_callback): Replace previous call to addressbook_view_free with addressbook_view_clear/addressbook_view_unref calls. (addressbook_factory_new_control): Initialize the reference count in the AddressbookView object. * gui/widgets/e-addressbook-view.c (e_addressbook_view_destroy): Carefully zero out our destroyed object. (command_state_change): Hold a reference to ourselves during the signal emission. (get_selected_cards): Ref cards as we add them to the list. (e_addressbook_view_stop): Check for view != NULL. (e_addressbook_view_can_create): Check for view != NULL. (e_addressbook_view_can_print): Check for view != NULL. (e_addressbook_view_can_save_as): Check for view != NULL. (e_addressbook_view_can_send): Check for view != NULL. (e_addressbook_view_can_send_to): Check for view != NULL. (e_addressbook_view_can_delete): Check for view != NULL. (e_addressbook_view_can_cut): Check for view != NULL. (e_addressbook_view_can_copy): Check for view != NULL. (e_addressbook_view_can_paste): Check for view != NULL. (e_addressbook_view_can_select_all): Check for view != NULL. (e_addressbook_view_can_stop): Check for view != NULL. * gui/widgets/e-addressbook-model.c (addressbook_destroy): Be careful about zeroing out our destroyed object. * backend/ebook/e-book-view.c (e_book_view_stop): Added. Stops event processing in the underlying listener. svn path=/trunk/; revision=13578
* If our select names dialog is still around, destroy it. Otherwise, theJon Trowbridge2001-10-112-2/+7
| | | | | | | | | | | 2001-10-10 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_destroy): If our select names dialog is still around, destroy it. Otherwise, the dialog will hang around after our composer goes away. svn path=/trunk/; revision=13565
* Added "Palestinian territory" to the country listYuri Syrota2001-10-091-0/+1
| | | | svn path=/trunk/; revision=13514
* add an Email Address field/label/help text.Chris Toshok2001-10-073-27/+110
| | | | | | | | | | | | | | | | | | | | | | 2001-10-06 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-config.glade: add an Email Address field/label/help text. * gui/component/addressbook-config.c (addressbook_source_dialog_set_source): fill in the email entry from the source. also, set the initial state of the email label/entry. (auth_checkbutton_changed): set the email label/entry sensitive/editable if auth is turned on, and insensitive/uneditable if it's off. (addressbook_source_dialog_get_source): get the email address from the email entry. (addressbook_source_dialog): hook up the email entry to the changed signal foo, as well as the focus handler for displaying help text. svn path=/trunk/; revision=13486
* db isn't a BonoboObject, so don't bonobo_object_unref it!Jon Trowbridge2001-10-062-1/+16
| | | | | | | | | | 2001-10-06 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_new): db isn't a BonoboObject, so don't bonobo_object_unref it! svn path=/trunk/; revision=13477
* e_book_load_uri -> addressbook_load_uri.Chris Toshok2001-10-067-121/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-10-05 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names.c (addressbook_model_set_uri): e_book_load_uri -> addressbook_load_uri. * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_new): e_book_load_uri -> addressbook_load_uri. * gui/component/addressbook.c (forget_passwords_cb): new function, call e_passwords_forget_passwords. (verbs): Add ContactsForgetPasswords. (load_uri_auth_cb): new function, call the callback and free up our closure stuff. (load_uri_cb): once the uri is loaded, check if we're configured to authenticate for it, and do so, using the e_passwords stuff. (addressbook_load_uri): wrapper around e_book_load_uri. save off the parameters and start the load-with-auth machinery. (book_open_cb): remove all the auth stuff from here, as it's handled elsewhere now. * gui/component/addressbook-factory.c (main): call e_passwords_init. * gui/component/addressbook-component.c (user_create_new_item_cb): e_book_load_uri -> addressbook_load_uri. (destination_folder_handle_drop): same. * gui/component/addressbook.h: add prototype for addressbook_load_uri (a wrapper around e_book_load_uri that also handles authentication if the user selects it.) svn path=/trunk/; revision=13475
* Check to make sure our call to e_addressbook_model_get_card doesn't returnJon Trowbridge2001-10-065-15/+44
| | | | | | | | | | | | | | | | | | | | | | | | 2001-10-05 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (real_add_address_cb): Check to make sure our call to e_addressbook_model_get_card doesn't return NULL. * gui/widgets/e-addressbook-model.c (e_addressbook_model_get_card): Chek that we aren't requesting a negative row. * gui/contact-list-editor/e-contact-list-editor.c (add_email_cb): Move to the bottom of the scrolled window, so we can see the address we just added. (table_drag_data_received_cb): Move to the bottom of the scrolled window, so we can see the contact we just dropped. * gui/component/addressbook.c (addressbook_factory_new_control): We don't own the string returned by e_categories_master_list_nth, so terrible things will happen if we free it. (Bug 10916) svn path=/trunk/; revision=13469
* don't set the editable field on the model - let the book do that.Chris Toshok2001-10-062-1/+9
| | | | | | | | | | | | 2001-10-05 Chris Toshok <toshok@ximian.com> * gui/widgets/e-addressbook-view.c (e_addressbook_view_set_arg): don't set the editable field on the model - let the book do that. (book_writable_cb): call writable_status to propagate a ui-change event up (and sensitize the write-only toolbar buttons after you authenticate with ldap.) svn path=/trunk/; revision=13454
* for some reason, matching on protocol is causing problems for me.Chris Toshok2001-10-052-2/+11
| | | | | | | | | | 2001-10-04 Chris Toshok <toshok@ximian.com> * backend/ebook/e-book.c (activate_factories_for_uri): for some reason, matching on protocol is causing problems for me. disabling it for now. svn path=/trunk/; revision=13415
* use ldap.png for ldap contacts.Chris Toshok2001-10-052-1/+6
| | | | | | | | | 2001-10-04 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-component.c: use ldap.png for ldap contacts. svn path=/trunk/; revision=13411
* Fixed warningIain Holmes2001-10-041-3/+12
| | | | svn path=/trunk/; revision=13390
* ifdef out the LDAP only bits. Cleans some warnings on startupIain Holmes2001-10-042-0/+10
| | | | svn path=/trunk/; revision=13389
* Fixed these to determine the fields to use properly.Christopher James Lahey2001-10-043-5/+8
| | | | | | | | | | 2001-10-03 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (addressbook_height), gui/widgets/e-minicard.c (remodel): Fixed these to determine the fields to use properly. svn path=/trunk/; revision=13386
* Strip out commas before forming our query. (match_name): UseJon Trowbridge2001-10-045-140/+187
| | | | | | | | | | | | | | | | | | | | | | 2001-10-02 Jon Trowbridge <trow@gnu.org> * gui/component/select-names/e-select-names-completion.c (name_style_query): Strip out commas before forming our query. (match_name): Use e_card_compare_name_to_string_full, rather than our crufty old matching code. Not only is this cleaner, but that crufty old code was very broken when it came to handling strings with whitespace. (Bug 8988) (match_nickname): utf8 and bug fixes. * backend/ebook/e-card-compare.c (e_card_compare_name_to_string_full): Added. This is basically e_card_compare_name_to_string with a bunch of extra options, so that it can more readily be reused in other contexts. (e_card_compare_name_to_string): This is now just a call to e_card_compare_name_to_string_full with the extra args filled in to defaults that simulate the old behavior. svn path=/trunk/; revision=13384
* remove most of the oaf stuff from here. we do it in load_uri, where we'llChris Toshok2001-10-032-35/+179
| | | | | | | | | | | | | | | | | | | | | 2001-10-02 Chris Toshok <toshok@ximian.com> * backend/ebook/e-book.c (e_book_construct): remove most of the oaf stuff from here. we do it in load_uri, where we'll have more information (namely, the protocol we're using.) (activate_factories_for_uri): do an oaf query to get a list of all objects implementing our BookFactory interface and also supporting the protocol used in the uri. (e_book_load_uri): try activating book factories to handle this uri, and start the iteration over the list. (e_book_load_uri_from_factory): try and load the uri. (e_book_load_uri_open_cb): callback function for the BookFactory_openBook call - if it succeeds, call the user's callback. otherwise step to the next factory. (e_book_load_uri_step): go to the next factory in our list, and error out if there are no more. svn path=/trunk/; revision=13358
* Made the max length of the textification be 2047 characters. Fixes XimianChristopher James Lahey2001-10-022-0/+13
| | | | | | | | | | 2001-10-02 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names-model.c (e_select_names_model_get_textification): Made the max length of the textification be 2047 characters. Fixes Ximian bug #3021. svn path=/trunk/; revision=13299
* if there was no first name or last name, file as the company.JP Rosevear2001-10-022-0/+7
| | | | | | | | | 2001-10-01 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): if there was no first name or last name, file as the company. svn path=/trunk/; revision=13293
* if there is a db error, assume deletion (pas_backend_file_changes): writeJP Rosevear2001-10-022-7/+9
| | | | | | | | | | | 001-10-01 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_changes_foreach_key): if there is a db error, assume deletion (pas_backend_file_changes): write after all is done for efficiency svn path=/trunk/; revision=13267
* g_strdup (pas_backend_file_changes): ditto, make sure to free all data andJP Rosevear2001-09-293-32/+73
| | | | | | | | | | | | | | | | 2001-09-28 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_changes_foreach_key): g_strdup (pas_backend_file_changes): ditto, make sure to free all data and do a hash write after each add/remove * conduit/address-conduit.c (local_record_to_pilot_record): use the local record category (local_record_from_ecard): ndle the fields and category we don't sync by making sure we don't overwrite them svn path=/trunk/; revision=13232
* Update the paths, /menu/ComponentToolsPlaceholder/Tools/ ->Ettore Perazzoli2001-09-282-2/+8
| | | | | | | | * gui/component/addressbook.c: Update the paths, /menu/ComponentToolsPlaceholder/Tools/ -> /menu/Tools/ComponentPlaceholder/. svn path=/trunk/; revision=13203
* use the old record (if there was one) so as not to overwrite fields weJP Rosevear2001-09-273-5/+24
| | | | | | | | | | | | 2001-09-27 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (local_record_from_ecard): use the old record (if there was one) so as not to overwrite fields we don't sync (pre_sync): store the dbi in the context and don't make it object data svn path=/trunk/; revision=13187
* use priv->iid instead of the hardcoded string here.Chris Toshok2001-09-273-9/+33
| | | | | | | | | | | | | | 2001-09-26 Chris Toshok <toshok@ximian.com> * backend/pas/pas-book-factory.c (pas_book_factory_destroy): use priv->iid instead of the hardcoded string here. (pas_book_factory_activate): parameterize the factory's iid, as in the calendar server, and provide a default if iid == NULL. * backend/pas/pas-book-factory.h: add iid parameter for pas_book_factory_activate. svn path=/trunk/; revision=13180
* Use camel_address_format, not camel_address_encode.Jon Trowbridge2001-09-272-1/+6
| | | | | | | | | 2001-09-26 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_get_textrep): Use camel_address_format, not camel_address_encode. svn path=/trunk/; revision=13173
* Added help text (thanks to Aaron) and re-worded the labels, and fixed theAnna Marie Dirks2001-09-272-119/+181
| | | | | | | | | | 2001-09-26 Anna Marie Dirks <anna@ximian.com> * gui/contact-editor/contact-editor.glade: Added help text (thanks to Aaron) and re-worded the labels, and fixed the shortcuts on the brand-spanking-new Collaboration tab. svn path=/trunk/; revision=13170
* add completion_book.Chris Toshok2001-09-273-3/+59
| | | | | | | | | | | | | | | | | | 2001-09-26 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names-manager.h: add completion_book. * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_new): get /Addressbook/Completion/uri, and if it's present, use the corresponding EBook for completing addresses. (focus_out_cb): use manager->completion_book here instead of NULL, which corresponds to the local addressbook. (completion_popup_cb): same. (e_select_names_manager_create_entry): same. svn path=/trunk/; revision=13161
* Properly handle names when the individual elements (given, addition,Jon Trowbridge2001-09-274-42/+108
| | | | | | | | | | | | | | | | | | | | | | 2001-09-26 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card-compare.c (e_card_compare_name_to_string): Properly handle names when the individual elements (given, addition, family) contain whitespace. (Bug #10502) * backend/ebook/e-destination.c (e_destination_set_name): Reset textrep when we change the name. (e_destination_set_email): Reset textrep when we change the email. (e_destination_get_textrep): Make sure that the textrep version of the address is properly quoted if it contains unsafe characters. (All related to bug #10796) * gui/component/select-names/e-select-names-completion.c (match_nickname): Fix nickname matching. (bug #9698) (make_match): Use e_completion_match_new when building our match, rather than ad hoc manipulation of the struct. svn path=/trunk/; revision=13158
* set the last_use and use_score fields of the card to known values so theJP Rosevear2001-09-273-10/+65
| | | | | | | | | | | | | | | | 2001-09-26 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_changes): set the last_use and use_score fields of the card to known values so the card doesn't register as changed when only they have changed 2001-09-26 Peter Williams <peterw@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): Fix this function to set email addresses properly, and handle multiple occurrences of email addresses, home phone numbers, and business phone numbers. svn path=/trunk/; revision=13153
* Handle creating the new contact in the current folder if it's a contactsChristopher James Lahey2001-09-252-5/+36
| | | | | | | | | | 2001-09-25 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook-component.c (user_create_new_item_cb): Handle creating the new contact in the current folder if it's a contacts folder. Fixes Ximian bug #7814. svn path=/trunk/; revision=13109
* add evolutionperson.schema (EXTRA_DIST): add LDAP_SCHEMA to the dist (butChris Toshok2001-09-252-1/+15
| | | | | | | | | | 2001-09-24 Chris Toshok <toshok@ximian.com> * backend/pas/Makefile.am (LDAP_SCHEMA): add evolutionperson.schema (EXTRA_DIST): add LDAP_SCHEMA to the dist (but don't install it). svn path=/trunk/; revision=13107
* sync the note the to pilot and make sure to blank fields when appropriateJP Rosevear2001-09-242-25/+31
| | | | | | | | | | 2001-09-23 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (ecard_from_remote_record): sync the note the to pilot and make sure to blank fields when appropriate (local_record_from_ecard): sync the note to the desktop svn path=/trunk/; revision=13091
* when creating the cards, don't display any of the subname fields (surname,Chris Toshok2001-09-232-1/+7
| | | | | | | | | | 2001-09-22 Chris Toshok <toshok@ximian.com> * gui/widgets/e-minicard.c (remodel): when creating the cards, don't display any of the subname fields (surname, given, middle, suffix, etc.) svn path=/trunk/; revision=13083
* add getters for the additional name fields. (field_data): move FAMILY_NAMEChris Toshok2001-09-233-2/+41
| | | | | | | | | | | | | 2001-09-22 Chris Toshok <toshok@ximian.com> * backend/ebook/e-card-simple.c (e_card_simple_get): add getters for the additional name fields. (field_data): move FAMILY_NAME to the end of the list, and add GIVEN_NAME, ADDITIONAL_NAME (middle name), and NAME_SUFFIX. * backend/ebook/e-card-simple.h: same. svn path=/trunk/; revision=13082
* Hooked up print preview button.Christopher James Lahey2001-09-226-4/+121
| | | | | | | | | | | | | | | | 2001-09-21 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c (print_preview_cb): Hooked up print preview button. * gui/widgets/e-addressbook-view.c, gui/widgets/e-addressbook-view.h (e_addressbook_view_print_preview): Added this function. * printing/e-contact-print.c, printing/e-contact-print.h (e_contact_print_preview): Added this function. svn path=/trunk/; revision=13071
* I'm slowly losing my mind.Jon Trowbridge2001-09-201-1/+0
| | | | | | OK, maybe it isn't such a slow process after all. svn path=/trunk/; revision=13006
* Yikes... fixing accidental breakage.Jon Trowbridge2001-09-201-1/+1
| | | | svn path=/trunk/; revision=13005
* Use the default e-mail address if we have nothing else to go on.Jon Trowbridge2001-09-207-167/+136
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-19 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (name_and_email_simple_query_cb): Use the default e-mail address if we have nothing else to go on. Previously we just failed, which basically meant that name-only searches would never work properly. (nickname_simple_query_cb): The logic was a bit tangled here; if our query status isn't SUCCESS, always give up but don't leak the destination. And if our nickname query fails and we try the name-and-email query, use the textrep for a name-only search. The only reason we are doing a nickname query in the first place is if we have an obviously invalid e-mail. (launch_cardify_query): Use e_destination_is_valid to determine if we should try a nickname query first. These changes basically fix bug 7728, and generally make the auto-cardification of addresses a lot more clever and robust. * backend/ebook/e-book-util.c (name_and_email_cb): Use e_card_compare_name_to_string instead of e_card_name_match_string. (e_book_name_and_email_query): The arguments to g_strsplit were in the wrong order. Doh! * backend/ebook/e-card-compare.c (e_card_compare_name_to_string): Added. Replaces e_card_name_match_string, and actually works. * backend/ebook/e-card.c: Removed e_card_name_match_string function, which didn't work particularly well. svn path=/trunk/; revision=13003
* don't add to the complete list of cards if the card is a listJP Rosevear2001-09-202-5/+33
| | | | | | | | | | | | | 2001-09-19 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c (cursor_cb): don't add to the complete list of cards if the card is a list (card_added): don't add to the list of changes if the card is a list (card_changed): ditto (card_removed): ditto svn path=/trunk/; revision=13002
* Change the "this should never happen" message into a request for people toJon Trowbridge2001-09-202-1/+10
| | | | | | | | | | | 2001-09-19 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_hookup_shell_listeners): Change the "this should never happen" message into a request for people to e-mail me directly with info if they encounter that error. svn path=/trunk/; revision=13000
* Freeing name[i] instead of namev[i] is a bad idea. (bug #10270)Jon Trowbridge2001-09-202-1/+4
| | | | | | | | | 2001-09-19 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-util.c (e_book_name_and_email_query): Freeing name[i] instead of namev[i] is a bad idea. (bug #10270) svn path=/trunk/; revision=12980
* Properly handle our GnomeUIInfo labels so that they won't be leaked ifJon Trowbridge2001-09-192-151/+137
| | | | | | | | | | | | | | | | 2001-09-19 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-popup.c (popup_menu_card): Properly handle our GnomeUIInfo labels so that they won't be leaked if they are dynamic strings, so that they will be i18n-correct, and so that underscores won't be interpreted as key accelerators. What a PITA. Also, don't leak our iterators. (Bug #10200.) (popup_menu_list): The same GnomeUIInfo tweaking as in popup_menu_card. (popup_menu_nocard): Ditto. svn path=/trunk/; revision=12975
* add caluri field dataJP Rosevear2001-09-197-13/+232
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-18 JP Rosevear <jpr@ximian.com> * backend/ebook/e-card-simple.c (field_data): add caluri field data * backend/ebook/e-card.c (e_card_get_vobject): add the caluri property when appropriate (parse_caluri): handle read caluri (e_card_class_init): add caluri arg (e_card_destroy): free the caluri (e_card_get_arg): return caluri arg (e_card_set_arg): set caluri from arg (e_card_init): init caluri to null * backend/ebook/e-card-simple.h: new simple field * backend/ebook/e-card.h: new member * gui/contact-editor/e-contact-editor.c (field_changed): util callback to change the command state (set_entry_changed_signal_field): hook up a change signal to above (set_entry_changed_signals): use above function * gui/contact-editor/e-contact-editor.glade: Add collaboration page and fields svn path=/trunk/; revision=12945
* create a sexp and check if the cards match before adding them to the listJP Rosevear2001-09-192-7/+28
| | | | | | | | | | | 2001-09-18 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_build_cards_list): create a sexp and check if the cards match before adding them to the list (pas_backend_file_process_get_cursor): send extra param svn path=/trunk/; revision=12940
* remove conflict droppingsLarry Ewing2001-09-181-1/+0
| | | | | | --Larry svn path=/trunk/; revision=12938
* unref the destination regardless of whether we get an email addresss.Larry Ewing2001-09-182-2/+8
| | | | | | | | | | 2001-09-18 Larry Ewing <lewing@ximian.com> * gui/component/select-names/e-select-names-completion.c (book_query_process_card_list): unref the destination regardless of whether we get an email addresss. svn path=/trunk/; revision=12937
* use g_strfreev. (match_name): s/g_free/g_strfreev. (match_file_as):Larry Ewing2001-09-184-12/+22
| | | | | | | | | | | | | | | | | | | 2001-09-17 Larry Ewing <lewing@ximian.com> * gui/component/select-names/e-select-names-completion.c (name_style_query): use g_strfreev. (match_name): s/g_free/g_strfreev. (match_file_as): s/g_free/g_strfreev. * backend/ebook/e-book-util.c (e_book_name_and_email_query): fix the memory handling here. All there members of the vector need to be freed all the time. * backend/ebook/load-pine-addressbook.c (parse_line): free the string outside of the test that makes sure there are three entries. svn path=/trunk/; revision=12936
* don't malloc a match we will never use.Larry Ewing2001-09-182-1/+4
| | | | | | | | | 2001-09-17 Larry Ewing <lewing@ximian.com> * gui/component/select-names/e-select-names-completion.c (match_nickname): don't malloc a match we will never use. svn path=/trunk/; revision=12935
* free the dup'd capabilities.Larry Ewing2001-09-182-0/+7
| | | | | | | | | 2001-09-17 Larry Ewing <lewing@ximian.com> * gui/widgets/e-addressbook-model.c (get_view): free the dup'd capabilities. svn path=/trunk/; revision=12933
* We want to assume that a destination that comes from a card isJon Trowbridge2001-09-182-1/+7
| | | | | | | | | | | | 2001-09-17 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_is_valid): We want to assume that a destination that comes from a card is automatically valid, but the right way to check that is by calling e_destination_from_card, not by checking if dest->priv->card != NULL. (Fixed bug #10017) svn path=/trunk/; revision=12930
* Fixed a stupid bug was causing completion to fail for contacts who haveJon Trowbridge2001-09-182-9/+14
| | | | | | | | | | | 2001-09-17 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (match_name): Fixed a stupid bug was causing completion to fail for contacts who have only one name. (The classic example we all know and love is 'George <jirka@5z.com>') (bug #8353) svn path=/trunk/; revision=12928
* Do the right thing if the card we are trying to send to has no validJon Trowbridge2001-09-182-53/+60
| | | | | | | | | | 2001-09-17 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card.c (e_card_list_send): Do the right thing if the card we are trying to send to has no valid e-mail addresses. (bug #10137) svn path=/trunk/; revision=12927
* Code implicitly assumed that event->button.button is 1, 2, or 3, causingJon Trowbridge2001-09-182-17/+26
| | | | | | | | | | 2001-09-17 Jon Trowbridge <trow@ximian.com> * gui/widgets/e-minicard.c (e_minicard_event): Code implicitly assumed that event->button.button is 1, 2, or 3, causing disaster when using a wheel-mouse. Fixed. (bug #9400) svn path=/trunk/; revision=12926
* use enable_widget instead of gtk_widget_set_sensitive.Chris Toshok2001-09-174-53/+109
| | | | | | | | | | | | | | | | | | | | | | | | 2001-09-16 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-editor.c (_phone_arrow_pressed): use enable_widget instead of gtk_widget_set_sensitive. (_email_arrow_pressed): same. (_address_arrow_pressed): same. (disable_widget_foreach): same. (enable_writable_fields): same. (set_editable): same. (enable_widget): new function, using both gtk_widget_set_sensitive and *_set_editable to allow the user to select text in GtkEntry's and GtkText's. * gui/contact-editor/e-contact-editor-fullname.c (e_contact_editor_fullname_set_arg): use set_editable as well as set_sensitive, to allow the user to select text in GtkEntry's. * gui/contact-editor/e-contact-editor-address.c (e_contact_editor_address_set_arg): same. svn path=/trunk/; revision=12868
* fix syntax errors (which are broken, imo...)Chris Toshok2001-09-172-2/+7
| | | | | | | | | 2001-09-16 Chris Toshok <toshok@ximian.com> * backend/pas/evolutionperson.schema: fix syntax errors (which are broken, imo...) svn path=/trunk/; revision=12866
* reorder the LDAP scopes so that they match the order of the option menusChris Toshok2001-09-173-4/+82
| | | | | | | | | | | | | | | | | | | | | | | | 2001-09-16 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-storage.h: reorder the LDAP scopes so that they match the order of the option menus in the glade file. * gui/component/addressbook-config.c (auth_checkbutton_changed): new function, mostly there to house some #ifdef'ed out code. (option_menuitem_activated): new function, to keep track of changes to the ldap scope optionmenu. (addressbook_source_dialog_set_source): set the menu history as well as the dialog's copy of the scope. (addressbook_source_dialog_get_source): fill in the source's scope from the dialog's copy, and add more #if the_ui_gods_smile_on_me code. (add_activate_cb): new function, add an activate callback for the optionmenu's items. (addressbook_source_dialog): more #if the_ui_gods_smile_on_me code, always start the dialog on page 0, and hook up the scope optionmenu's items. svn path=/trunk/; revision=12865
* No loose name matches on family names. (#8802)Jon Trowbridge2001-09-153-1/+10
| | | | | | | | | 2001-09-15 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card-compare.c (e_card_compare_name): No loose name matches on family names. (#8802) svn path=/trunk/; revision=12857
* We can't use NULL as the first arg for e_addressbook_show_contact_editorJon Trowbridge2001-09-152-2/+7
| | | | | | | | | | | 2001-09-15 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_activate_obj): We can't use NULL as the first arg for e_addressbook_show_contact_editor anymore. Damn. (#8535) svn path=/trunk/; revision=12853
* Make "stop" do nothing but set the stopped flag, as inJon Trowbridge2001-09-1510-209/+255
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-15 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-listener.c (e_book_listener_stop): Make "stop" do nothing but set the stopped flag, as in e-book-view-listener.c. (e_book_listener_destroy): Clean up our queue here, rather than in e_book_listener_stop. (response_free): Added. Move the rather lengthy bit of code needed to free a EBookListenerResponse into one place. (e_book_listener_check_queue): Properly deal with the stopped flag. (e_book_listener_queue_response): If the stopped flag is set, just drop the incoming response. * backend/ebook/e-book-view-listener.c (e_book_view_listener_stop): Make "stop" do nothing but set the stopped flag. (e_book_view_listener_destroy): Move all of the clean-up that used to be in e_book_view_listener_stop here. This considerably simplifies the logic required to avoid various race conditions. (e_book_view_listener_check_queue): Properly deal with the stopped flag. (e_book_view_listener_queue_response): Drop all incoming responses if we are stopped. 2001-09-14 Jon Trowbridge <trow@ximian.com> * backend/pas/pas-book.c (pas_book_queue_request): Hold a reference to the book on behalf of our idle function. (pas_book_check_queue): When we are finished, drop the reference we've been holding on behalf of the idle function. * backend/pas/pas-backend-file.c (pas_backend_file_process_create_card): Hold a reference to the book_view while sending our notifications. (pas_backend_file_process_remove_card): Hold a reference to the book_view while sending our notifications. * gui/contact-editor/e-contact-quick-add.c (quick_add_unref): Remove debugging spew. * backend/ebook/e-book-util.c: Remove a lot of unused code that worked around bugs that have long since been fixed. (simple_query_disconnect): Added. Breaks out the part of simple_query_free that disconnect signals. (simple_query_free): Replace code w/ a call to simple_query_disconnect. (simple_query_sequence_complete_cb): Call simple_query_disconnect before executing the callback, so that our callbacks don't get triggered by any book changes that might occur during that callback. * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): Changed to be consistent with e_book_listener_check_queue. (e_book_view_listener_queue_response): Also changed to use a high-frequency timeout. * backend/ebook/e-book-listener.c (e_book_listener_check_queue): OK, I've agonized over this stupid little function, and it should now be race-free. (e_book_listener_queue_response): We process our response queue in a high-frequency timeout rather than an idle. Using an idle function leads to some tricky race conditions and bad interactions with bonobo's semi-broken attempts to take over event processing. (e_book_view_listener_stop): Manually disable our timeout and clean up. svn path=/trunk/; revision=12851
* Set CLEANFILES directly instead of using `+='.Ettore Perazzoli2001-09-152-1/+4
| | | | | | | | | | | | | * gui/component/select-names/Makefile.am: Set CLEANFILES directly instead of using `+='. * backend/pas/Makefile.am: Rename `LDAP_BACKEND_SOURCES' to `LDAP_BACKEND_FILES'. * backend/ebook/Makefile.am: Set CLEANFILES directly instead of using `+='. svn path=/trunk/; revision=12840
* [Automake 1.5 fixes pointed out by Richard BoultonEttore Perazzoli2001-09-153-5/+16
| | | | | | | | | | | | <richard@tartarus.org>, as per #9258.] * backend/pas/Makefile.am: Rename `LDAP_BACKEND_SOURCES' to `LDAP_BACKEND_FILES'. * backend/ebook/Makefile.am: Set CLEANFILES directly instead of using `+='. svn path=/trunk/; revision=12839
* use ldap_init. ldap_open is deprecated in openldap 2.x.Chris Toshok2001-09-142-1/+6
| | | | | | | | | 2001-09-13 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (pas_backend_ldap_connect): use ldap_init. ldap_open is deprecated in openldap 2.x. svn path=/trunk/; revision=12820
* Fix vcard importingIain Holmes2001-09-132-1/+8
| | | | svn path=/trunk/; revision=12784
* free the values that are being leaked here.Larry Ewing2001-09-132-4/+20
| | | | | | | | | 2001-09-12 Larry Ewing <lewing@ximian.com> * backend/ebook/e-destination.c: free the values that are being leaked here. svn path=/trunk/; revision=12783
* printf arguments were reversed by mistake. Fixed bug #9693.Jon Trowbridge2001-09-132-1/+6
| | | | | | | | | 2001-09-12 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (match_email): printf arguments were reversed by mistake. Fixed bug #9693. svn path=/trunk/; revision=12779
* Added. Treat right-clicks on a contact list as a special case.Jon Trowbridge2001-09-102-4/+111
| | | | | | | | | | | | 2001-09-09 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-popup.c (popup_menu_list): Added. Treat right-clicks on a contact list as a special case. (e_select_names_popup): Check if we are dealing with a contact list. (Bug #9322) svn path=/trunk/; revision=12716
* (Apologies if you are seeing this multiple times. CVS is being annoying.)Jon Trowbridge2001-09-098-81/+153
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-08 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): See e_book_listener_check_queue below. (e_book_view_listener_queue_response): See e_book_listener_queue_response below. * backend/ebook/e-book-listener.c (e_book_listener_check_queue): Explicitly prohibit reentrancy. Use gtk-unref rather than bobobo-unref. (e_book_listener_queue_response): Hold a gtk-ref to the listener while the idle function runs, not a bonobo-ref. As far as I can tell, it is impossible to avoid a race condition here when we have to worry about bonobo reentrancy. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_insert_length): Alter a copy of the original EDestination, rather than just using a new one. We need to do this to preserve prior-card information for possible reversion later. (e_select_names_text_model_delete): Ditto. * backend/ebook/e-destination.c (e_destination_clear_card): When clearing a destination where ->card != NULL, store it for possible reversion later. (e_destination_revert): If we have an old card stored, go back to using it for the destination. (e_destination_is_valid): Tries to detect obviously broken addresses. (e_destination_cardify): If our destination is invalid, first try to cardify simply by reverting to an older card. (e_destination_destroy): Unref any cached old card. (e_destination_copy): Copy the old card information. 2001-09-07 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (sync_table_and_models): Show all rows in the table, and then remove the rows that correspond to entries in the ESelectNamesModels in the children. (real_add_address): Freeze/thaw our ESelectNamesModel, so that we don't change our table while we are in the middle of iterating over the selection. (remove_address): Just delete the address from the ESelectNamesModel, the signal handler will do the rest. (selected_rows_foreach_cb): Call remove_address to do our dirty work. (e_select_names_add_section): Connect to the 'changed' signal from the ESelectNamesModel, and call sync_table_and_models explicitly to get our initial state correct. * gui/component/select-names/e-select-names-table-model.c (fill_in_info): Deal with EDestinations in our table that don't come from cards. * gui/component/select-names/e-select-names-manager.c: Added another ESelectNamesModel* to the ESelectNamesManagerSection struct. Called 'original_model', this contains a copy of the model as it is when we begin using the SelectNames dialog. (section_copy): Copy the original model. (section_free): Free the original model. (e_select_names_manager_add_section_with_limit): Initialize the original model. (e_select_names_clicked): I've changed the semantics of this dialog quite a bit... no UI freeze can stop me! If OK is clicked, we do nothing. If Cancel is clicked, we revert to the 'original_model' copy of our address entry state before we started editting. Finally, we close the dialog before any of thing. Doing it last caused problems, because signals were being triggered which had dangling pointers as their closures. (e_select_names_manager_activate_dialog): Copy our current state to the original model, and share the same ESelectNamesModel between the dialog and the address entry in the composer.. (e_select_names_manager_get_cards): Removed. It had been #if 0/#endif-ed out for a while. * gui/component/select-names/e-select-names-model.c (e_select_names_model_freeze): Added. (e_select_names_model_thaw): Added. (e_select_names_model_uncardify): Added. If possible, "uncardifies" a specific model entry. (e_select_names_model_changed): Changed to pay attention to the freeze count. * gui/component/select-names/e-select-names-completion.c (clean_query_text): Strip leading/trailing whitespace from queries. * backend/ebook/e-destination.c (e_destination_uncardify): Added. Converts a card-associated destination into a text-associated destination w/ the e-mail address. (e_destination_list_to_vector): Added. A convenience routine. (e_destination_freev): Added. A convenience routine. (e_destination_touchv): Added. I'm lazy. svn path=/trunk/; revision=12710
* See e_book_listener_check_queue below.Jon Trowbridge2001-09-095-92/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-08 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): See e_book_listener_check_queue below. (e_book_view_listener_queue_response): See e_book_listener_queue_response below. * backend/ebook/e-book-listener.c (e_book_listener_check_queue): Explicitly prohibit reentrancy. Use gtk-unref rather than bobobo-unref. (e_book_listener_queue_response): Hold a gtk-ref to the listener while the idle function runs, not a bonobo-ref. As far as I can tell, it is impossible to avoid a race condition here when we have to worry about bonobo reentrancy. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_insert_length): Alter a copy of the original EDestination, rather than just using a new one. We need to do this to preserve prior-card information for possible reversion later. (e_select_names_text_model_delete): Ditto. * backend/ebook/e-destination.c (e_destination_clear_card): When clearing a destination where ->card != NULL, store it for possible reversion later. (e_destination_revert): If we have an old card stored, go back to using it for the destination. (e_destination_is_valid): Tries to detect obviously broken addresses. (e_destination_cardify): If our destination is invalid, first try to cardify simply by reverting to an older card. (e_destination_destroy): Unref any cached old card. (e_destination_copy): Copy the old card information. 2001-09-07 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (sync_table_and_models): Show all rows in the table, and then remove the rows that correspond to entries in the ESelectNamesModels in the children. (real_add_address): Freeze/thaw our ESelectNamesModel, so that we don't change our table while we are in the middle of iterating over the selection. (remove_address): Just delete the address from the ESelectNamesModel, the signal handler will do the rest. (selected_rows_foreach_cb): Call remove_address to do our dirty work. (e_select_names_add_section): Connect to the 'changed' signal from the ESelectNamesModel, and call sync_table_and_models explicitly to get our initial state correct. * gui/component/select-names/e-select-names-table-model.c (fill_in_info): Deal with EDestinations in our table that don't come from cards. * gui/component/select-names/e-select-names-manager.c: Added another ESelectNamesModel* to the ESelectNamesManagerSection struct. Called 'original_model', this contains a copy of the model as it is when we begin using the SelectNames dialog. (section_copy): Copy the original model. (section_free): Free the original model. (e_select_names_manager_add_section_with_limit): Initialize the original model. (e_select_names_clicked): I've changed the semantics of this dialog quite a bit... no UI freeze can stop me! If OK is clicked, we do nothing. If Cancel is clicked, we revert to the 'original_model' copy of our address entry state before we started editting. Finally, we close the dialog before any of thing. Doing it last caused problems, because signals were being triggered which had dangling pointers as their closures. (e_select_names_manager_activate_dialog): Copy our current state to the original model, and share the same ESelectNamesModel between the dialog and the address entry in the composer.. (e_select_names_manager_get_cards): Removed. It had been #if 0/#endif-ed out for a while. * gui/component/select-names/e-select-names-model.c (e_select_names_model_freeze): Added. (e_select_names_model_thaw): Added. (e_select_names_model_uncardify): Added. If possible, "uncardifies" a specific model entry. (e_select_names_model_changed): Changed to pay attention to the freeze count. * gui/component/select-names/e-select-names-completion.c (clean_query_text): Strip leading/trailing whitespace from queries. * backend/ebook/e-destination.c (e_destination_uncardify): Added. Converts a card-associated destination into a text-associated destination w/ the e-mail address. (e_destination_list_to_vector): Added. A convenience routine. (e_destination_freev): Added. A convenience routine. (e_destination_touchv): Added. I'm lazy. svn path=/trunk/; revision=12709
* See e_book_listener_check_queue below.Jon Trowbridge2001-09-091-0/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-08 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): See e_book_listener_check_queue below. (e_book_view_listener_queue_response): See e_book_listener_queue_response below. * backend/ebook/e-book-listener.c (e_book_listener_check_queue): Explicitly prohibit reentrancy. Use gtk-unref rather than bobobo-unref. (e_book_listener_queue_response): Hold a gtk-ref to the listener while the idle function runs, not a bonobo-ref. As far as I can tell, it is impossible to avoid a race condition here when we have to worry about bonobo reentrancy. * gui/component/select-names/e-select-names-text-model.c (e_select_names_text_model_insert_length): Alter a copy of the original EDestination, rather than just using a new one. We need to do this to preserve prior-card information for possible reversion later. (e_select_names_text_model_delete): Ditto. * backend/ebook/e-destination.c (e_destination_clear_card): When clearing a destination where ->card != NULL, store it for possible reversion later. (e_destination_revert): If we have an old card stored, go back to using it for the destination. (e_destination_is_valid): Tries to detect obviously broken addresses. (e_destination_cardify): If our destination is invalid, first try to cardify simply by reverting to an older card. (e_destination_destroy): Unref any cached old card. (e_destination_copy): Copy the old card information. 2001-09-07 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (sync_table_and_models): Show all rows in the table, and then remove the rows that correspond to entries in the ESelectNamesModels in the children. (real_add_address): Freeze/thaw our ESelectNamesModel, so that we don't change our table while we are in the middle of iterating over the selection. (remove_address): Just delete the address from the ESelectNamesModel, the signal handler will do the rest. (selected_rows_foreach_cb): Call remove_address to do our dirty work. (e_select_names_add_section): Connect to the 'changed' signal from the ESelectNamesModel, and call sync_table_and_models explicitly to get our initial state correct. * gui/component/select-names/e-select-names-table-model.c (fill_in_info): Deal with EDestinations in our table that don't come from cards. * gui/component/select-names/e-select-names-manager.c: Added another ESelectNamesModel* to the ESelectNamesManagerSection struct. Called 'original_model', this contains a copy of the model as it is when we begin using the SelectNames dialog. (section_copy): Copy the original model. (section_free): Free the original model. (e_select_names_manager_add_section_with_limit): Initialize the original model. (e_select_names_clicked): I've changed the semantics of this dialog quite a bit... no UI freeze can stop me! If OK is clicked, we do nothing. If Cancel is clicked, we revert to the 'original_model' copy of our address entry state before we started editting. Finally, we close the dialog before any of thing. Doing it last caused problems, because signals were being triggered which had dangling pointers as their closures. (e_select_names_manager_activate_dialog): Copy our current state to the original model, and share the same ESelectNamesModel between the dialog and the address entry in the composer.. (e_select_names_manager_get_cards): Removed. It had been #if 0/#endif-ed out for a while. * gui/component/select-names/e-select-names-model.c (e_select_names_model_freeze): Added. (e_select_names_model_thaw): Added. (e_select_names_model_uncardify): Added. If possible, "uncardifies" a specific model entry. (e_select_names_model_changed): Changed to pay attention to the freeze count. * gui/component/select-names/e-select-names-completion.c (clean_query_text): Strip leading/trailing whitespace from queries. * backend/ebook/e-destination.c (e_destination_uncardify): Added. Converts a card-associated destination into a text-associated destination w/ the e-mail address. (e_destination_list_to_vector): Added. A convenience routine. (e_destination_freev): Added. A convenience routine. (e_destination_touchv): Added. I'm lazy. svn path=/trunk/; revision=12708
* (make_contact_editor_cb): show the right contact editor (the list editorChris Toshok2001-09-092-3/+15
| | | | | | | | | 2001-09-08 Chris Toshok <toshok@ximian.com> (make_contact_editor_cb): show the right contact editor (the list editor for list cards). svn path=/trunk/; revision=12707
* do the EDestination xml magic on email addresses we put in the popup.Chris Toshok2001-09-092-1/+18
| | | | | | | | | | 2001-09-08 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names-popup.c (popup_menu_card): do the EDestination xml magic on email addresses we put in the popup. svn path=/trunk/; revision=12706
* For every category: - set .translate to FALSEChyla Zbigniew2001-09-082-2/+14
| | | | | | | | | | * gui/component/addressbook.c (addressbook_factory_new_control): For every category: - set .translate to FALSE (e_categories_master_list_nth returns translated category name) - convert category name in UTF-8 to locale's encoding svn path=/trunk/; revision=12696
* Fixed two bugs: - missing coversion of contact name to GTK+ locale, -Chyla Zbigniew2001-09-082-15/+49
| | | | | | | | | | | | * gui/component/select-names/e-select-names-popup.c (popup_menu_card): Fixed two bugs: - missing coversion of contact name to GTK+ locale, - passing dynamically created string (contact name) inside uiinfo struct to gnome-app-helper functions. Remember: these functions may change strings, trying to translate them! (popup_menu_nocard): Ditto svn path=/trunk/; revision=12694
* Removed unused factory variable.Christopher James Lahey2001-09-082-2/+5
| | | | | | | | | 2001-09-07 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook-component.c: Removed unused factory variable. svn path=/trunk/; revision=12687
* new function, notify the bonobo listener. (remove_ldap_folder): trackChris Toshok2001-09-073-18/+64
| | | | | | | | | | | | | | | | | | | | | | | | 2001-09-06 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-storage.c (notify_listener): new function, notify the bonobo listener. (remove_ldap_folder): track change to EvolutionStorage signal. (create_ldap_folder): same, and make sure the type is "ldap-contacts". (load_source_data): folders that we create should have "ldap-contacts" as their type. (addressbook_storage_add_source): same. * gui/component/addressbook-component.c: (folder_types): add "ldap-contacts", for display of ldap servers (they get their own icon, and their own name in the Create New Folder dialog. (create_view): use IS_CONTACT_TYPE since we support two folder types now. (create_folder): same. (remove_folder): same. (xfer_folder): same. svn path=/trunk/; revision=12668
* change /Toolbar/ContactEditorSave to /Toolbar/ContactEditorSaveClose.Chris Toshok2001-09-072-1/+6
| | | | | | | | | 2001-09-06 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-editor.c: (pixmaps): change /Toolbar/ContactEditorSave to /Toolbar/ContactEditorSaveClose. svn path=/trunk/; revision=12665
* add -DEVOLUTION_IMAGESDIR.Chris Toshok2001-09-077-39/+89
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-06 Chris Toshok <toshok@ximian.com> * gui/component/Makefile.am (INCLUDES): add -DEVOLUTION_IMAGESDIR. * gui/widgets/e-addressbook-view.c (card_deleted_cb): remove status messages from here. (e_addressbook_view_delete_selection): same. * gui/widgets/e-addressbook-model.c (sequence_complete): emit a NULL status message along with the stop_state_changed. The null status message will clear the status bar for this view. * gui/component/addressbook.c (set_status_message): use the EvolutionActivityClient stuff. * backend/pas/pas-backend-ldap.c (view_destroy): remove status message for abandoning a search. (ldap_op_process_current): wrap status messages in _(). (ldap_op_process): same. (create_card_handler): same, and remove the notify_status for "" and add a notify_complete call after the card is added. (remove_card_handler): same. (modify_card_handler): same. (poll_ldap): wrap status messages with _(), and remove the "Search Complete" message. (ldap_search_handler): wrap status message. * backend/pas/pas-backend-file.c (pas_backend_file_search): use _() on status messages, and make sure the last notify_* called is notify_complete. svn path=/trunk/; revision=12663
* [Fix #958, ShellComponents should not be created by factories, forEttore Perazzoli2001-09-063-23/+28
| | | | | | | | | | | | | | | | the addressbook.] * gui/component/addressbook-component.c (GNOME_EVOLUTION_ADDRESSBOOK_COMPONENT_FACTORY_ID): Removed. (GNOME_EVOLUTION_ADDRESSBOOK_COMPONENT_ID): New. (create_component): Renamed from `factory_fn'. Just register the thing on OAF. (addressbook_component_factory_init): Just call it. * gui/component/GNOME_Evolution_Addressbook.oaf.in: Remove the ShellComponentFactory. svn path=/trunk/; revision=12642
* Check if the file is a VCard before importingIain Holmes2001-09-052-0/+9
| | | | svn path=/trunk/; revision=12610
* This file is no longer needed.Chyla Zbigniew2001-09-031-355/+0
| | | | svn path=/trunk/; revision=12564
* I18n fixes (mainly making buttons on the right side less Anglocentric :-)Chyla Zbigniew2001-09-039-157/+249
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * backend/ebook/e-card-simple.c (field_data): Marked "name" and "short_name" fields for translation. (e_card_simple_get_name, e_card_simple_get_short_name): Return localized version of the name (using U_() macro). * gui/contact-editor/e-contact-editor.c (set_entry_changed_signals): Connect "changed" signal from "entry-web" entry to widget_changed. (changing this field wasn't making "Save and Close" button sensitive) * gui/widgets/Makefile.am (glade_DATA): Removed alphabet.glade. * gui/widgets/e-addressbook-view.c (button_labels, button_letters): New strings containing a list of labels and "values" of all buttons placed on the right side of the addressbook view (intended for localization). (struct LetterClosure): Changed the type of letter field to gunichar. (e_utf8_split): New function, similar to g_strsplit, but operates on UTF-8 strings. (jump_to_letter): Don't hardcode letters, build queries dynamically using UTF-8 and localized letters stored in button_letters. (connect_button): Removed. (create_alphabet): Don't use glade file, build buttons manually using (localized) labels from button_labels. Use (localized) values from button_letters when creating LetterClosure. * gui/widgets/e-minicard-view-widget.[ch] (e_minicard_view_widget_jump_to_letter): Changed the type of the second argument from char to gunichar. * gui/widgets/e-minicard-view.c (compare_to_utf_str): Renamed from compare_to_letter, now operates on UTF-8 string. (e_minicard_view_jump_to_letter): Changed the type of the second argument from char to gunichar + conversion to UTF-8 string. * gui/widgets/e-minicard-view.h (e_minicard_view_jump_to_letter): Changed the type of the second argument from char to gunichar. svn path=/trunk/; revision=12563
* Use e_card_get_vcard_assume_utf8 instead of e_card_get_vcard here sinceChristopher James Lahey2001-09-0222-308/+484
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-09-02 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-book.c (e_book_add_card, e_book_commit_card), backend/pas/pas-backend-file.c (do_create), backend/pas/pas-backend-ldap.c (create_card_handler, remove_card_handler, modify_card_handler, pas_backend_ldap_process_get_vcard, poll_ldap): Use e_card_get_vcard_assume_utf8 instead of e_card_get_vcard here since all internal communications and database storage are assumed to be utf8. * backend/ebook/e-card-simple.c, backend/ebook/e-card-simple.h (e_card_simple_duplicate): Simplified this function considerably. (e_card_simple_get_vcard_assume_utf8): Added this function. * backend/ebook/e-card.c, backend/ebook/e-card.h (e_card_new, e_card_load_cards_from_file, e_card_load_cards_from_string): Made these functions pay attention to charset attributes. (e_card_new_with_default_charset, e_card_load_cards_from_file_with_default_charset, e_card_load_cards_from_string_with_default_charset): New functions that let you change the default charset from UTF-8. (e_card_get_vcard): Made this write out charset attributes when necessary. (e_card_get_vcard_assume_utf8): New function that writes out a card without writing out charset attributes. * backend/ebook/evolution-vcard-importer.c (book_open_cb), backend/ebook/load-gnomecard-addressbook.c (book_open_cb), backend/ebook/test-card.c (main), gui/component/addressbook-component.c (destination_folder_handle_drop), gui/contact-editor/test-editor.c (main), gui/contact-list-editor/e-contact-list-editor.c (table_drag_data_received_cb), gui/widgets/e-addressbook-view.c (selection_received), gui/widgets/e-minicard-control.c (pstream_load): Changed the default charset to be used here to ISO-8859-1. * backend/ebook/load-gnomecard-addressbook.c (add_card_cb), backend/ebook/load-pine-addressbook.c (add_card_cb), backend/ebook/test-client-list.c (get_cursor_cb), backend/ebook/test-client.c (get_cursor_cb, get_card_cb): Use e_card_get_vcard_assume_utf8 to print out testing strings. * gui/component/select-names/e-select-names-model.c, gui/component/select-names/e-select-names-model.h (e_select_names_model_contains): Changed this to be const EDestination *dest to fix a warning. * gui/contact-editor/e-contact-editor.c (e_contact_editor_init): Translate window title here. svn path=/trunk/; revision=12558
* s/_/U_/Chyla Zbigniew2001-09-015-4/+23
| | | | | | | | | | | | | | | | * gui/component/addressbook-storage.c (addressbook_get_other_contact_storage): s/_/U_/ * gui/widgets/e-addressbook-reflow-adapter.c (addressbook_compare): Use g_utf8_collate. * gui/widgets/e-minicard.c (e_minicard_compare): Ditto. * printing/e-contact-print.c (card_compare): Ditto. svn path=/trunk/; revision=12542
* Use e_select_names_model_merge to combine the selected names with anyJon Trowbridge2001-08-307-3/+97
| | | | | | | | | | | | | | | | | | | | | | | 2001-08-29 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (e_select_names_clicked): Use e_select_names_model_merge to combine the selected names with any existing ones. This causes you to not lose addresses typed directly into the entry while the SelectNames dialog is up. (Bug #8058) * gui/component/select-names/e-select-names-model.c (e_select_names_model_merge): Merge the contents of one ESelectNamesModel into another, avoiding duplicates. * backend/ebook/e-destination.c (e_destination_equal): Added. Determines if two destinations appear to refer to the same recipient. * backend/ebook/e-card.c (e_card_list_send): Added cast to g_free args to silence compiler warnings. svn path=/trunk/; revision=12526
* Paranoia. Check that name != qa->name. (quick_add_set_email): Check thatJon Trowbridge2001-08-302-10/+39
| | | | | | | | | | | | | | | | 2001-08-29 Jon Trowbridge <trow@ximian.com> * gui/contact-editor/e-contact-quick-add.c (quick_add_set_name): Paranoia. Check that name != qa->name. (quick_add_set_email): Check that email != qa->email. (ce_have_book): Store the QuickAdd data structure in object data, so that we can be extra-careful and avoid having a dangling pointer floating around out somewhere as the closure for a signal. Fixes bug #8155, I think. (card_added_cb): Clear object data to ensure single unref. (editor_closed_cb): Clear object data to ensure single unref. svn path=/trunk/; revision=12525
* Make sure that comp->priv->query_text isn't NULL. (Fixes bug #8195)Jon Trowbridge2001-08-302-3/+12
| | | | | | | | | | 2001-08-29 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (book_query_score): Make sure that comp->priv->query_text isn't NULL. (Fixes bug #8195) svn path=/trunk/; revision=12524
* This function can be re-entrant during the signal emission; Added extraJon Trowbridge2001-08-302-4/+22
| | | | | | | | | | | | 2001-08-29 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-listener.c (e_book_listener_check_queue): This function can be re-entrant during the signal emission; Added extra ref/unrefs and checks to avoid problems if this happens. This is similar to my recent changes to e_book_view_listener_check_queue. (Fixes bug #7400) svn path=/trunk/; revision=12523
* Studlycapsize all the IDs that are not. Likewise. Updated accordingly.Ettore Perazzoli2001-08-283-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Evolution-ShellComponent.idl: Studlycapsize all the IDs that are not. * Evolution-common.idl: Likewise. * evolution-activity-client.c: Updated accordingly. * evolution-shell-component.c: Likewise. * evolution-storage.c: Likewise. * e-activity-handler.c: Likewise. * e-component-registry.c: Likewise. * e-corba-storage.c: Likewise. * e-shell-user-creatable-items-handlers.c: Likewise. * e-local-storage.c (remove_folder): Remove unused variable. * e-shell-view.c (update_for_current_uri): Assign zero to `unread_count', not NULL. * e-shell-importer.c (import_druid_finish): Remove unused variable. * e-shell-user-creatable-items-handler.c: #include "e-corba-utils.h". * e-shell-startup-wizard.c: #include "e-shell-startup-wizard.h". * e-shell-startup-wizard.h: #include <glib.h> * e-summary-weather.c (weather_make_html): Make local variable `icon_name' const. Remove unused variable `uri'. * e-summary.h: Reformatted in GTK+ style. (e_summary_remove_online_connection): Added prototype. * e-summary-preferences.c (fill_mail_shown_clist): Constify local variable `name'. * e-summary-mail.c: #include "e-util/e-path.h". Updated to match the new studlyCapsification in shell/Evolution*.idl. * mail-local.c: Match the studlyCapsification of shell/Evolution*.idl. * mail-config-druid.h: Change type of `event_source' from `Bonobo_EventSource *' to `Bonobo_EventSource'. * mail-accounts.c (mail_delete): Remove unused local variable `label'. * folder-info.c (do_get_info): `#if 0' unused variables. * gui/component/addressbook-component.c: Get rid of a warning by initializing the closing NULL element in folder_types correctly. * gui/component/select-names/e-select-names.c: Updated to match the studlyCapsification of attributes in shell/Evolution*.idl. svn path=/trunk/; revision=12495
* Added. Generated queries against file_as. (match_file_as): Added. MatchJon Trowbridge2001-08-282-2/+68
| | | | | | | | | | | 2001-08-27 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (sexp_file_as): Added. Generated queries against file_as. (match_file_as): Added. Match results of queries against file_as. (Bug #8152) svn path=/trunk/; revision=12494
* Added ref/unref pair to make sure that our listener doesn't get finalizedJon Trowbridge2001-08-282-2/+19
| | | | | | | | | | | 2001-08-27 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): Added ref/unref pair to make sure that our listener doesn't get finalized during the signal emission and leave us with a dangling pointer. (Bug #7661) svn path=/trunk/; revision=12493
* Removed some debugging spew that I left in by mistake.Jon Trowbridge2001-08-283-5/+6
| | | | | | | | | | | | 2001-08-27 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card.c (e_card_list_send): Removed some debugging spew that I left in by mistake. * gui/widgets/e-addressbook-model.c (create_card): Removed debugging spew. svn path=/trunk/; revision=12492
* Do the right thing if the card we are trying to send to is a contact list.Jon Trowbridge2001-08-282-23/+91
| | | | | | | | | 2001-08-27 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card.c (e_card_list_send): Do the right thing if the card we are trying to send to is a contact list. (Bug #6580) svn path=/trunk/; revision=12491
* Display localized status string (added missing _()).Chyla Zbigniew2001-08-272-1/+6
| | | | | | | * gui/widgets/e-addressbook-util.c (e_addressbook_error_dialog): Display localized status string (added missing _()). svn path=/trunk/; revision=12476
* Put a freeze/thaw around our the set of operations that changes theJon Trowbridge2001-08-252-14/+30
| | | | | | | | | | | | | | | | 2001-08-24 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_set_card): Put a freeze/thaw around our the set of operations that changes the internal state of our card, so 'changed' signal callbacks won't be invoked on a card in an intermediary state. This fixes the bug that was causing the e-mail addresses in cards to be blank when replying to a message. (An unexpected side-effect of toshok's change on 8/22 to make sure that priv->email != NULL). (e_destination_get_name): Code slightly rearranged for (IMO) clarity. svn path=/trunk/; revision=12466
* add BUTTON_PRESS_MASK so double clicks still work.Chris Toshok2001-08-242-0/+6
| | | | | | | | | 2001-08-23 Chris Toshok <toshok@ximian.com> * gui/widgets/e-minicard.c (e_minicard_event): add BUTTON_PRESS_MASK so double clicks still work. svn path=/trunk/; revision=12427
* switch "full_name" to "x-evolution-any-field" in all the queries where weChris Toshok2001-08-232-3/+10
| | | | | | | | | | | 2001-08-23 Chris Toshok <toshok@ximian.com> * gui/component/addressbook.c (addressbook_query_changed): switch "full_name" to "x-evolution-any-field" in all the queries where we want to match all cards, since the backends universally handle this special case more efficiently. svn path=/trunk/; revision=12415
* In the GUI, the toggle is labelled "hide addresses", not "show addresses"Jon Trowbridge2001-08-234-4/+43
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-22 Jon Trowbridge <trow@ximian.com> * gui/contact-list-editor/e-contact-list-editor.c (extract_info): In the GUI, the toggle is labelled "hide addresses", not "show addresses" -- so we have to reverse the boolean value we read in. (fill_in_info): Same bug as before: since the GUI reads "hide", we have to initialize the toggle to '!show_addresses', not 'show_addresses'. * backend/ebook/e-destination.c (e_destination_list_show_addresses): Added. (e_destination_xml_encode): Encode the value of e_destination_list_show_addresses into the XML. (e_destination_xml_decode): Read and store the "show_addresses" flag. 2001-08-22 Jon Trowbridge <trow@ximian.com> * e-msg-composer-hdrs.c (set_recipients_from_destv): Added. Try to properly handle contact lists in which the addresses of the list members should be hidden. (e_msg_composer_hdrs_to_message): Changed to extract the destination data from the entries and pass it along to set_recipients_from_destv. 2001-08-22 Jon Trowbridge <trow@ximian.com> * mail-callbacks.c (ask_confirm_for_only_bcc): Provide alternative text for this dialog for the case when a message has only Bcc recipients because of a hidden contact list's addresses being moved from To/Cc to Bcc. (composer_get_message): Try to detect when our message has only Bcc recipients because of moving addresses around due to a hidden contact list, and show the dialog with the revised wording in this case. svn path=/trunk/; revision=12414
* emit an event from our event source (contact_editor_cb): emit a destroyjacob berkman2001-08-235-19/+87
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-22 jacob berkman <jacob@ximian.com> * gui/component/e-address-popup.c (emit_event): emit an event from our event source (contact_editor_cb): emit a destroy event so our control frame can be destroyed. (edit_contact_info_cb): emit a hide event so our control frame can be hidden (e_address_popup_cardify): (add_contacts_cb): emit the destroy event (e_address_popup_factory_new_control): don't unref our object at widget destroy time as that was really really broken (e_address_popup_factory_new_control): create an event source and aggregate ourself with it * gui/contact-editor/e-contact-editor.c (enable_writable_fields): display a nicer warning when we can't find a widget for a given field (e_contact_editor_raise): only raise if there is a window * gui/contact-editor/contact-editor.glade: name some widgets that got unnamed, and set the first entry as defaultable * gui/contact-editor/e-contact-editor.c: envelope printing is disabled in 1.0 2001-08-22 jacob berkman <jacob@ximian.com> * mail-display.c: rework how the e-card-popup thing has its life managed. we now hide the window on the Hide event and destroy it on the Destroy event emitted from its event source svn path=/trunk/; revision=12402
* make sure we don't get into a situation where priv->email == NULL.Chris Toshok2001-08-232-12/+25
| | | | | | | | | 2001-08-22 Chris Toshok <toshok@ximian.com> * backend/ebook/e-destination.c (e_destination_get_email): make sure we don't get into a situation where priv->email == NULL. svn path=/trunk/; revision=12393
* if we're dragging, drag_button_down won't be true in the BUTTON_RELEASEChris Toshok2001-08-212-21/+9
| | | | | | | | | | | | 2001-08-21 Chris Toshok <toshok@ximian.com> * gui/widgets/e-minicard.c (e_minicard_event): if we're dragging, drag_button_down won't be true in the BUTTON_RELEASE case, since we set it to false in MOTION_NOTIFY once the threshold is reached. (e_minicard_drag_end): remove this function, since it was needed to work around a bug in gnome-canvas. svn path=/trunk/; revision=12337
* Wrap our addressbook table adapter in an ETableWithout, so that we canJon Trowbridge2001-08-214-7/+106
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-20 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (e_addressbook_create_ebook_table): Wrap our addressbook table adapter in an ETableWithout, so that we can make addresses appear and disappear when we remove/add them to the section lists (To/Cc/Bcc) on the right of the dialog. (real_add_address_cb): When we add an address, hide it in the main list. (e_select_names_init): Get pointer to our without table from the table's object data, and store it. (remove_address): When we remove an address, show it in the main list. (card_key): Added. Allocate a unique key from an ECard. (esn_get_key_fn): Added. Callback for ETableWithout. (esn_dup_key_fn): Added. Callback for ETableWithout. (esn_free_gotten_key_fn): Added. Callback for ETableWithout. (esn_free_duped_key_fn): Added. Callback for ETableWithout. * backend/ebook/e-card-simple.c (e_card_simple_get): Changed E_CARD_SIMPLE_FIELD_NAME_OR_ORG to first try the FILE_AS type. This allows the cards in the ESelectName dialog to appear in proper sort order (i.e. as 'Doe, John' rather than 'John Doe'). Fixes ximian #6002. svn path=/trunk/; revision=12334
* fix arg info - we're only passing 1 GTK_TYPE_POINTER arg, not 2.Chris Toshok2001-08-214-17/+71
| | | | | | | | | | | | | | | | | | | | | | 2001-08-20 Chris Toshok <toshok@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (e_addressbook_reflow_adapter_class_init): fix arg info - we're only passing 1 GTK_TYPE_POINTER arg, not 2. * gui/widgets/e-minicard.c (e_minicard_event): lots of fixes for DnD. For GDK_BUTTON_PRESS, we grab immediately. For GDK_BUTTON_MOTION, we start the drag after a certain threshold, and connect to the "drag_end" signal on our canvas so we'll know when the drag is complete. For GDK_BUTTON_RELEASE, we release the grab if we were dragging and get the event. (e_minicard_drag_end): new function, just remove the pointer/gtk grabs and disconnect. * gui/widgets/e-minicard.h (struct _EMinicard): add "gint drag_button" svn path=/trunk/; revision=12331
* use DB_NOTFOUND constJP Rosevear2001-08-212-2/+7
| | | | | | | | | 2001-08-20 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_changes_foreach_key): use DB_NOTFOUND const svn path=/trunk/; revision=12311
* null out card_sexp so that we don't crash when copyingJP Rosevear2001-08-202-1/+8
| | | | | | | | | | 2001-08-20 JP Rosevear <jpr@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_process_get_changes): null out card_sexp so that we don't crash when copying svn path=/trunk/; revision=12290
* fix warnings, get compiling againJP Rosevear2001-08-205-25/+38
| | | | | | | | | | | | | | 2001-08-20 JP Rosevear <jpr@ximian.com> * conduit/address-conduit.c: fix warnings, get compiling again * conduit/address-conduit-config.h: remove c/p typos * conduit/address-conduit.h: ditto * conduit/Makefile.am: link against the static camel svn path=/trunk/; revision=12288
* Used Delete icon in menu.Damon Chaplin2001-08-202-1/+2
| | | | | | | | 2001-08-20 Damon Chaplin <damon@ximian.com> * gui/contact-editor/e-contact-editor.c: Used Delete icon in menu. svn path=/trunk/; revision=12281
* use bigger Save icon for toolbar.Damon Chaplin2001-08-202-0/+4
| | | | | | | | | 2001-08-20 Damon Chaplin <damon@ximian.com> * gui/contact-editor/e-contact-editor.c: use bigger Save icon for toolbar. svn path=/trunk/; revision=12279
* use 'Save As' icon rather than 'Save' as it seems more appropriate. AlsoDamon Chaplin2001-08-202-1/+7
| | | | | | | | | 2001-08-20 Damon Chaplin <damon@ximian.com> * gui/component/addressbook.c: use 'Save As' icon rather than 'Save' as it seems more appropriate. Also added delete icon for menu. svn path=/trunk/; revision=12268
* Added display_name and description to the type.Ettore Perazzoli2001-08-202-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * evolution-test-component.c: Added display_name and description to the type. * evolution-shell-component.c (impl__get_supported_types): Pass `display_name' and `description' here. (evolution_shell_component_construct): Likewise. * evolution-shell-component.h: New members `display_name', `description' in `EvolutionShellComponentFolderType'. * e-component-registry.c (register_type): New args @description and @display_name. Pass to `e_folder_type_registry_register_type()'. (register_component): Pass the values returned in the sequence from __get_supported_types. * e-folder-type-registry.c: New members `display_name' and `description' in `struct _FolderType'. (folder_type_new): New args @description and @display_name. Initialize the respective fields in the `FolderType' accordingly. (folder_type_free): Free `display_name' and `description'. (register_folder_type): New args @display_name, @description. (e_folder_type_registry_register_type): New args @display_name, @description. (e_folder_type_registry_get_description_for_type): New. (e_folder_type_registry_get_display_name_for_type): New. * Evolution-ShellComponent.idl: Added `display_name' and `description' fields to the `FolderType' struct. svn path=/trunk/; revision=12245
* use new Cut/Copy/Paste/Save/Search icons.Damon Chaplin2001-08-202-1/+13
| | | | | | | | | 2001-08-19 Damon Chaplin <damon@ximian.com> * gui/component/addressbook.c: use new Cut/Copy/Paste/Save/Search icons. svn path=/trunk/; revision=12241
* Forgot to mention that this commit fixes Ximian bug #4670.Chris Lahey2001-08-201-1/+2
| | | | svn path=/trunk/; revision=12221
* Set the folder bar message here.Christopher James Lahey2001-08-207-4/+167
| | | | | | | | | | | | | | | | 2001-08-19 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c (set_folder_bar_label), gui/widgets/e-addressbook-model.c, gui/widgets/e-addressbook-model.h (update_folder_bar_message), gui/widgets/e-addressbook-view.c, gui/widgets/e-addressbook-view.h (folder_bar_message): Set the folder bar message here. * gui/component/select-names/e-select-names-model.c (SEPLEN): Use strlen(SEPARATOR) here so that if the separator changes the length will work properly. svn path=/trunk/; revision=12220
* Added full country list. Fixes Ximian bug #5123.Christopher James Lahey2001-08-192-1/+236
| | | | | | | | | 2001-08-19 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/fulladdr.glade: Added full country list. Fixes Ximian bug #5123. svn path=/trunk/; revision=12217
* Set the pixtype for "ContactEditorDelete" to "pixbuf". Likewise. Likewise.Ettore Perazzoli2001-08-193-0/+8
| | | | | | | | | | | | | * evolution-addressbook.xml: Set the pixtype for "ContactEditorDelete" to "pixbuf". * evolution-contact-editor.xml: Likewise. * evolution-contact-list-editor.xml: Likewise. * gui/component/addressbook.c: Hook up `delete-message.png' as the icon for "ContactDelete". * gui/contact-editor/e-contact-editor.c: Likewise. svn path=/trunk/; revision=12206
* add prototype for addressbook_get_other_contact_storage.Chris Toshok2001-08-183-5/+22
| | | | | | | | | | | | | | | | | 2001-08-17 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-storage.h: add prototype for addressbook_get_other_contact_storage. * gui/component/addressbook-storage.c (addressbook_get_other_contact_storage): rename register_storage to this, and return the EvolutionStorage. (load_source_data): register_storage => addressbook_get_other_contact_storage. (addressbook_storage_add_source): register_storage => addressbook_get_other_contact_storage. svn path=/trunk/; revision=12197
* connect to the "changed" signal on "entry-web" to update command state.Chris Toshok2001-08-182-0/+11
| | | | | | | | | | 2001-08-17 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-editor.c (set_entry_changed_signals): connect to the "changed" signal on "entry-web" to update command state. svn path=/trunk/; revision=12193
* call e_card_set_id on the list's card so we can continue to use thisChris Toshok2001-08-183-0/+29
| | | | | | | | | | | | | | | | | | | 2001-08-17 Chris Toshok <toshok@ximian.com> * gui/contact-list-editor/e-contact-list-editor.c (list_added_cb): call e_card_set_id on the list's card so we can continue to use this dialog. also, call command_state_changed if we aren't closing the dialog so the toolbar is properly sensitized. (list_deleted_cb): always close the dialog after we successfully delete a list. * gui/contact-editor/e-contact-editor.c (card_added_cb): call e_card_set_id on the card so we can continue to use this dialog (to modify or delete the card.) (card_deleted_cb): always close the dialog after we successfully delete a card. svn path=/trunk/; revision=12191
* call e_sexp_encode_string on the search string the user types in so itChris Toshok2001-08-182-6/+16
| | | | | | | | | | 2001-08-17 Chris Toshok <toshok@ximian.com> * gui/component/addressbook.c (addressbook_query_changed): call e_sexp_encode_string on the search string the user types in so it doesn't break sexp parsing in the wombat. svn path=/trunk/; revision=12190
* changed to new print icon.Damon Chaplin2001-08-182-0/+5
| | | | | | | | 2001-08-17 Damon Chaplin <damon@ximian.com> * gui/component/addressbook.c: changed to new print icon. svn path=/trunk/; revision=12188
* rename physical_uri to uri, since it includes the addressbook.db for file:Chris Toshok2001-08-183-35/+79
| | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-17 Chris Toshok <toshok@ximian.com> * gui/component/select-names/e-select-names.c: (struct ESelectNamesFolder): rename physical_uri to uri, since it includes the addressbook.db for file: uris. (e_select_names_folder_free): physical_uri => uri. (e_select_names_option_activated): physical_uri => uri, and we don't need to strdup_printf "addressbook.db" onto the end anymore. (new_folder): if the physical_uri is a file: uri, append /addressbook.db onto it. (hookup_listener): new function, split out lots of code from e_select_names_hookup_shell_listener. (e_select_names_hookup_shell_listeners): rename e_select_names_hookup_shell_listener to this, and hookup both the local and "Other Contacts" listener, using hookup_listener. (e_select_names_destroy): disconnect from the other_contacts_listener and unref it. * gui/component/select-names/e-select-names.h (struct _ESelectNames): add a listener for Other Contacts, and rename "listener" to "local_listener." svn path=/trunk/; revision=12187
* If we get the "sequence_complete" signal when we aren't searching, itJon Trowbridge2001-08-182-18/+39
| | | | | | | | | | | | | | | | | | 2001-08-17 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (e_select_names_completion_seq_complete_cb): If we get the "sequence_complete" signal when we aren't searching, it means the addressbook changed out from under us. Clear the search cache, so that future completion requests won't use the out-of-date cached data. Also, don't unref book_view... we leave the EBookView open so that we can catch these addressbook changes. (e_select_names_completion_do_query): Don't use the book_view being non-NULL as a sign that another query is still running. (e_select_names_completion_got_book_view_cb): Properly unref any previous value in book_view. svn path=/trunk/; revision=12184
* Changed the messages here in the right click menus.Christopher James Lahey2001-08-183-4/+11
| | | | | | | | | | | 2001-08-17 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (e_addressbook_reflow_adapter_right_click), gui/widgets/e-addressbook-view.c (table_right_click): Changed the messages here in the right click menus. svn path=/trunk/; revision=12171
* unref our card_sexp. (create_card_handler): make sure to set the id of theChris Toshok2001-08-172-34/+134
| | | | | | | | | | | | | | | | | | 2001-08-17 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (view_destroy): unref our card_sexp. (create_card_handler): make sure to set the id of the vcard so it gets properly transmitted back to the BookView, and notify all matching BookViews to add the created card. (remove_card_handler): notify all matching BookViews to remove the card. (modify_card_handler): notify all matching BookViews to modify the card. (pas_backend_ldap_process_get_book_view): init card_sexp based on the view's search. svn path=/trunk/; revision=12151
* use card_sexp. (pas_backend_file_book_view_free): same.Chris Toshok2001-08-175-324/+461
| | | | | | | | | | | | | | | | 2001-08-17 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-file.c (pas_backend_file_book_view_copy): use card_sexp. (pas_backend_file_book_view_free): same. (vcard_matches_search): use the new pas_backend_card_sexp_match_vcard call. (pas_backend_file_search): use card_sexp. (pas_backend_file_process_get_book_view): same. * backend/pas/Makefile.am (libpas_a_SOURCES): add pas-backend-card-sexp.[ch]. svn path=/trunk/; revision=12150
* Added code so the user can create a new contact or contact list fromChristopher James Lahey2001-08-172-1/+42
| | | | | | | | | | 2001-08-17 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook-component.c (factory_fn): Added code so the user can create a new contact or contact list from anywhere in evolution. svn path=/trunk/; revision=12146
* Added a closing paren.Jeffrey Stedfast2001-08-172-0/+5
| | | | | | | | 2001-08-16 Jeffrey Stedfast <fejj@ximian.com> * backend/pas/evolutionperson.schema: Added a closing paren. svn path=/trunk/; revision=12142
* Renamed from _begin to match changes in gal 0.10.99.3.Jon Trowbridge2001-08-172-3/+7
| | | | | | | | | | 2001-08-16 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (e_select_names_completion_handle_request): Renamed from _begin to match changes in gal 0.10.99.3. svn path=/trunk/; revision=12117
* Check that name != NULL before we start messing with it. (Fixes bug #7329)Jon Trowbridge2001-08-162-9/+17
| | | | | | | | | | 2001-08-16 Jon Trowbridge <trow@ximian.com> * gui/contact-editor/e-contact-quick-add.c (e_contact_quick_add): Check that name != NULL before we start messing with it. (Fixes bug #7329) svn path=/trunk/; revision=12084
* Boost scoring on an exact nickname match. Manually addressify match.Jon Trowbridge2001-08-164-74/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-16 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (match_nickname): Boost scoring on an exact nickname match. Manually addressify match. (match_name): Manually addressify matches. (book_query_score): Remove automatic addressification. * gui/component/addressbook.c (addressbook_query_changed): Minor tweak to avoid a crash if we have a negative subid with id ESB_CATEGORY. This should never happen. (addressbook_menu_activated): Reset the entry/option when we select "Clear". Some changes to reflect renaming in ESearchBar. * gui/component/select-names/e-select-names-bonobo.c (entry_set_property_fn): Cardify after importing destinations. This might fix a problem that Damon is having. 2001-08-16 Jon Trowbridge <trow@ximian.com> * e-filter-bar.c (option_changed): Adjusted for renamed ESearchBar functions. (menubar_activated): Adjusted for renamed ESearchBar functions. * e-search-bar.c: Renames some of the horrible function names: s/option_choice/item_id/, s/suboption_choice/subitem_id/. 2001-08-16 Jon Trowbridge <trow@ximian.com> * gui/cal-search-bar.c: Changed to reflect my renaming of some of the more hideously-named functions in the ESearchBar API. svn path=/trunk/; revision=12081
* set title of initial dialog to Addressbook Sources (bug #6704).Chris Toshok2001-08-162-0/+6
| | | | | | | | | 2001-08-15 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-config.glade: set title of initial dialog to Addressbook Sources (bug #6704). svn path=/trunk/; revision=12078
* don't let people add subdirs in the ldap server storage - everything isChris Toshok2001-08-162-0/+9
| | | | | | | | | | 2001-08-15 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-storage.c (create_ldap_folder): don't let people add subdirs in the ldap server storage - everything is toplevel there. svn path=/trunk/; revision=12077
* implement using search_for_dn.Chris Toshok2001-08-152-4/+19
| | | | | | | | | | 2001-08-14 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (pas_backend_ldap_process_get_vcard): implement using search_for_dn. svn path=/trunk/; revision=12043
* Tell the search bar to translate the subitem texts.Federico Mena Quintero2001-08-152-0/+7
| | | | | | | | | 2001-08-14 Federico Mena Quintero <federico@ximian.com> * gui/component/addressbook.c (addressbook_factory_new_control): Tell the search bar to translate the subitem texts. svn path=/trunk/; revision=12015
* Add "Any Category" option for category searches.Jon Trowbridge2001-08-142-8/+26
| | | | | | | | | | | | | | | | 2001-08-14 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c (addressbook_factory_new_control): Add "Any Category" option for category searches. (addressbook_query_changed): Do the right thing on an "Any Category" search. 2001-08-14 Jon Trowbridge <trow@ximian.com> * e-search-bar.c (activate_by_subitems): Oops... initial suboption_choice should be subitems[0].id, not 0. svn path=/trunk/; revision=12013
* Fix up to match the pas_book_new/get_vcard changes.Dan Winship2001-08-142-37/+27
| | | | | | | * backend/pas/pas-backend-ldap.c: Fix up to match the pas_book_new/get_vcard changes. svn path=/trunk/; revision=12009
* Got rid of an extraneous _ here.Christopher James Lahey2001-08-143-2/+10
| | | | | | | | | | | | 2001-08-14 Christopher James Lahey <clahey@ximian.com> * gui/merging/e-card-merging-book-commit-duplicate-detected.glade: Got rid of an extraneous _ here. * gui/widgets/e-addressbook-util.c (e_addressbook_error_dialog): Changed Canceled to Cancelled here. Fixes Ximian bug #2465. svn path=/trunk/; revision=12002
* Oops, forgot to write this function.Christopher James Lahey2001-08-142-0/+28
| | | | | | | | | 2001-08-14 Christopher James Lahey <clahey@ximian.com> * backend/pas/pas-book.c (pas_book_respond_get_vcard): Oops, forgot to write this function. svn path=/trunk/; revision=11999
* Added focus targets here. Fixes part of Ximian bug #5843.Christopher James Lahey2001-08-142-52/+67
| | | | | | | | | 2001-08-14 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/contact-editor.glade: Added focus targets here. Fixes part of Ximian bug #5843. svn path=/trunk/; revision=11998
* Grab focus here. Fixes Ximian bug #2265.Christopher James Lahey2001-08-142-0/+7
| | | | | | | | | 2001-08-14 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/e-contact-editor.c (e_contact_editor_init): Grab focus here. Fixes Ximian bug #2265. svn path=/trunk/; revision=11995
* Fixed two const warnings here.Christopher James Lahey2001-08-144-3/+18
| | | | | | | | | | | | | 2001-08-14 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c (addressbook_factory_new_control): (addressbook_query_changed): Fixed two const warnings here. * printing/e-contact-print-envelope.c, printing/e-contact-print-envelope.h: Fixed some missing includes here. svn path=/trunk/; revision=11994
* As usual, I forgot to mention that that last commit fixes Ximian bug #6490.Chris Lahey2001-08-141-1/+1
| | | | svn path=/trunk/; revision=11992
* Call e_card_set_book here.Christopher James Lahey2001-08-147-172/+192
| | | | | | | | | | | | | | | | | | | 2001-08-14 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-book-view.c (add_book_iterator): Call e_card_set_book here. * backend/ebook/e-book.c (e_book_do_response_get_vcard): Call e_card_set_book here. * backend/ebook/e-card.c, backend/ebook/e-card.h: Pulled out the part where the uri is made part of the uid. Made uri a separate field. * backend/ebook/e-destination.c, backend/ebook/e-destination.h: Change this to use ECard's split uids and uris. svn path=/trunk/; revision=11991
* don't g_strdup the stuff we're passing into e_list_append, since it doesChris Toshok2001-08-141-0/+12
| | | | | | | | | | | | | | | | 2001-08-13 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (add_to_supported_fields): don't g_strdup the stuff we're passing into e_list_append, since it does the copy for us. (check_schema_support): don't initialize supported_fields list here, since there's a gross case where the programmer/user can bring up the contact editor before the connection stuff is finished, and we don't want to crash. (pas_backend_ldap_init): move it here to we can guarantee it's there. (bug #6546). svn path=/trunk/; revision=11990
* don't g_strdup the stuff we're passing into e_list_append, since it doesChris Toshok2001-08-141-8/+8
| | | | | | | | | | | | | | | | 2001-08-13 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (add_to_supported_fields): don't g_strdup the stuff we're passing into e_list_append, since it does the copy for us. (check_schema_support): don't initialize supported_fields list here, since there's a gross case where the programmer/user can bring up the contact editor before the connection stuff is finished, and we don't want to crash. (pas_backend_ldap_init): move it here to we can guarantee it's there. (bug #6546). svn path=/trunk/; revision=11989
* don't access source->auth if source == NULL (bug #7086).Chris Toshok2001-08-142-1/+7
| | | | | | | | | | 2001-08-13 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-config.c (addressbook_source_dialog_set_source): don't access source->auth if source == NULL (bug #7086). svn path=/trunk/; revision=11988
* Changed get_card to be asyncronous.Christopher James Lahey2001-08-1411-239/+218
| | | | | | | | | | | | | | | 2001-08-13 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-book-listener.c, backend/ebook/e-book-listener.h, backend/ebook/e-book.c, backend/ebook/e-book.h, backend/idl/addressbook.idl, backend/pas/pas-backend-file.c, backend/pas/pas-book.c, backend/pas/pas-book.h: Changed get_card to be asyncronous. * backend/ebook/e-card.c, backend/ebook/test-client.c: Changed these to deal with the new get_card functionality. svn path=/trunk/; revision=11984
* svn path=/trunk/; revision=11916Kjartan Maraas2001-08-123-5/+2
| | | | | | 2001-08-11 Kjartan Maraas <kmaraas@gnome.org> svn path=/trunk/; revision=11916
* Added bugzilla numberKjartan Maraas2001-08-111-0/+1
| | | | svn path=/trunk/; revision=11914
* Add headers to make it stand on itw own. Marked some strings forKjartan Maraas2001-08-113-2/+8
| | | | | | | | | 2001-08-11 Kjartan Maraas <kmaraas@gnome.org> * printing/e-contact-print.h: Add headers to make it stand on itw own. * printing/e-contact-print.c: Marked some strings for translation. svn path=/trunk/; revision=11913
* Marked some strings for translation. Same here.Kjartan Maraas2001-08-113-5/+10
| | | | | | | | | 2001-08-11 Kjartan Maraas <kmaraas@gnome.org> * printing/e-contact-print.c: Marked some strings for translation. * printing/e-contact-print-envelope.c: Same here. svn path=/trunk/; revision=11912
* Remove single- or double-quotes from names before sticking them into theJon Trowbridge2001-08-112-5/+21
| | | | | | | | | | 2001-08-10 Jon Trowbridge <trow@ximian.com> * gui/contact-editor/e-contact-quick-add.c (e_contact_quick_add): Remove single- or double-quotes from names before sticking them into the addressbook. (Bug #6499) svn path=/trunk/; revision=11909
* Properly handle "Category is" queries by checking the search barJon Trowbridge2001-08-112-6/+46
| | | | | | | | | | | | 2001-08-10 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c (addressbook_query_changed): Properly handle "Category is" queries by checking the search bar suboption. (addressbook_factory_new_control): Attach subitems corresponding to all wombat categories to the "Category is" ESearchBarItem. svn path=/trunk/; revision=11908
* Removed comment about the need to resolve nicknames properly, because weJon Trowbridge2001-08-112-8/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-10 Jon Trowbridge <trow@ximian.com> * e-msg-composer-hdrs.c (set_recipients): Removed comment about the need to resolve nicknames properly, because we now do that. 2001-08-10 Jon Trowbridge <trow@ximian.com> * e-filter-bar.h: Set the subitems to NULL in the pre-defined ESearchBarItems. * e-filter-bar.c (rule_editor_clicked): Set the ESearchBarItem's subitems to NULL. (build_items): Set the ESearchBarItem's subitems to NULL. (e_filter_bar_new): Set the ESearchBarItem's subitems to NULL. * e-search-bar.c: Added support for subitems, so that a search option can key off of another option menu rather than just an entry. 2001-08-10 Jon Trowbridge <trow@ximian.com> * gui/component/addressbook.c: Set the ESearchBarItem subitems explicitly to NULL. 2001-08-10 Jon Trowbridge <trow@ximian.com> * gui/cal-search-bar.c: Where we have ESearchBarItems, set their subitems to NULL. 2001-08-10 Jon Trowbridge <trow@ximian.com> * folder-browser.c: Set our ESearchBarItems subitems to NULL. svn path=/trunk/; revision=11904
* did a little packing-magic to get the two tables at bottom of this dialogAnna Marie Dirks2001-08-113-27/+66
| | | | | | | | | | | | 2001-08-10 Anna Marie Dirks <anna@ximian.com> * gui/component/select-names/select-names.glade: did a little packing-magic to get the two tables at bottom of this dialog to seem to line up. *gui/component/select-names/e-select-names.c: changed the title of this dialog to "Select Contacts from Addressbook". svn path=/trunk/; revision=11897
* redesigned this dialog to fix bug #6815.Anna Marie Dirks2001-08-103-194/+302
| | | | | | | | | | | | 2001-08-09 Anna Marie Dirks <anna@ximian.com> * gui/component/select-names/select-names.glade: redesigned this dialog to fix bug #6815. *gui/component/select-names/e-select-names.c: connected the widgets (or one of them anyway. clahey did the rest) for my new and lovely glade file. svn path=/trunk/; revision=11862
* remove passwd_cb.Chris Toshok2001-08-102-8/+4
| | | | | | | | 2001-08-09 Chris Toshok <toshok@ximian.com> * gui/component/addressbook.c: remove passwd_cb. svn path=/trunk/; revision=11855
* If the last character we inserted was a "magic comma", remember itsJon Trowbridge2001-08-103-0/+29
| | | | | | | | | | | | | | | | | 2001-08-09 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-text-model.c This change is dedicated to Jacob Berkman. (e_select_names_text_model_insert_length): If the last character we inserted was a "magic comma", remember its position. (e_select_names_text_model_delete): If the last character we inserted was a "magic comma", and if the next thing we do is to hit backspace, delete both the comma and the extra whitespace we added. (e_select_names_text_model_init): Initialize our last magic comma position. svn path=/trunk/; revision=11839
* Hook up some magic to (basically) cardify an entry on focus-out. (What weJon Trowbridge2001-08-1012-32/+681
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-09 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_create_entry): Hook up some magic to (basically) cardify an entry on focus-out. (What we do is actually more complicated than that.) * gui/component/select-names/e-select-names-bonobo.c (entry_set_property_fn): After we set an entry's text, try to cardify it. We need to do this so that (for example) reply e-mails get properly cardified. * gui/component/select-names/e-select-names-model.c (e_select_names_model_duplicate): Use e_select_names_model_append, rather than manipulating lists directly. (e_select_names_model_insert): Connect "changed" signal proxy for added EDestination. (e_select_names_model_append): Ditto. (e_select_names_model_replace): Ditto, and disconnect signals for replaced EDestination. (e_select_names_model_delete): Ditto on the disconnection. (e_select_names_model_delete_all): Ditto. (e_select_names_model_cardify): Added. Try to cardify a specified EDestination. (e_select_names_model_cancel_cardify): Added. Cancel the pending cardification of a single EDestination. (e_select_names_model_cardify_all): Added. Cardify all of the EDestinations in the model. (e_select_names_model_cancel_cardify_all): Added. Cancel's any and all pending cardifications. * backend/ebook/e-destination.c (e_destination_class_init): Added "changed" and "cardified" signals. (e_destination_freeze): Added (static). (e_destination_thaw): Added (static). (e_destination_clear_card): Reset allow_cardify and cannot_cardify, cancel any pending cardifications, and emit the "changed" signal. (e_destination_clear_strings): Emit the "changed" signal. (e_destination_clear): Do freeze/thaw to prevent multiple signal emissions. (e_destination_set_card): Check that the card we are setting is not equal to the current card, and emit the "changed" signal if we are actually changing. (e_destination_set_card_uri): Emit "changed" signal, if necessary. (e_destination_set_name): Emit "changed" signal, if necessary. (e_destination_set_email): Emit "changed" signal, if necessary. (e_destination_set_html_mail_pref): Emit "changed" signal, if necessary. (use_card_cb): If we've just loaded/set the ECard, emit the "changed" signal. (e_destination_set_raw): Emit "changed" signal, if necessary. (e_destination_allow_cardification): Added. (e_destination_set_allow_cardification): Added. (e_destination_cardify): Added. Tries to automatically convert a string-based EDestination to one based on an ECard. (e_destination_cardify_delayed): Added. Cardifies in a timeout. (e_destination_cancel_cardify): Added. Cancels any pending cardifications. (e_destination_xml_decode): Added freeze/thaw. * backend/ebook/e-book-util.c (e_book_nickname_query): Added. A canned simple query for nicknames. * backend/ebook/e-card.c (e_card_email_find_number): Added. Given a card and an string containing an email address, return the index number of the address inside of the card, or -1 if the address is not found. svn path=/trunk/; revision=11837
* [ Fixes ximian bugs #5080, #6021, #6704, #6705 ]Chris Toshok2001-08-108-884/+1116
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-09 Chris Toshok <toshok@ximian.com> [ Fixes ximian bugs #5080, #6021, #6704, #6705 ] * gui/component/addressbook.c (book_open_cb): create our own dialog that prompts for both the email address and the password. the email address is stored in the source and filled in for the user after the first time they enter one and press OK. * gui/component/addressbook-storage.c (create_ldap_folder): has a return value, not a int* parameter. (create_ldap_folder): new function, we can create ldap servers from the File->New->Folder menu item now. (register_storage): hook up the "create_folder" signal. (addressbook_storage_init_source_uri): remove the file case, we only build ldap uris here. (load_source_data): remove the file source stuff, and handle "emailaddr". (save_source_data): call ldap_source_foreach directly. (addressbook_source_free): remove file source stuff. (addressbook_source_copy): same. * gui/component/addressbook-storage.h: get rid of all the file source stuff from AddressbookSource, since this is only being used for ldap servers. * backend/pas/pas-backend-ldap.c (pas_backend_ldap_process_authenticate_user): look up the ldap entry based on the provided email address and use the resulting DN/passwd to authenticate. * gui/component/addressbook-config.c: pretty much gutted to make it work with the new UI. * gui/component/addressbook-config.glade: new version from anna. svn path=/trunk/; revision=11834
* Upped the minimum width on all addressbook columns to 75. Fixes Ximian bugChristopher James Lahey2001-08-092-39/+44
| | | | | | | | | 2001-08-09 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-view.c (SPEC): Upped the minimum width on all addressbook columns to 75. Fixes Ximian bug #2773. svn path=/trunk/; revision=11829
* mark the dialog as changed so the save button is immediately available.Chris Toshok2001-08-093-2/+48
| | | | | | | | | | | | | | | | | 2001-08-08 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-quick-add.c (ce_have_book): mark the dialog as changed so the save button is immediately available. * gui/contact-editor/e-contact-editor.c (card_modified_cb): once we save reset the change flag to false if we aren't closing the dialog. (card_added_cb): same. (e_contact_editor_class_init): add a "changed" arg. (e_contact_editor_set_arg): add setter for "changed". (e_contact_editor_get_arg): add getter for "changed". svn path=/trunk/; revision=11799
* better to assume that we can write to the local addressbook than that weChris Toshok2001-08-092-1/+7
| | | | | | | | | | 2001-08-08 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-quick-add.c (ce_have_book): better to assume that we can write to the local addressbook than that we can't write to it :) svn path=/trunk/; revision=11798
* call e_pixmap_update so we can use the same save/save-as pixmaps as theChris Toshok2001-08-092-0/+16
| | | | | | | | | | 2001-08-08 Chris Toshok <toshok@ximian.com> * gui/contact-list-editor/e-contact-list-editor.c (create_ui): call e_pixmap_update so we can use the same save/save-as pixmaps as the contact editor. svn path=/trunk/; revision=11797
* new function, used by the context menu.Chris Toshok2001-08-092-3/+45
| | | | | | | | | | | | 2001-08-08 Chris Toshok <toshok@ximian.com> * gui/widgets/e-addressbook-reflow-adapter.c (open_card): new function, used by the context menu. (e_addressbook_reflow_adapter_right_click): put "Open" at the top of the menu. also, disable "Delete" if the addressbook isn't writable. svn path=/trunk/; revision=11794
* escape *, \, (, and ), as per rfc2254. (func_contains): escape the string.Chris Toshok2001-08-082-4/+56
| | | | | | | | | | | | | 2001-08-08 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (rfc2254_escape): escape *, \, (, and ), as per rfc2254. (func_contains): escape the string. (func_is): same. (func_beginswith): same. (func_endswith): same. svn path=/trunk/; revision=11789
* Fixes Clahey bug #2200 :-)Nat Friedman2001-08-084-0/+25
| | | | | | | | | | | | | | | | | | | | 2001-08-08 Nat Friedman <nat@ximian.com> * evolution-contact-editor.xml: Removed Print Envelope since it's disabled for Evolution 1.0. * gui/widgets/e-addressbook-reflow-adapter.c (print_envelope): If 0'd out since Envelope printing is disabled for 1.0. * gui/widgets/e-addressbook-view.c (print_envelope): Likewise. * gui/contact-editor/e-contact-editor.c (print_envelope_cb): Likewise. * gui/widgets/e-addressbook-reflow-adapter.c (e_addressbook_reflow_adapter_right_click): Removed "Print Envelope" menu item. * gui/widgets/e-addressbook-view.c (table_right_click): Likewise. * gui/contact-editor/e-contact-editor.c (verbs): Likewise. svn path=/trunk/; revision=11780
* ifdef this HAVE_LDAP.Chris Toshok2001-08-082-0/+7
| | | | | | | | | 2001-08-07 Chris Toshok <toshok@ximian.com> * gui/component/addressbook-storage.c (remove_ldap_folder): ifdef this HAVE_LDAP. svn path=/trunk/; revision=11763
* set the title of the window to "Advanced Search".Chris Toshok2001-08-082-1/+7
| | | | | | | | | | 2001-08-07 Chris Toshok <toshok@ximian.com> * gui/search/e-addressbook-search-dialog.c (e_addressbook_search_dialog_init): set the title of the window to "Advanced Search". svn path=/trunk/; revision=11761
* pass view->view instead of the EBook. (addressbook_search_menu_items):Chris Toshok2001-08-084-122/+74
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-07 Chris Toshok <toshok@ximian.com> * gui/component/addressbook.c (search_cb): pass view->view instead of the EBook. (addressbook_search_menu_items): remove E_FILTERBAR_ADVANCED. (addressbook_menu_activated): remove E_FILTERBAR_ADVANCED. (addressbook_search_option_items): add "Advanced..." here. (addressbook_query_changed): add special handling for Advanced... * gui/search/e-addressbook-search-dialog.h (struct _EAddressbookSearchDialog): add EAddressbookView and remove the model/adapter fields. Also fix prototype of e_addressbook_search_dialog_new. * gui/search/e-addressbook-search-dialog.c (e_addressbook_search_dialog_class_init): get rid of set_arg/get_arg. (button_press): set the query on the EAddressbookView, and always close the dialog. (e_addressbook_search_dialog_init): get rid of the minicard view, and pack the other widgets accordingly. (e_addressbook_search_dialog_new): pass EAddressbookView instead of EBook. (e_addressbook_search_dialog_destroy): remove model/adapter stuff. svn path=/trunk/; revision=11760
* [ Fixes bug #5066 ] new function, remove the source. (register_storage):Chris Toshok2001-08-082-0/+22
| | | | | | | | | | | | 2001-08-07 Chris Toshok <toshok@ximian.com> [ Fixes bug #5066 ] * gui/component/addressbook-storage.c (remove_ldap_folder): new function, remove the source. (register_storage): connect to the "remove_folder" signal so we know when to remove the folder. svn path=/trunk/; revision=11756
* use g_strcasecmp since ldap attribute names are not case sensitive.Chris Toshok2001-08-082-1/+6
| | | | | | | | | 2001-08-07 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (build_card_from_entry): use g_strcasecmp since ldap attribute names are not case sensitive. svn path=/trunk/; revision=11734
* make sure we update the changed state if a successful drop happens.Chris Toshok2001-08-082-0/+14
| | | | | | | | | | 2001-08-07 Chris Toshok <toshok@ximian.com> * gui/contact-list-editor/e-contact-list-editor.c (table_drag_data_received_cb): make sure we update the changed state if a successful drop happens. svn path=/trunk/; revision=11733
* Make the OK button the keyboard default instead of Cancel. Bug #4942.Jason Leach2001-08-082-0/+7
| | | | | | | | | | 2001-08-07 Jason Leach <jleach@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_init): Make the OK button the keyboard default instead of Cancel. Bug #4942. svn path=/trunk/; revision=11732
* new EBookOp destructor (e_book_unqueue_op): use e_book_op_freeRadek Doulik2001-08-072-16/+34
| | | | | | | | | | | | | | | | 2001-08-06 Radek Doulik <rodo@ximian.com> * backend/ebook/e-book.c (e_book_op_free): new EBookOp destructor (e_book_unqueue_op): use e_book_op_free (e_book_do_response_create_card): ditto (e_book_do_response_generic): ditto (e_book_do_response_get_cursor): ditto (e_book_do_response_get_view): ditto (e_book_do_response_get_changes): ditto (e_book_do_response_open): ditto (e_book_do_response_get_supported_fields): ditto svn path=/trunk/; revision=11696
* set op->listener to NULL to catch possible use of freed opRadek Doulik2001-08-053-1/+20
| | | | | | | | | | | | | | | | | 2001-08-05 Radek Doulik <rodo@ximian.com> * backend/ebook/e-book.c (e_book_do_response_get_view): set op->listener to NULL to catch possible use of freed op (e_book_do_response_get_changes): ditto * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): this callback could be (and indeed is) called from signal emited above, signal handler could call e_book_view_listener_stop, so we need to check if idle is still set and if not we don't want to unref again svn path=/trunk/; revision=11692
* Made it so that if there's one less match than possible compares areChristopher James Lahey2001-08-052-1/+7
| | | | | | | | | | 2001-08-04 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-compare.c (e_card_compare_name): Made it so that if there's one less match than possible compares are considered more VAGUE. Fixes Ximian bug #3400. svn path=/trunk/; revision=11685
* Once again forgot to mark which bug this fixes. Ximian bug #3699.Chris Lahey2001-08-041-1/+1
| | | | svn path=/trunk/; revision=11645
* Check for storage != NULL here. This shouldn't come up unless addressbookChristopher James Lahey2001-08-042-13/+24
| | | | | | | | | | | | 2001-08-03 Christopher James Lahey <clahey@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_hookup_shell_listener): Check for storage != NULL here. This shouldn't come up unless addressbook has crashed previously within this session of evolution, but this is just a bit of insurance. svn path=/trunk/; revision=11644
* Added annotation that my last commit fixes Ximian bug #4674.Chris Lahey2001-08-041-1/+2
| | | | svn path=/trunk/; revision=11642
* Changed the criteria of whether the first part of each iteration matchedChristopher James Lahey2001-08-042-29/+32
| | | | | | | | | | | 2001-08-03 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card.c (e_card_name_match_string): Changed the criteria of whether the first part of each iteration matched or the second one did. Before it got it wrong sometimes and caused the pointer to jump off the end of the array. svn path=/trunk/; revision=11641
* Update for EvolutionStorage API changes. (addressbook_storage_add_source):Jason Leach2001-08-042-2/+8
| | | | | | | | | | 2001-08-03 Jason Leach <jleach@ximian.com> * gui/component/addressbook-storage.c (load_source_data): Update for EvolutionStorage API changes. (addressbook_storage_add_source): Ditto. svn path=/trunk/; revision=11634
* Noted that the last commit fixes Ximian bug #2202Chris Lahey2001-08-041-1/+2
| | | | svn path=/trunk/; revision=11628
* Made this change the query based on which letter is clicked.Christopher James Lahey2001-08-042-2/+76
| | | | | | | | | 2001-08-03 Christopher James Lahey <clahey@ximian.com> * gui/widgets/e-addressbook-view.c (jump_to_letter): Made this change the query based on which letter is clicked. svn path=/trunk/; revision=11627
* Fixed warnings here.Christopher James Lahey2001-08-033-10/+11
| | | | | | | | | | | | 2001-08-03 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c (addressbook_factory_new_control): Fixed warnings here. * gui/component/select-names/e-select-names-completion.c (hash_cleanup_fn): Removed this unused function. svn path=/trunk/; revision=11613
* Made the list of E_CARD_PHONE types in phone_correspondences more completeChristopher James Lahey2001-08-034-51/+105
| | | | | | | | | | | | | | | | | | | | | | | 2001-08-03 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-card-simple.c (e_card_simple_sync_card, fill_in_info): Made the list of E_CARD_PHONE types in phone_correspondences more complete by adding the new 5 E_CARD_PHONE types. Also, made it a bit less restrictive for some types (E_CARD_PHONE_HOME will actually match E_CARD_SIMPLE_PHONE_ID_HOME now.) Made e_card_simple_sync_card and fill_in_info search for an exact match in the list of phone_correspondences and then look for a partial match. Got rid of not going forward when doing a remove from an EList since EList handles this case automatically. * backend/ebook/e-card-types.h: Added E_CARD_PHONE types for assistant, callback, radio, telex, and ttytdd. * backend/ebook/e-card.c (get_phone_flags, set_phone_flags): Handle the new E_CARD_PHONE types. svn path=/trunk/; revision=11612
* Add camel dependency.Jon Trowbridge2001-08-0310-142/+224
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-08-02 Jon Trowbridge <trow@ximian.com> * printing/Makefile.am (ecpsdir): Add camel dependency. * gui/component/Makefile.am: Add camel dependency. * backend/ebook/Makefile.am: Add camel dependency. * gui/component/addressbook-factory.c (main): Properly init camel. * backend/ebook/e-destination.c (e_destination_clear_strings): Clear ->raw. (e_destination_is_empty): We aren't empty if ->raw is set.. (e_destination_set_raw): Replaces e_destination_set_string. (e_destination_get_name): Use camel's parser to extract the name from ->raw. (e_destination_get_email): Use camel's parser to extract the email address from ->raw. (e_destination_get_address): Use camel to produce properly quoted, RFC-compliant addresses. Thanks camel! (Bug #5860) * gui/component/select-names/e-select-names-completion.c (emailify_match): Always append an e-mail address, as long as it doesn't have one already at it's beginning or end. Don't limit self to just emailifying entries tied to cards with multiple addresses. (I didn't really want to do this, but people seem to like keeping multiple cards for the same person, and other solutions (like scanning all matches for duplicate names, and only emailifying those) just seemed like way too much work for such a limited payoff.) * gui/component/select-names/e-select-names-text-model.c: s/e_destination_set_string/e_destination_set_raw/. * gui/component/select-names/e-select-names-popup.c (popup_menu_card): Quote _'s in our popup menus, so that "foo_bar" doesn't get displayed as "foobar" w/ the 'b' underlined. (Bug #5558) (popup_menu_nocard): Ditto. 2001-08-02 Jon Trowbridge <trow@ximian.com> * Makefile.am: Added camel dependency (now needed by ebook). 2001-08-02 Jon Trowbridge <trow@ximian.com> * gui/Makefile.am: Added camel dependency (now needed by ebook). 2001-08-02 Jon Trowbridge <trow@ximian.com> * Makefile.am: Added camel dependency (now needed by ebook). svn path=/trunk/; revision=11602
* Removed some extra padding and pack the addressbook view into a frame withJason Leach2001-08-032-16/+24
| | | | | | | | | | 2001-08-02 Jason Leach <jleach@ximian.com> * gui/component/addressbook.c (addressbook_factory_new_control): Removed some extra padding and pack the addressbook view into a frame with inward shadowing, just because it looks prettier. svn path=/trunk/; revision=11585
* Update the updated Save, Save As, and Print icons for menus and theJason Leach2001-08-032-2/+20
| | | | | | | | | | 2001-08-02 Jason Leach <jleach@ximian.com> * evolution-contact-editor.xml: Update the updated Save, Save As, and Print icons for menus and the toolbar. Also added a Close button to the toolbar and some other fixes suggested in #5518. svn path=/trunk/; revision=11584
* ChangeLog fix. Should have been:Christopher James Lahey2001-08-021-1/+2
| | | | | | | | | | | | | | | | 2001-08-02 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c: Added ContactsSaveAsVCard, ContactsSendContactToOther, and ContactsSendMessageToContact verbs here. * gui/widgets/e-addressbook-view.c, gui/widgets/e-addressbook-view.h (e_addressbook_view_save_as, e_addressbook_view_send, e_addressbook_view_send_to): New functions to allow outside users to cause the addressbook to save, send, or send a message to its selection. svn path=/trunk/; revision=11568
* Added ContactsSaveAsVCard, ContactsSendContactToOther, andChristopher James Lahey2001-08-024-29/+114
| | | | | | | | | | | | | | | 2001-08-02 Christopher James Lahey <clahey@ximian.com> * gui/component/addressbook.c: Added ContactsSaveAsVCard, ContactsSendContactToOther, and ContactsSendMessageToContact verbs here. * gui/widgets/e-addressbook-view.c (e_addressbook_view_save_as, e_addressbook_view_send, e_addressbook_view_send_to): New functions to allow outside users to cause the addressbook to save, send, or send a message to its selection. svn path=/trunk/; revision=11567
* Removed this file from this unused directory.Christopher James Lahey2001-08-012-8/+5
| | | | | | | | | 2001-08-01 Christopher James Lahey <clahey@ximian.com> * contact-editor/.cvsignore: Removed this file from this unused directory. svn path=/trunk/; revision=11541
* Added file-exists.glade.Christopher James Lahey2001-08-014-1/+158
| | | | | | | | | | | | | 2001-08-01 Christopher James Lahey <clahey@ximian.com> * gui/contact-editor/Makefile.am: Added file-exists.glade. * gui/contact-editor/e-contact-save-as.c (file_exists), gui/contact-editor/file-exists.glade: Added a dialog to ask the user whether to replace an already existing file. Mostly from a patch by Jos Dehaes. Fixes Ximian bug #2231. svn path=/trunk/; revision=11540
* Removed thrash checking code here since thrashing shouldn't happen nowChristopher James Lahey2001-08-013-83/+88
| | | | | | | | | | | | | | 2001-08-01 Christopher James Lahey <clahey@ximian.com> * backend/ebook/e-book-view-listener.c (e_book_view_listener_check_queue): Removed thrash checking code here since thrashing shouldn't happen now that we've cleaned this up some. * backend/ebook/e-book.c (e_book_do_response_get_view): Properly handle cases where construction fails. svn path=/trunk/; revision=11539
* Added #include <e-util/e-path.h>.Christopher James Lahey2001-07-313-3/+18
| | | | | | | | | | | | | | 2001-07-30 Christopher James Lahey <clahey@ximian.com> * backend/ebook/evolution-vcard-importer.c: Added #include <e-util/e-path.h>. 2001-07-23 Zbigniew Chyla <cyba@gnome.pl> * gui/component/addressbook-config.c (addressbook_source_dialog): Convert translated string to UTF8 before calling put_html. svn path=/trunk/; revision=11496
* Properly handle the case where our "cleaned" completion is the emptyJon Trowbridge2001-07-313-20/+102
| | | | | | | | | | | | | | | | | 2001-07-30 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-completion.c (e_select_names_completion_do_query): Properly handle the case where our "cleaned" completion is the empty string. This happens, for example, if the query text is the string "\"". (Bug #5610). * backend/ebook/e-destination.c (e_destination_get_address_textv): Reassure fejj that I'm not doing something stupid here. (e_destination_get_address): Fix address quoting. This is a stop-gap measure until I can change this code to use Camel's superior address-handling routines. (Also Bug #5610) svn path=/trunk/; revision=11487
* Fix a return value bug, to make it so if it fails to load anJason Leach2001-07-312-26/+34
| | | | | | | | | | | | | 2001-07-30 Jason Leach <jleach@ximian.com> * gui/component/addressbook-storage.c (load_source_data): Fix a return value bug, to make it so if it fails to load an addressbook-sources.xml file (either a parse error or it doesn't exist for example), it deregisters the storage. (register_storage): Don't make a storage for users who don't have LDAP support built in. Bug #1950. svn path=/trunk/; revision=11476
* Fix support for gtkhtml when compiled with gconf supportFrédéric Crozat2001-07-302-0/+13
| | | | svn path=/trunk/; revision=11473
* Tidy ldaddsJP Rosevear2001-07-282-4/+8
| | | | | | | | 2001-07-27 JP Rosevear <jpr@ximian.com> * conduit/Makefile.am: Tidy ldadds svn path=/trunk/; revision=11449
* Fixing a small, stupid mistake; use e_select_names_model_get_textificationJon Trowbridge2001-07-262-2/+13
| | | | | | | | | | 2001-07-26 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names-bonobo.c: Fixing a small, stupid mistake; use e_select_names_model_get_textification for the getter for "text". svn path=/trunk/; revision=11423
* Removed some debugging chatter.Jon Trowbridge2001-07-266-22/+116
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 2001-07-26 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-card.c: Removed some debugging chatter. * gui/component/select-names/e-select-names-manager.c (e_select_names_manager_create_entry): Store the completion handler in the entry's object data. * gui/component/select-names/e-select-names-bonobo.c (entry_get_property_fn): Added support for getting "destinations" and "allow_contact_lists" properties. (entry_set_property_fn): Added support for setting "destinations" and "allow_contact_lists" properties. (impl_SelectNames_get_entry_for_section): Added definitions for "destinations" and "allow_contact_lists" properties. * gui/component/select-names/e-select-names-completion.c (e_select_names_completion_get_match_contact_lists): Added. (e_select_names_completion_set_match_contact_lists): Added. Controls whether contact lists are offered as options during completion. (book_query_process_card_list): Check if match_contact_lists is set before (duh!) matching on a contact list. (e_select_names_completion_init): Set match_contact_lists to TRUE by default. 2001-07-26 Jon Trowbridge <trow@ximian.com> * e-msg-composer-hdrs.c (set_recipients): Get "destinations", rather than "text" from the entry_widget. (The getters/setters in the control have been made more symmetric.) svn path=/trunk/; revision=11422
* change the way x-evolution-any-field is converted to an ldap query. itChris Toshok2001-07-262-14/+12
| | | | | | | | | | | | 2001-07-25 Chris Toshok <toshok@ximian.com> * backend/pas/pas-backend-ldap.c (func_contains): change the way x-evolution-any-field is converted to an ldap query. it used to be we'd nest queries like: (|(|(|(foo=*x*))(bar=*x*))(baz=*x*)). now we build it like: (|(foo=*x*)(bar=*x*)(baz=*x*)). much more efficient (both in the building, and on the server side no doubt). svn path=/trunk/; revision=11407
* Properly dup the results of e_destination_get_email.Jon Trowbridge2001-07-254-3/+20
| | | | | | | | | | | | | | | | 2001-07-25 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_get_name): Properly dup the results of e_destination_get_email. * gui/component/select-names/e-select-names-popup.c (e_select_names_popup): Check that our destination isn't empty before building our popup. (Bug #5250) * backend/ebook/e-destination.c (e_destination_is_empty): Made argument const. svn path=/trunk/; revision=11395
* Added checks for all of the args of the exposed functions, so that weJon Trowbridge2001-07-252-0/+23
| | | | | | | | | | 2001-07-24 Jon Trowbridge <trow@ximian.com> * gui/contact-list-editor/e-contact-list-model.c: Added checks for all of the args of the exposed functions, so that we won't crash on bad inputs. (Related to bug #4856.) svn path=/trunk/; revision=11394
* "_Add Anyway" to "Add Anyway".Jason Leach2001-07-252-1/+6
| | | | | | | | | 2001-07-24 Jason Leach <jleach@ximian.com> * gui/merging/e-card-duplicate-detected.glade: "_Add Anyway" to "Add Anyway". svn path=/trunk/; revision=11359
* Added fallbacks for the name in the case of an e-card, to avoid theJon Trowbridge2001-07-252-1/+19
| | | | | | | | | | 2001-07-24 Jon Trowbridge <trow@ximian.com> * backend/ebook/e-destination.c (e_destination_get_name): Added fallbacks for the name in the case of an e-card, to avoid the "nameless contact" bug. svn path=/trunk/; revision=11358
* need the EDestination magic here too for when we modify an already shownChris Toshok2001-07-254-5/+52
| | | | | | | | | | | | | | | | | | | | | 2001-07-24 Chris Toshok <toshok@ximian.com> * gui/widgets/e-minicard.c (remodel): need the EDestination magic here too for when we modify an already shown card. * gui/contact-list-editor/e-contact-list-model.c: make parent_class static, just to be anal. * gui/contact-list-editor/e-contact-list-editor.c (remove_entry_cb): removing entries changes the list, so flag it. (table_drag_data_received_cb): restrict cards we add to lists to be non-list cards. (extract_info): clear out the email list in the card before we repopulate it from the contact list model. (fill_in_info): set the checkbox to active/inactive based on thecard. svn path=/trunk/; revision=11356
* call widget_changed. (phone_entry_changed): same. (email_entry_changed):Chris Toshok2001-07-252-25/+100
| | | | | | | | | | | | | | | | | | | 2001-07-24 Chris Toshok <toshok@ximian.com> * gui/contact-editor/e-contact-editor.c (wants_html_changed): call widget_changed. (phone_entry_changed): same. (email_entry_changed): same. (address_text_changed): same. (name_entry_changed): same. (company_entry_changed): same. (widget_changed): new function that we can either call or set as a signal to change the "changed" flag on the dialog. (set_entry_changed_signals): connect lots of "changed" signals on widgets to widget_changed. (add_lists): connect "changed" to widget_changed. svn path=/trunk/; revision=11355
* Check if evolution_shell_client_get_local_storage returnsJon Trowbridge2001-07-252-0/+20
| | | | | | | | | | | | 2001-07-24 Jon Trowbridge <trow@ximian.com> * gui/component/select-names/e-select-names.c (e_select_names_hookup_shell_listener): Check if evolution_shell_client_get_local_storage returns CORBA_OBJECT_NIL, which it should never do. If it does, print a warning in a dialog and try to recover w/o crashing. (Bug #5193) svn path=/trunk/; revision=11350
* Don't stop the idle_queue and unref from here, since this might be calledDan Winship2001-07-252-11/+15
| | | | | | | | | | | | | | | | | * backend/ebook/e-book-listener.c (e_book_listener_stop): Don't stop the idle_queue and unref from here, since this might be called from inside e_book_listener_check_queue, and we don't want to return to that function with the listener having been destroyed. (e_book_listener_check_queue): Don't exit early if the queue is stopped. Proceed through the check if the queue is NULL (which is must be if the queue is stopped), and then reach the existing code to remove the idle handler. Combined with the above, this fixes ximian #4485 (again). This is not a plot to boost my showstopper-bugfixing count by fixing the same bug over and over again. svn path=/trunk/; revision=11346
* Re-fix for my 07-18 not-quite-fix.Dan Winship2001-07-245-8/+84
| | | | | | | | | | | | | | | | | | | | | * backend/ebook/e-book-listener.c: Add a "stopped" flag like EBookViewListener. (e_book_listener_check_queue): Don't emit signals if the listener is stopped. (e_book_listener_queue_generic_response, etc): Don't queue responses if the listener is stopped. (e_book_listener_stop): Flush the queue and stop queue/emitting further responses. * backend/ebook/e-book.c (e_book_unload_uri): Revert the previous change and call e_book_listener_stop() instead. * backend/ebook/e-book-view-listener.c (e_book_view_listener_stop): When removing an idle handler, unref the listener as well, since e_book_view_listener_queue_response will have ref'ed it. svn path=/trunk/; revision=11306