From d04eaa26418f68ebbe3a5a52711c72272c979399 Mon Sep 17 00:00:00 2001 From: Tobias Mueller Date: Thu, 11 Oct 2007 19:10:56 +0000 Subject: ** Fixes bug 360134 2007-10-11 Tobias Mueller ** Fixes bug 360134 * widgets/table/e-table-header-item.c: * widgets/table/e-table-field-chooser-dialog.c: * widgets/table/e-table-field-chooser-item.c: * widgets/table/e-table-field-chooser.c: * widgets/misc/e-reflow.c: Don't g_strdup strings passed to g_value_set_string since it dups the strings itself. svn path=/trunk/; revision=34377 --- ChangeLog | 12 ++++++++++++ widgets/misc/e-reflow.c | 2 +- widgets/table/e-table-field-chooser-item.c | 2 +- widgets/table/e-table-field-chooser.c | 2 +- widgets/table/e-table-header-item.c | 3 ++- 5 files changed, 17 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5d2427b352..14d168c63d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2007-10-11 Tobias Mueller + + ** Fixes bug 360134 + + * widgets/table/e-table-header-item.c: + * widgets/table/e-table-field-chooser-dialog.c: + * widgets/table/e-table-field-chooser-item.c: + * widgets/table/e-table-field-chooser.c: + * widgets/misc/e-reflow.c: + Don't g_strdup strings passed to g_value_set_string since it + dups the strings itself. + 2007-10-11 Matthew Barnes ** Fixes bug #484814 diff --git a/widgets/misc/e-reflow.c b/widgets/misc/e-reflow.c index eca5f60e6a..96c2fa8961 100644 --- a/widgets/misc/e-reflow.c +++ b/widgets/misc/e-reflow.c @@ -776,7 +776,7 @@ e_reflow_get_property (GObject *object, guint prop_id, GValue *value, GParamSpec g_value_set_double (value, reflow->height); break; case PROP_EMPTY_MESSAGE: - g_value_set_string (value, g_strdup(reflow->empty_message)); + g_value_set_string (value, reflow->empty_message); break; case PROP_MODEL: g_value_set_object (value, reflow->model); diff --git a/widgets/table/e-table-field-chooser-item.c b/widgets/table/e-table-field-chooser-item.c index 4ab694f3d6..d7da7e89da 100644 --- a/widgets/table/e-table-field-chooser-item.c +++ b/widgets/table/e-table-field-chooser-item.c @@ -370,7 +370,7 @@ etfci_get_property (GObject *object, guint prop_id, GValue *value, GParamSpec *p switch (prop_id){ case PROP_DND_CODE: - g_value_set_string (value, g_strdup (etfci->dnd_code)); + g_value_set_string (value, etfci->dnd_code); break; case PROP_WIDTH: g_value_set_double (value, etfci->width); diff --git a/widgets/table/e-table-field-chooser.c b/widgets/table/e-table-field-chooser.c index 5d2c54e840..e3031072f6 100644 --- a/widgets/table/e-table-field-chooser.c +++ b/widgets/table/e-table-field-chooser.c @@ -280,7 +280,7 @@ e_table_field_chooser_get_property (GObject *object, guint prop_id, GValue *valu switch (prop_id) { case PROP_DND_CODE: - g_value_set_string (value, g_strdup (etfc->dnd_code)); + g_value_set_string (value, etfc->dnd_code); break; case PROP_FULL_HEADER: g_value_set_object (value, etfc->full_header); diff --git a/widgets/table/e-table-header-item.c b/widgets/table/e-table-header-item.c index 51f3301f8f..41b4808db6 100644 --- a/widgets/table/e-table-header-item.c +++ b/widgets/table/e-table-header-item.c @@ -381,7 +381,7 @@ ethi_get_property (GObject *object, g_value_set_object (value, ethi->full_header); break; case PROP_DND_CODE: - g_value_set_string (value, g_strdup (ethi->dnd_code)); + g_value_set_string (value, ethi->dnd_code); break; default: G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec); @@ -1524,6 +1524,7 @@ ethi_header_context_menu (ETableHeaderItem *ethi, GdkEventButton *event) GtkWidget *menu_item, *sub_menu; ETableSortColumn column; gboolean ascending = TRUE; + d( g_print("ethi_header_context_menu: \n") ); info->ethi = ethi; info->col = ethi_find_col_by_x (ethi, event->x); -- cgit