From caa0a3d44c74e440d5de07f770583491549edb82 Mon Sep 17 00:00:00 2001 From: Milan Crha Date: Thu, 3 Jul 2008 09:32:25 +0000 Subject: ** Fix for bug #540152 2008-07-03 Milan Crha ** Fix for bug #540152 * addressbook/gui/component/addressbook-component.c: (ensure_sources): Unref source only when we created it - the list owns the pointer now. * calendar/gui/calendar-component.c: (ensure_sources): Unref sources only when we created it - the list owns the pointer now. * calendar/gui/tasks-component.c: (ensure_sources): * calendar/gui/memos-component.c: (ensure_sources): Do not leak ESource. svn path=/trunk/; revision=35717 --- addressbook/ChangeLog | 7 +++++++ addressbook/gui/component/addressbook-component.c | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) (limited to 'addressbook') diff --git a/addressbook/ChangeLog b/addressbook/ChangeLog index 650d267a79..c3432bf9d5 100644 --- a/addressbook/ChangeLog +++ b/addressbook/ChangeLog @@ -1,3 +1,10 @@ +2008-07-03 Milan Crha + + ** Fix for bug #540152 + + * gui/component/addressbook-component.c: (ensure_sources): + Unref source only when we created it - the list owns the pointer now. + 2008-06-24 Milan Crha ** Fix for bug #539755 diff --git a/addressbook/gui/component/addressbook-component.c b/addressbook/gui/component/addressbook-component.c index 55e9535840..b55cb9bd16 100644 --- a/addressbook/gui/component/addressbook-component.c +++ b/addressbook/gui/component/addressbook-component.c @@ -151,6 +151,7 @@ ensure_sources (AddressbookComponent *component) /* Create the default Person addressbook */ ESource *source = e_source_new (_("Personal"), PERSONAL_RELATIVE_URI); e_source_group_add_source (on_this_computer, source, -1); + g_object_unref (source); e_source_set_property (source, "completion", "true"); @@ -164,8 +165,7 @@ ensure_sources (AddressbookComponent *component) on_ldap_servers = group; } - if (personal_source) - g_object_unref (personal_source); + g_free (base_uri_proto); g_free (base_uri); } -- cgit