From 6dbbc8029fcde97f504d7850b36282c91b2a4dc6 Mon Sep 17 00:00:00 2001 From: Federico Mena Quintero Date: Fri, 24 Nov 2000 23:51:35 +0000 Subject: DOH, fixed reversed test for the presence of the icalcomp's parent. This 2000-11-24 Federico Mena Quintero * cal-util/cal-component.c (free_icalcomponent): DOH, fixed reversed test for the presence of the icalcomp's parent. This was causing memory leaks in the Wombat and elsewhere. * pcs/cal-backend.c (cal_backend_set_node_timet): Plug leak. svn path=/trunk/; revision=6661 --- calendar/ChangeLog | 8 ++++++++ calendar/cal-util/cal-component.c | 2 +- calendar/pcs/cal-backend.c | 1 + 3 files changed, 10 insertions(+), 1 deletion(-) (limited to 'calendar') diff --git a/calendar/ChangeLog b/calendar/ChangeLog index 68698a4f0f..f942c4d272 100644 --- a/calendar/ChangeLog +++ b/calendar/ChangeLog @@ -1,3 +1,11 @@ +2000-11-24 Federico Mena Quintero + + * cal-util/cal-component.c (free_icalcomponent): DOH, fixed + reversed test for the presence of the icalcomp's parent. This was + causing memory leaks in the Wombat and elsewhere. + + * pcs/cal-backend.c (cal_backend_set_node_timet): Plug leak. + 2000-11-24 Federico Mena Quintero * pcs/cal-backend-file.c (scan_vcalendar): Use the new libical diff --git a/calendar/cal-util/cal-component.c b/calendar/cal-util/cal-component.c index a60333589c..05c84f1233 100644 --- a/calendar/cal-util/cal-component.c +++ b/calendar/cal-util/cal-component.c @@ -211,7 +211,7 @@ free_icalcomponent (CalComponent *comp) /* Free the icalcomponent */ - if (icalcomponent_get_parent (priv->icalcomp) != NULL) + if (icalcomponent_get_parent (priv->icalcomp) == NULL) icalcomponent_free (priv->icalcomp); priv->icalcomp = NULL; diff --git a/calendar/pcs/cal-backend.c b/calendar/pcs/cal-backend.c index f4d06518c1..43895cc554 100644 --- a/calendar/pcs/cal-backend.c +++ b/calendar/pcs/cal-backend.c @@ -471,6 +471,7 @@ cal_backend_set_node_timet (xmlNodePtr node, const char *name, time_t t) tstring = g_strdup_printf ("%ld", t); xmlSetProp (node, name, tstring); + g_free (tstring); } static void -- cgit