From e14164702f1e20019996f4bbdf272843538de833 Mon Sep 17 00:00:00 2001 From: Jeffrey Stedfast Date: Fri, 17 Nov 2000 07:18:56 +0000 Subject: Use the byte-read count to decrement the number of bytes left to read 2000-11-17 Jeffrey Stedfast * providers/imap/camel-imap-command.c (imap_read_untagged): Use the byte-read count to decrement the number of bytes left to read rather than using strlen. Not only does this protect against a DoS (embedded NUL chars in the literal string would make strlen inaccurate) but it also improves performace a little. * camel-remote-store.c (remote_recv_line): *Sigh* Return the number of bytes read on success rather than 0. Also don't use camel_stream_buffer_read_line since we can't get an accurate octet count. svn path=/trunk/; revision=6599 --- camel/ChangeLog | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'camel/ChangeLog') diff --git a/camel/ChangeLog b/camel/ChangeLog index d150562199..38ec264d57 100644 --- a/camel/ChangeLog +++ b/camel/ChangeLog @@ -1,3 +1,16 @@ +2000-11-17 Jeffrey Stedfast + + * providers/imap/camel-imap-command.c (imap_read_untagged): Use + the byte-read count to decrement the number of bytes left to read + rather than using strlen. Not only does this protect against a DoS + (embedded NUL chars in the literal string would make strlen + inaccurate) but it also improves performace a little. + + * camel-remote-store.c (remote_recv_line): *Sigh* Return the + number of bytes read on success rather than 0. Also don't use + camel_stream_buffer_read_line since we can't get an accurate octet + count. + 2000-11-17 Not Zed * camel-stream-buffer.c (camel_stream_buffer_gets): We should -- cgit