From e8aa23866a44d1d93750f42a9c168bcd007eb7bb Mon Sep 17 00:00:00 2001 From: Peter Williams Date: Tue, 17 Jul 2001 21:22:20 +0000 Subject: Clean up some exception misusage. 2001-07-17 Peter Williams Clean up some exception misusage. * providers/imap/camel-imap-command.c (camel_imap_command): Use our own internal exception for sending the string and transfer it to @ex if anything goes wrong. (imap_read_response): Use our own internal exception for reading the untagged responses and blah blah blah. * camel-session.c (get_service): Use our own internal exception when constructing the service and transfer it to @ex if anything goes wrong. * camel-remote-store.c (remote_recv_line): Instead of having gboolean exception, use our own internal exception and copy it to @ex if anything goes wrong. * camel-store.c (store_sync): Create an internal exception because sync_folder() checks it for validity. Transfer it to @ex when done. * camel-exception.c (camel_exception_get_description): If @ex is NULL, complain - passing NULL exceptions to Camel is okay, but there should be no circumstances under which they're then examined. (camel_exception_get_id): Same here, (camel_exception_xfer): NULL-protect and warn if transferring from a NULL exception. svn path=/trunk/; revision=11177 --- camel/camel-store.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'camel/camel-store.c') diff --git a/camel/camel-store.c b/camel/camel-store.c index 7abefba833..23c4b82e9d 100644 --- a/camel/camel-store.c +++ b/camel/camel-store.c @@ -444,9 +444,13 @@ static void store_sync (CamelStore *store, CamelException *ex) { if (store->folders) { + CamelException internal_ex; + + camel_exception_init (&internal_ex); CAMEL_STORE_LOCK(store, cache_lock); - g_hash_table_foreach (store->folders, sync_folder, ex); + g_hash_table_foreach (store->folders, sync_folder, &internal_ex); CAMEL_STORE_UNLOCK(store, cache_lock); + camel_exception_xfer (ex, &internal_ex); } } -- cgit