From 1dcff68ce6ee20d604a1635d27a9cf443bdfcd0e Mon Sep 17 00:00:00 2001 From: Not Zed Date: Mon, 30 Sep 2002 05:06:51 +0000 Subject: Remove debug content_info_dump, could cause a crash, and not really needed 2002-09-30 Not Zed * providers/imap/camel-imap-folder.c (imap_get_message): Remove debug content_info_dump, could cause a crash, and not really needed anymore. * camel-folder-summary.c (camel_content_info_dump): Check ci->type != NULL before dereferencing it. Should fix crash #31331. svn path=/trunk/; revision=18259 --- camel/ChangeLog | 9 +++++++++ camel/camel-folder-summary.c | 7 +++++-- camel/providers/imap/camel-imap-folder.c | 2 -- 3 files changed, 14 insertions(+), 4 deletions(-) (limited to 'camel') diff --git a/camel/ChangeLog b/camel/ChangeLog index 95abd36ba9..4c3c8045e0 100644 --- a/camel/ChangeLog +++ b/camel/ChangeLog @@ -1,3 +1,12 @@ +2002-09-30 Not Zed + + * providers/imap/camel-imap-folder.c (imap_get_message): Remove + debug content_info_dump, could cause a crash, and not really + needed anymore. + + * camel-folder-summary.c (camel_content_info_dump): Check ci->type + != NULL before dereferencing it. Should fix crash #31331. + 2002-09-27 Jeffrey Stedfast * providers/imap/camel-imap-folder.c (decode_internaldate): New diff --git a/camel/camel-folder-summary.c b/camel/camel-folder-summary.c index 4eea17751a..09e75b10a5 100644 --- a/camel/camel-folder-summary.c +++ b/camel/camel-folder-summary.c @@ -2758,8 +2758,11 @@ camel_content_info_dump (CamelMessageContentInfo *ci, int depth) return; } - printf ("%scontent-type: %s/%s\n", p, ci->type->type ? ci->type->type : "(null)", - ci->type->subtype ? ci->type->subtype : "(null)"); + if (ci->type) + printf ("%scontent-type: %s/%s\n", p, ci->type->type ? ci->type->type : "(null)", + ci->type->subtype ? ci->type->subtype : "(null)"); + else + printf ("%scontent-type: \n", p); printf ("%scontent-transfer-encoding: %s\n", p, ci->encoding ? ci->encoding : "(null)"); printf ("%scontent-description: %s\n", p, ci->description ? ci->description : "(null)"); printf ("%ssize: %lu\n", p, (unsigned long) ci->size); diff --git a/camel/providers/imap/camel-imap-folder.c b/camel/providers/imap/camel-imap-folder.c index 23800bdefc..33494d975c 100644 --- a/camel/providers/imap/camel-imap-folder.c +++ b/camel/providers/imap/camel-imap-folder.c @@ -1957,8 +1957,6 @@ imap_get_message (CamelFolder *folder, const char *uid, CamelException *ex) camel_imap_response_free (store, response); - d(camel_content_info_dump (mi->content, 0)); - if (!mi->content->type) { /* FETCH returned OK, but we didn't parse a BODY * response. Courier will return invalid BODY -- cgit