From 128a31facdd7835962ad73be938a413928dc1210 Mon Sep 17 00:00:00 2001 From: Not Zed Date: Mon, 7 Feb 2005 07:02:25 +0000 Subject: Don't let the 'id' field, which identifies the target menu/whatever, to be 2005-02-07 Not Zed * e-popup.c (emph_construct_menu): * e-menu.c (emph_construct_menu): * e-config.c (emph_construct_menu): Don't let the 'id' field, which identifies the target menu/whatever, to be NULL, otherwise it gets added to all. svn path=/trunk/; revision=28728 --- e-util/e-popup.c | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'e-util/e-popup.c') diff --git a/e-util/e-popup.c b/e-util/e-popup.c index 6ce73ab2db..14bbfc6e9b 100644 --- a/e-util/e-popup.c +++ b/e-util/e-popup.c @@ -726,6 +726,11 @@ emph_construct_menu(EPluginHook *eph, xmlNodePtr root) menu->target_type = map->id; menu->id = e_plugin_xml_prop(root, "id"); + if (menu->id == NULL) { + g_warning("Plugin '%s' missing 'id' field in popup for '%s'\n", eph->plugin->name, + ((EPluginHookClass *)G_OBJECT_GET_CLASS(eph))->id); + goto error; + } node = root->children; while (node) { if (0 == strcmp(node->name, "item")) { -- cgit