From 9ec39960ad691d001ca33d65d9dbb2f31bf70cb9 Mon Sep 17 00:00:00 2001 From: Jeffrey Stedfast Date: Wed, 4 Oct 2000 22:41:05 +0000 Subject: Instead of UnSelectAll, we want InvertSelection. 2000-10-04 Jeffrey Stedfast * folder-browser-factory.c: Instead of UnSelectAll, we want InvertSelection. * mail-callbacks.c (select_all): Finished this function. (invert_selection): Finished. (was unselect_all - but that's not what we really wanted as it'd be pointless. invert_selection is a much more useful callback :-) svn path=/trunk/; revision=5725 --- mail/ChangeLog | 52 ++++++++++++++++++++++++++----------------- mail/folder-browser-factory.c | 2 +- mail/mail-callbacks.c | 13 ++++++----- mail/mail.h | 3 +-- 4 files changed, 41 insertions(+), 29 deletions(-) (limited to 'mail') diff --git a/mail/ChangeLog b/mail/ChangeLog index ffe5c73fd0..1f7fdab7b4 100644 --- a/mail/ChangeLog +++ b/mail/ChangeLog @@ -1,3 +1,13 @@ +2000-10-04 Jeffrey Stedfast + + * folder-browser-factory.c: Instead of UnSelectAll, we want + InvertSelection. + + * mail-callbacks.c (select_all): Finished this function. + (invert_selection): Finished. (was unselect_all - but that's not + what we really wanted as it'd be pointless. invert_selection is a + much more useful callback :-) + 2000-10-04 Chris Toshok * mail-tools.c (mail_tool_get_root_of_store): remove news specific @@ -5,7 +15,7 @@ (mail_tool_uri_to_folder): news: -> nntp: 2000-10-04 Jeffrey Stedfast - + * mail-ops.c (do_filter_ondemand): Don't expunge the source mailbox on completion. @@ -16,7 +26,8 @@ 2000-10-04 Not Zed - * message-list.c (message_list_init_header): Fix the attachment icon width. + * message-list.c (message_list_init_header): Fix the attachment + icon width. (content_is_attachment): Perform some simple tests to see if the message contains an attachment. (build_subtree): Kill a pointless warning. @@ -86,14 +97,16 @@ 2000-10-02 Chris Toshok - * Makefile.am (evolution_mail_SOURCES): subscribe-control.[ch] -> subscribe_dialog.[ch] + * Makefile.am (evolution_mail_SOURCES): subscribe-control.[ch] -> + subscribe_dialog.[ch] * mail-callbacks.c (manage_subscriptions): subscribe_control -> subscribe_dialog. Also, pass the shell to subscribe_dialog_new. * mail-types.h: SubscribeControl -> SubscribeDialog. - * subscribe-dialog.c, subscribe-dialog.h: rename from subscribe-control.[ch]. + * subscribe-dialog.c, subscribe-dialog.h: rename from + subscribe-control.[ch]. * subscribe-dialog.c (subscribe_dialog_construct): pass Evolution_Shell in. @@ -123,14 +136,15 @@ 2000-10-01 Iain Holmes - * mail-display.c: Generate the thumbnails on an idle function so that - the user interface isn't locked. Checks in case the widget it will - use to display the image isn't destroyed. + * mail-display.c: Generate the thumbnails on an idle function so + that the user interface isn't locked. Checks in case the widget it + will use to display the image isn't destroyed. 2000-10-01 Iain Holmes - * mail-display.c (on_object_requested): If the attachment is an image - display a thumbnail of it, instead of the generic image icon. + * mail-display.c (on_object_requested): If the attachment is an + image display a thumbnail of it, instead of the generic image + icon. 2000-09-29 Miguel de Icaza @@ -198,10 +212,9 @@ * Makefile.am (evolution_mail_SOURCES): add the subscribe stuff. - * subscribe-control-factory.h - * subscribe-control-factory.c - * subscribe-control.c: - * subscribe-control.h: Mostly mocked up subscribe ui. + * subscribe-control-factory.h * subscribe-control-factory.c * + subscribe-control.c: * subscribe-control.h: Mostly mocked up + subscribe ui. 2000-09-27 Jeffrey Stedfast Note: We need a configuration option to specify whether to log @@ -221,8 +234,8 @@ 2000-09-27 Jeffrey Stedfast * mail-ops.c (do_filter_ondemand): If the message has been - deleted, don't try filtering it - skip to the next message. - Fixes bugzilla bug #639. + deleted, don't try filtering it - skip to the next message. Fixes + bugzilla bug #639. 2000-09-25 Jeffrey Stedfast @@ -246,8 +259,8 @@ * message-list.c (folder_to_cachename): Function to convert a folder name/path to a filename for per-folder data. - (save_tree_state): - (load_tree_state): + (save_tree_state): + (load_tree_state): (free_tree_state): For loading/saving the state of the expansion of nodes in the tree. (message_list_destroy): Save the tree state when done. @@ -309,9 +322,8 @@ 2000-09-19 Dan Winship * mail-callbacks.c (create_msg_composer, compose_msg, send_to_url, - mail_reply, forward_msg): - * mail-format.c (mail_generate_reply): - * mail-ops.c (cleanup_edit_messages): + mail_reply, forward_msg): * mail-format.c (mail_generate_reply): * + mail-ops.c (cleanup_edit_messages): * mail-view.c (view_forward_msg): Deal with NULL composer. diff --git a/mail/folder-browser-factory.c b/mail/folder-browser-factory.c index d66bbb7aa3..29db6ff498 100644 --- a/mail/folder-browser-factory.c +++ b/mail/folder-browser-factory.c @@ -82,7 +82,7 @@ BonoboUIVerb verbs [] = { /* Edit Menu */ BONOBO_UI_VERB ("EditSelectAll", select_all), - BONOBO_UI_VERB ("EditUnSelectAll", unselect_all), + BONOBO_UI_VERB ("EditInvertSelection", invert_selection), /* Settings Menu */ BONOBO_UI_VERB ("SetMailFilter", filter_edit), diff --git a/mail/mail-callbacks.c b/mail/mail-callbacks.c index 1cbc1bc5a7..588c1e087a 100644 --- a/mail/mail-callbacks.c +++ b/mail/mail-callbacks.c @@ -540,26 +540,27 @@ select_all (BonoboUIHandler *uih, void *user_data, const char *path) { FolderBrowser *fb = FOLDER_BROWSER (user_data); MessageList *ml = fb->message_list; + ETableScrolled *scrolled; if (ml->folder == NULL) return; - message_list_select (ml, -1, MESSAGE_LIST_SELECT_NEXT, 0, 0); - /* FIXME: when clahey codes select all for e-table, finish this */ - /* e_table_select_all (); */ + scrolled = E_TABLE_SCROLLED (ml->etable); + e_table_select_all (scrolled->table); } void -unselect_all (BonoboUIHandler *uih, void *user_data, const char *path) +invert_selection (BonoboUIHandler *uih, void *user_data, const char *path) { FolderBrowser *fb = FOLDER_BROWSER (user_data); MessageList *ml = fb->message_list; + ETableScrolled *scrolled; if (ml->folder == NULL) return; - /* FIXME: when clahey codes select all for e-table, finish this */ - /* e_table_unselect_all (); */ + scrolled = E_TABLE_SCROLLED (ml->etable); + e_table_invert_selection (scrolled->table); } void diff --git a/mail/mail.h b/mail/mail.h index 92a059d7bd..8f548945f3 100644 --- a/mail/mail.h +++ b/mail/mail.h @@ -87,10 +87,9 @@ void edit_msg (GtkWidget *widget, gpointer user_data); void view_msg (GtkWidget *widget, gpointer user_data); void select_all (BonoboUIHandler *uih, void *user_data, const char *path); -void unselect_all (BonoboUIHandler *uih, void *user_data, const char *path); +void invert_selection (BonoboUIHandler *uih, void *user_data, const char *path); void mark_as_seen (BonoboUIHandler *uih, void *user_data, const char *path); void mark_as_unseen (BonoboUIHandler *uih, void *user_data, const char *path); - void edit_message (BonoboUIHandler *uih, void *user_data, const char *path); void view_message (BonoboUIHandler *uih, void *user_data, const char *path); void expunge_folder (BonoboUIHandler *uih, void *user_data, const char *path); -- cgit