aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThomas Huang <tmashuang@users.noreply.github.com>2017-08-18 06:52:39 +0800
committerGitHub <noreply@github.com>2017-08-18 06:52:39 +0800
commit31e5a4f050035e75a0e8c6cc48e5ead4cbccd55e (patch)
tree452ec128ddcae8bc4deafc22e53646946ecdcf56
parent5f9862c89e2357a26384e1b48ab34ba052e967a4 (diff)
parentc90ff2847f119103c58ab713dad8859cce0e92e6 (diff)
downloadtangerine-wallet-browser-31e5a4f050035e75a0e8c6cc48e5ead4cbccd55e.tar.gz
tangerine-wallet-browser-31e5a4f050035e75a0e8c6cc48e5ead4cbccd55e.tar.zst
tangerine-wallet-browser-31e5a4f050035e75a0e8c6cc48e5ead4cbccd55e.zip
Merge pull request #1942 from MetaMask/i1903-EthSignFormat
Fix "Eth Sign" format
-rw-r--r--CHANGELOG.md2
-rw-r--r--ui/app/components/pending-msg-details.js2
-rw-r--r--ui/app/components/pending-msg.js5
3 files changed, 7 insertions, 2 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 88c794652..64af1a98c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,8 @@
## Current Master
- Fix bug where some transaction submission errors would show an empty screen.
+- Fix formatting of eth_sign "Sign Message" view.
+- Add deprecation warning to eth_sign "Sign Message" view.
## 3.9.8 2017-8-16
diff --git a/ui/app/components/pending-msg-details.js b/ui/app/components/pending-msg-details.js
index 16308d121..718a22de0 100644
--- a/ui/app/components/pending-msg-details.js
+++ b/ui/app/components/pending-msg-details.js
@@ -38,7 +38,7 @@ PendingMsgDetails.prototype.render = function () {
// message data
h('.tx-data.flex-column.flex-justify-center.flex-grow.select-none', [
- h('.flex-row.flex-space-between', [
+ h('.flex-column.flex-space-between', [
h('label.font-small', 'MESSAGE'),
h('span.font-small', msgParams.data),
]),
diff --git a/ui/app/components/pending-msg.js b/ui/app/components/pending-msg.js
index b2cac164a..b7133cda8 100644
--- a/ui/app/components/pending-msg.js
+++ b/ui/app/components/pending-msg.js
@@ -18,6 +18,9 @@ PendingMsg.prototype.render = function () {
h('div', {
key: msgData.id,
+ style: {
+ maxWidth: '350px',
+ },
}, [
// header
@@ -35,7 +38,7 @@ PendingMsg.prototype.render = function () {
}, `Signing this message can have
dangerous side effects. Only sign messages from
sites you fully trust with your entire account.
- This will be fixed in a future version.`),
+ This dangerous method will be removed in a future version.`),
// message details
h(PendingTxDetails, state),