aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorkumavis <kumavis@users.noreply.github.com>2016-11-23 04:14:25 +0800
committerGitHub <noreply@github.com>2016-11-23 04:14:25 +0800
commit49a1f43736a209f4d003a1bebe35defe281296b1 (patch)
treeca121f1e43cd3cf823999449ccc04ff9b3854f4a
parentfa2f0dee285d4a9032f8a756ee8711a7fe767b76 (diff)
parentb9d73a4b8fd8aa88aa1cf51e8305db9809dd7b9d (diff)
downloadtangerine-wallet-browser-49a1f43736a209f4d003a1bebe35defe281296b1.tar.gz
tangerine-wallet-browser-49a1f43736a209f4d003a1bebe35defe281296b1.tar.zst
tangerine-wallet-browser-49a1f43736a209f4d003a1bebe35defe281296b1.zip
Merge branch 'master' into i868-estimateGasTooHigh
-rw-r--r--CHANGELOG.md3
-rw-r--r--app/scripts/metamask-controller.js2
-rw-r--r--test/unit/account-link-test.js10
-rw-r--r--ui/app/components/buy-button-subview.js6
-rw-r--r--ui/lib/account-link.js4
5 files changed, 17 insertions, 8 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 165562ad9..eb7c8a942 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,6 +1,9 @@
# Changelog
## Current Master
+- Ropsten networks now properly point to the faucet when attempting to buy ether.
+
+- Make Ropsten transactions link to etherscan correctly.
## 2.13.9 2016-11-21
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
index 5e76c5ebd..631411bed 100644
--- a/app/scripts/metamask-controller.js
+++ b/app/scripts/metamask-controller.js
@@ -364,7 +364,7 @@ module.exports = class MetamaskController {
var network = this.idStore._currentState.network
var url = `https://buy.coinbase.com/?code=9ec56d01-7e81-5017-930c-513daa27bb6a&amount=${amount}&address=${address}&crypto_currency=ETH`
- if (network === '2') {
+ if (network === '3') {
url = 'https://faucet.metamask.io/'
}
diff --git a/test/unit/account-link-test.js b/test/unit/account-link-test.js
index 39889b6be..4ea12e002 100644
--- a/test/unit/account-link-test.js
+++ b/test/unit/account-link-test.js
@@ -3,9 +3,15 @@ var linkGen = require('../../ui/lib/account-link')
describe('account-link', function() {
- it('adds testnet prefix to morden test network', function() {
+ it('adds morden prefix to morden test network', function() {
var result = linkGen('account', '2')
- assert.notEqual(result.indexOf('testnet'), -1, 'testnet injected')
+ assert.notEqual(result.indexOf('morden'), -1, 'testnet included')
+ assert.notEqual(result.indexOf('account'), -1, 'account included')
+ })
+
+ it('adds testnet prefix to ropsten test network', function() {
+ var result = linkGen('account', '3')
+ assert.notEqual(result.indexOf('testnet'), -1, 'testnet included')
assert.notEqual(result.indexOf('account'), -1, 'account included')
})
diff --git a/ui/app/components/buy-button-subview.js b/ui/app/components/buy-button-subview.js
index b564733b1..35eda647e 100644
--- a/ui/app/components/buy-button-subview.js
+++ b/ui/app/components/buy-button-subview.js
@@ -113,9 +113,9 @@ BuyButtonSubview.prototype.formVersionSubview = function () {
style: {
width: '225px',
},
- }, 'In order to access this feature please switch to the Main Network'),
- h('h3.text-transform-uppercase', 'or:'),
- this.props.network === '2' ? h('button.text-transform-uppercase', {
+ }, 'In order to access this feature, please switch to the Main Network'),
+ (this.props.network === '3') ? h('h3.text-transform-uppercase', 'or:') : null,
+ (this.props.network === '3') ? h('button.text-transform-uppercase', {
onClick: () => this.props.dispatch(actions.buyEth()),
style: {
marginTop: '15px',
diff --git a/ui/lib/account-link.js b/ui/lib/account-link.js
index a6b120c63..ff52d9c54 100644
--- a/ui/lib/account-link.js
+++ b/ui/lib/account-link.js
@@ -7,10 +7,10 @@ module.exports = function(address, network) {
link = `http://etherscan.io/address/${address}`
break
case 2: // morden test net
- link = `http://testnet.etherscan.io/address/${address}`
+ link = `http://morden.etherscan.io/address/${address}`
break
case 3: // ropsten test net
- link = ''
+ link = `http://testnet.etherscan.io/address/${address}`
break
default:
link = ''