diff options
| author | Mark Stacey <markjstacey@gmail.com> | 2019-07-05 03:18:12 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2019-07-05 03:18:12 +0800 |
| commit | ec40b2a32526a8e28b007905c1ba63395c1042b6 (patch) | |
| tree | 189fc444272bb85728b9faeecf293e1a7b66d01a /development/states/send-edit.json | |
| parent | c7608e6fe935c2b16c41bb0ff27eeeb50e8a2eb3 (diff) | |
| download | tangerine-wallet-browser-ec40b2a32526a8e28b007905c1ba63395c1042b6.tar.gz tangerine-wallet-browser-ec40b2a32526a8e28b007905c1ba63395c1042b6.tar.zst tangerine-wallet-browser-ec40b2a32526a8e28b007905c1ba63395c1042b6.zip | |
Check for invalid gas estimates from local storage (#6800)
* Remove unused state 'gas.basicPriceAndTimeEstimates'
* Check for invalid estimates from local storage
Gas estimates were being cached in local storage then later retrieved,
but the retrieved values were not being checked. If the data failed to
save, failed to load, or was cleared since being saved, it would result
in the gas estimates being set to undefined.
The estimates retrieved from local storage are now checked before they
are used. If they are falsy, the estimates are retrieved from the
network instead.
This should fix this Sentry issue:
[METAMASK-6W0T](https://sentry.io/share/issue/cfe470314a5741768b19050815322aa4/)
A few additional changes were made to the gas-duck tests to accommodate
the use of `sinon.restore`. `restore` is strongly recommended by the
`sinon` team, as neglecting to use it can result in memory leaks. It has
the additional benefit of ensuring you create fresh stubs/spies for each
test, which means they no longer need to be reset between tests.
Diffstat (limited to 'development/states/send-edit.json')
| -rw-r--r-- | development/states/send-edit.json | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/development/states/send-edit.json b/development/states/send-edit.json index df97e1ef5..b500d14bd 100644 --- a/development/states/send-edit.json +++ b/development/states/send-edit.json @@ -206,7 +206,6 @@ }, "basicEstimateIsLoading": false, "gasEstimatesLoading": false, - "basicPriceAndTimeEstimates": [], "priceAndTimeEstimates": [ { "expectedTime": "1374.1168296452973076627", |