Merge pull request #594 from MetaMask/i541-CustomMenuItemFix

Allow selecting custom rpc from menu even when custom rpc is selected

1 files changed, 9 insertions, 6 deletions

diff --git a/ui/app/app.js b/ui/app/app.js
index 70a6fcd64..b674efff1 100644
--- a/ui/app/app.js
+++ b/ui/app/app.js
@@ -249,6 +249,13 @@ App.prototype.renderNetworkDropdown = function () {
       activeNetworkRender: props.provider.rpcTarget,
     }),
 
+    h(DropMenuItem, {
+      label: 'Custom RPC',
+      closeMenu: () => this.setState({ isNetworkMenuOpen: false }),
+      action: () => this.props.dispatch(actions.showConfigPage()),
+      icon: h('i.fa.fa-question-circle.fa-lg', { ariaHidden: true }),
+    }),
+
     this.renderCustomOption(props.provider.rpcTarget),
   ])
 }
@@ -501,12 +508,8 @@ App.prototype.toggleMetamaskActive = function () {
 App.prototype.renderCustomOption = function (rpcTarget) {
   switch (rpcTarget) {
     case undefined:
-      return h(DropMenuItem, {
-        label: 'Custom RPC',
-        closeMenu: () => this.setState({ isNetworkMenuOpen: false }),
-        action: () => this.props.dispatch(actions.showConfigPage()),
-        icon: h('i.fa.fa-question-circle.fa-lg', { ariaHidden: true }),
-      })
+      return null
+
     case 'http://localhost:8545':
       return h(DropMenuItem, {
         label: 'Custom RPC',