diff options
| -rw-r--r-- | CHANGELOG.md | 1 | ||||
| -rw-r--r-- | app/scripts/lib/idStore.js | 6 | ||||
| -rw-r--r-- | app/scripts/metamask-controller.js | 1 |
3 files changed, 4 insertions, 4 deletions
diff --git a/CHANGELOG.md b/CHANGELOG.md index d7da7df7b..970ebde80 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,7 @@ ## Current Master - Show a warning when a transaction fails during simulation. - Fix bug where 20% of gas estimate was not being added properly. +- Render error messages in our confirmation screen more gracefully. ## 2.13.7 2016-11-8 diff --git a/app/scripts/lib/idStore.js b/app/scripts/lib/idStore.js index cd717df28..65b8c7029 100644 --- a/app/scripts/lib/idStore.js +++ b/app/scripts/lib/idStore.js @@ -248,7 +248,7 @@ IdentityStore.prototype.addUnconfirmedTransaction = function (txParams, onTxDone function analyzeForDelegateCall(cb){ if (txParams.to) { query.getCode(txParams.to, (err, result) => { - if (err) return cb(err) + if (err) return cb(err.message || err) var containsDelegateCall = self.checkForDelegateCall(result) txData.containsDelegateCall = containsDelegateCall cb() @@ -264,7 +264,7 @@ IdentityStore.prototype.addUnconfirmedTransaction = function (txParams, onTxDone var gasLimit = '0x3b9aca00' estimationParams.gas = gasLimit query.estimateGas(estimationParams, function(err, result){ - if (err) return cb(err) + if (err) return cb(err.message || err) if (result === estimationParams.gas) { txData.simulationFails = true query.getBlockByNumber('latest', true, function(err, block){ @@ -282,7 +282,7 @@ IdentityStore.prototype.addUnconfirmedTransaction = function (txParams, onTxDone } function didComplete (err) { - if (err) return cb(err) + if (err) return cb(err.message || err) configManager.addTx(txData) // signal update self._didUpdate() diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index da05e5f5d..5e76c5ebd 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -212,7 +212,6 @@ module.exports = class MetamaskController { newUnsignedTransaction (txParams, onTxDoneCb) { const idStore = this.idStore - let err = this.enforceTxValidations(txParams) if (err) return onTxDoneCb(err) idStore.addUnconfirmedTransaction(txParams, onTxDoneCb, (err, txData) => { |