From 2468949cb5b13b36cb11f351a13d92bdc500093c Mon Sep 17 00:00:00 2001 From: kumavis Date: Thu, 23 Jun 2016 16:53:45 -0700 Subject: some legit linting fixes --- app/scripts/lib/notifications.js | 1 + ui/lib/icon-factory.js | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/scripts/lib/notifications.js b/app/scripts/lib/notifications.js index f7d7ab6d8..5762fd26b 100644 --- a/app/scripts/lib/notifications.js +++ b/app/scripts/lib/notifications.js @@ -57,6 +57,7 @@ function createTxNotification (opts) { if (!chrome.notifications) return console.error('Chrome notifications API missing...') renderTransactionNotificationSVG(opts, function(err, source){ + if (err) throw err var imageUrl = 'data:image/svg+xml;utf8,' + encodeURIComponent(source) diff --git a/ui/lib/icon-factory.js b/ui/lib/icon-factory.js index ed9624c13..a30041114 100644 --- a/ui/lib/icon-factory.js +++ b/ui/lib/icon-factory.js @@ -32,8 +32,7 @@ IconFactory.prototype.generateIdenticonImg = function (address, diameter) { // returns svg dom element IconFactory.prototype.generateIdenticonSvg = function (address, diameter) { - var numericRepresentation = jsNumberForAddress(address) - var cacheId = address+':'+diameter + var cacheId = `${address}:${diameter}` // check cache, lazily generate and populate cache var identicon = this.cache[cacheId] || (this.cache[cacheId] = this.generateNewIdenticon(address, diameter)) // create a clean copy so you can modify it -- cgit