From 651e48dbd6a8bbcf2561d62c93897309143e2a9e Mon Sep 17 00:00:00 2001 From: kumavis Date: Tue, 27 Mar 2018 12:37:30 -0700 Subject: sentry - simplify all ethjs errors for better batching --- app/scripts/lib/setupRaven.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'app/scripts/lib/setupRaven.js') diff --git a/app/scripts/lib/setupRaven.js b/app/scripts/lib/setupRaven.js index 02c01b755..a869588d0 100644 --- a/app/scripts/lib/setupRaven.js +++ b/app/scripts/lib/setupRaven.js @@ -1,5 +1,6 @@ const Raven = require('raven-js') const METAMASK_DEBUG = 'GULP_METAMASK_DEBUG' +const extractEthjsErrorMessage = require('./extractEthjsErrorMessage') const PROD = 'https://3567c198f8a8412082d32655da2961d0@sentry.io/273505' const DEV = 'https://f59f3dd640d2429d9d0e2445a87ea8e1@sentry.io/273496' @@ -21,8 +22,12 @@ function setupRaven(opts) { const client = Raven.config(ravenTarget, { release, transport: function(opts) { - // modify report urls const report = opts.data + // simplify ethjs error messages + report.exception.values.forEach(item => { + item.value = extractEthjsErrorMessage(item.value) + }) + // modify report urls rewriteReportUrls(report) // make request normally client._makeRequest(opts) -- cgit From 97e1fcd331e9f71cfd7e2958b2b92d1914a89b07 Mon Sep 17 00:00:00 2001 From: kumavis Date: Tue, 27 Mar 2018 20:41:10 -0700 Subject: sentry - simplify error message 'Transaction Failed: known transaction' --- app/scripts/lib/setupRaven.js | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) (limited to 'app/scripts/lib/setupRaven.js') diff --git a/app/scripts/lib/setupRaven.js b/app/scripts/lib/setupRaven.js index a869588d0..b93591e65 100644 --- a/app/scripts/lib/setupRaven.js +++ b/app/scripts/lib/setupRaven.js @@ -23,10 +23,20 @@ function setupRaven(opts) { release, transport: function(opts) { const report = opts.data - // simplify ethjs error messages + // simplify certain complex error messages report.exception.values.forEach(item => { - item.value = extractEthjsErrorMessage(item.value) + let errorMessage = item.value + // simplify ethjs error messages + errorMessage = extractEthjsErrorMessage(errorMessage) + // simplify 'Transaction Failed: known transaction' + if (errorMessage.indexOf('Transaction Failed: known transaction') === 0) { + // cut the hash from the error message + errorMessage = 'Transaction Failed: known transaction' + } + // finalize + item.value = errorMessage }) + // modify report urls rewriteReportUrls(report) // make request normally -- cgit