From 1988e1e96b09a47ad5428083bb2ed38cb2d7e0a8 Mon Sep 17 00:00:00 2001 From: Whymarrh Whitby Date: Fri, 16 Nov 2018 21:24:55 -0330 Subject: ESLint fixes (#5775) * eslint . --fix * Upgrade all ESLint warnings to errors --- app/scripts/controllers/network/createInfuraClient.js | 2 +- app/scripts/controllers/transactions/tx-state-manager.js | 2 +- app/scripts/inpage.js | 8 ++++---- app/scripts/lib/ens-ipfs/resolver.js | 2 +- app/scripts/lib/ens-ipfs/setup.js | 6 +++--- app/scripts/lib/setupFetchDebugging.js | 8 ++++---- app/scripts/lib/setupSentry.js | 2 +- app/scripts/metamask-controller.js | 4 ++-- app/scripts/ui.js | 2 +- 9 files changed, 18 insertions(+), 18 deletions(-) (limited to 'app') diff --git a/app/scripts/controllers/network/createInfuraClient.js b/app/scripts/controllers/network/createInfuraClient.js index c70fa9e38..f01927bca 100644 --- a/app/scripts/controllers/network/createInfuraClient.js +++ b/app/scripts/controllers/network/createInfuraClient.js @@ -28,7 +28,7 @@ function createInfuraClient ({ network }) { return { networkMiddleware, blockTracker } } -function createNetworkAndChainIdMiddleware({ network }) { +function createNetworkAndChainIdMiddleware ({ network }) { let chainId let netId diff --git a/app/scripts/controllers/transactions/tx-state-manager.js b/app/scripts/controllers/transactions/tx-state-manager.js index 2a7f207e1..151082452 100644 --- a/app/scripts/controllers/transactions/tx-state-manager.js +++ b/app/scripts/controllers/transactions/tx-state-manager.js @@ -86,7 +86,7 @@ class TransactionStateManager extends EventEmitter { @returns {array} the tx list whos status is approved if no address is provide returns all txMetas who's status is approved for the current network */ - getApprovedTransactions(address) { + getApprovedTransactions (address) { const opts = { status: 'approved' } if (address) opts.from = address return this.getFilteredTxList(opts) diff --git a/app/scripts/inpage.js b/app/scripts/inpage.js index 83392761e..08d78e8ab 100644 --- a/app/scripts/inpage.js +++ b/app/scripts/inpage.js @@ -29,7 +29,7 @@ console.warn('ATTENTION: In an effort to improve user privacy, MetaMask ' + * @param {Function} handler - event handler * @param {boolean} remove - removes this handler after being triggered */ -function onMessage(messageType, handler, remove) { +function onMessage (messageType, handler, remove) { window.addEventListener('message', function ({ data }) { if (!data || data.type !== messageType) { return } remove && window.removeEventListener('message', handler) @@ -104,7 +104,7 @@ inpageProvider._metamask = new Proxy({ * * @returns {Promise} - Promise resolving to true if this domain has been previously approved */ - isApproved: function() { + isApproved: function () { return new Promise((resolve) => { isApprovedHandle = ({ data: { caching, isApproved } }) => { if (caching) { @@ -133,7 +133,7 @@ inpageProvider._metamask = new Proxy({ }) }, }, { - get: function(obj, prop) { + get: function (obj, prop) { !warned && console.warn('Heads up! ethereum._metamask exposes methods that have ' + 'not been standardized yet. This means that these methods may not be implemented ' + 'in other dapp browsers and may be removed from MetaMask in the future.') @@ -153,7 +153,7 @@ const proxiedInpageProvider = new Proxy(inpageProvider, { window.ethereum = proxiedInpageProvider // detect eth_requestAccounts and pipe to enable for now -function detectAccountRequest(method) { +function detectAccountRequest (method) { const originalMethod = inpageProvider[method] inpageProvider[method] = function ({ method }) { if (method === 'eth_requestAccounts') { diff --git a/app/scripts/lib/ens-ipfs/resolver.js b/app/scripts/lib/ens-ipfs/resolver.js index fe2dc1134..b98566190 100644 --- a/app/scripts/lib/ens-ipfs/resolver.js +++ b/app/scripts/lib/ens-ipfs/resolver.js @@ -38,7 +38,7 @@ async function resolveEnsToIpfsContentId ({ provider, name }) { return contentId } -function hexValueIsEmpty(value) { +function hexValueIsEmpty (value) { return [undefined, null, '0x', '0x0', '0x0000000000000000000000000000000000000000000000000000000000000000'].includes(value) } diff --git a/app/scripts/lib/ens-ipfs/setup.js b/app/scripts/lib/ens-ipfs/setup.js index 45eb1ce14..df756d0f7 100644 --- a/app/scripts/lib/ens-ipfs/setup.js +++ b/app/scripts/lib/ens-ipfs/setup.js @@ -6,7 +6,7 @@ const supportedTopLevelDomains = ['eth'] module.exports = setupEnsIpfsResolver -function setupEnsIpfsResolver({ provider }) { +function setupEnsIpfsResolver ({ provider }) { // install listener const urlPatterns = supportedTopLevelDomains.map(tld => `*://*.${tld}/*`) @@ -35,11 +35,11 @@ function setupEnsIpfsResolver({ provider }) { attemptResolve({ tabId, name, path, search }) } - async function attemptResolve({ tabId, name, path, search }) { + async function attemptResolve ({ tabId, name, path, search }) { extension.tabs.update(tabId, { url: `loading.html` }) try { const ipfsContentId = await resolveEnsToIpfsContentId({ provider, name }) - let url = `https://gateway.ipfs.io/ipfs/${ipfsContentId}${path}${search || ''}` + const url = `https://gateway.ipfs.io/ipfs/${ipfsContentId}${path}${search || ''}` try { // check if ipfs gateway has result const response = await fetch(url, { method: 'HEAD' }) diff --git a/app/scripts/lib/setupFetchDebugging.js b/app/scripts/lib/setupFetchDebugging.js index c1ef22d21..431340e2b 100644 --- a/app/scripts/lib/setupFetchDebugging.js +++ b/app/scripts/lib/setupFetchDebugging.js @@ -6,13 +6,13 @@ module.exports = setupFetchDebugging // https://github.com/getsentry/sentry-javascript/pull/1293 // -function setupFetchDebugging() { +function setupFetchDebugging () { if (!global.fetch) return const originalFetch = global.fetch global.fetch = wrappedFetch - async function wrappedFetch(...args) { + async function wrappedFetch (...args) { const initialStack = getCurrentStack() try { return await originalFetch.call(window, ...args) @@ -20,14 +20,14 @@ function setupFetchDebugging() { if (!err.stack) { console.warn('FetchDebugger - fetch encountered an Error without a stack', err) console.warn('FetchDebugger - overriding stack to point of original call') - err.stack = initialStack + err.stack = initialStack } throw err } } } -function getCurrentStack() { +function getCurrentStack () { try { throw new Error('Fake error for generating stack trace') } catch (err) { diff --git a/app/scripts/lib/setupSentry.js b/app/scripts/lib/setupSentry.js index 69042bc19..ba0e17df0 100644 --- a/app/scripts/lib/setupSentry.js +++ b/app/scripts/lib/setupSentry.js @@ -32,7 +32,7 @@ function setupSentry (opts) { scope.setExtra('isBrave', isBrave) }) - function rewriteReport(report) { + function rewriteReport (report) { try { // simplify certain complex error messages (e.g. Ethjs) simplifyErrorMessages(report) diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index 641a7ef3f..f3cd078b8 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -200,7 +200,7 @@ module.exports = class MetamaskController extends EventEmitter { this.networkController.on('networkDidChange', () => { this.balancesController.updateAllBalances() var currentCurrency = this.currencyController.getCurrentCurrency() - this.setCurrentCurrency(currentCurrency, function() {}) + this.setCurrentCurrency(currentCurrency, function () {}) }) this.balancesController.updateAllBalances() @@ -1581,7 +1581,7 @@ module.exports = class MetamaskController extends EventEmitter { /** * Locks MetaMask */ - setLocked() { + setLocked () { this.providerApprovalController.setLocked() return this.keyringController.setLocked() } diff --git a/app/scripts/ui.js b/app/scripts/ui.js index c4f6615db..444097f14 100644 --- a/app/scripts/ui.js +++ b/app/scripts/ui.js @@ -23,7 +23,7 @@ async function start () { const release = global.platform.getVersion() setupSentry({ release, getState }) // provide app state to append to error logs - function getState() { + function getState () { // get app state const state = window.getCleanAppState() // remove unnecessary data -- cgit