From 9cb600e17ab43f897abfd874d70ca72221437b9c Mon Sep 17 00:00:00 2001
From: Kevin Serrano <kevgagser@gmail.com>
Date: Tue, 6 Sep 2016 10:24:31 -0700
Subject: Redirect to video in a new tab on fresh install.

---
 app/scripts/background.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

(limited to 'app')

diff --git a/app/scripts/background.js b/app/scripts/background.js
index 5dae8235f..91c09629c 100644
--- a/app/scripts/background.js
+++ b/app/scripts/background.js
@@ -35,6 +35,12 @@ function showUnconfirmedTx (txParams, txData, onTxDoneCb) {
   notification.show()
 }
 
+// On first install, open a window to MetaMask website to how-it-works.
+
+chrome.runtime.onInstalled.addListener(function (object) {
+  chrome.tabs.create({url: 'https://metamask.io/#how-it-works'})
+})
+
 //
 // connect to other contexts
 //
@@ -160,4 +166,3 @@ function getOldStyleData () {
 function setData (data) {
   window.localStorage[STORAGE_KEY] = JSON.stringify(data)
 }
-
-- 
cgit 


From 50f0624ea800b0b763f577171e451495c16cd6e9 Mon Sep 17 00:00:00 2001
From: Kevin Serrano <kevgagser@gmail.com>
Date: Tue, 6 Sep 2016 10:27:11 -0700
Subject: Replace chrome with generalized browser API.

---
 app/scripts/background.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'app')

diff --git a/app/scripts/background.js b/app/scripts/background.js
index 91c09629c..21a5eea65 100644
--- a/app/scripts/background.js
+++ b/app/scripts/background.js
@@ -37,8 +37,8 @@ function showUnconfirmedTx (txParams, txData, onTxDoneCb) {
 
 // On first install, open a window to MetaMask website to how-it-works.
 
-chrome.runtime.onInstalled.addListener(function (object) {
-  chrome.tabs.create({url: 'https://metamask.io/#how-it-works'})
+extension.runtime.onInstalled.addListener(function (object) {
+  extension.tabs.create({url: 'https://metamask.io/#how-it-works'})
 })
 
 //
-- 
cgit 


From bfea26d3e3d12de6ce9bbc01ad24a42d846021e5 Mon Sep 17 00:00:00 2001
From: Dan Finlay <dan@danfinlay.com>
Date: Tue, 6 Sep 2016 18:56:26 -0700
Subject: Ensure listener is cleaned up

Also fixed bug when validating a tx with no value.
---
 app/scripts/background.js           |  1 +
 app/scripts/lib/listener-manager.js | 25 +++++++++++++++++++++++++
 app/scripts/metamask-controller.js  |  2 +-
 3 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 app/scripts/lib/listener-manager.js

(limited to 'app')

diff --git a/app/scripts/background.js b/app/scripts/background.js
index 21a5eea65..18aaed7bf 100644
--- a/app/scripts/background.js
+++ b/app/scripts/background.js
@@ -86,6 +86,7 @@ function setupControllerConnection (stream) {
   stream.pipe(dnode).pipe(stream)
   dnode.on('remote', (remote) => {
     // push updates to popup
+    controller.ethStore.removeListener('update', controller.sendUpdate.bind(controller))
     controller.ethStore.on('update', controller.sendUpdate.bind(controller))
     controller.listeners.push(remote)
     idStore.on('update', controller.sendUpdate.bind(controller))
diff --git a/app/scripts/lib/listener-manager.js b/app/scripts/lib/listener-manager.js
new file mode 100644
index 000000000..9e3c71afc
--- /dev/null
+++ b/app/scripts/lib/listener-manager.js
@@ -0,0 +1,25 @@
+module.exports = class ListenerManager {
+
+  constructor() {
+    this.cleaners = {}
+  }
+
+  setup (name) {
+    if (!(name in this.cleaners)) {
+      this.cleaners[name] = []
+    }
+  }
+
+  addCleanup (name, cleaner) {
+    this.setup(name)
+  }
+
+  cleanupOldListeners (name) {
+    this.setup(name)
+    this.cleaners[name].forEach((cleaner) => {
+      cleaner()
+    })
+    this.cleaners[name] = []
+  }
+
+}
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
index 83827ec76..5373cf0d9 100644
--- a/app/scripts/metamask-controller.js
+++ b/app/scripts/metamask-controller.js
@@ -220,7 +220,7 @@ module.exports = class MetamaskController {
   }
 
   enforceTxValidations (txParams) {
-    if (txParams.value.indexOf('-') === 0) {
+    if (('value' in txParams) && txParams.value.indexOf('-') === 0) {
       const msg = `Invalid transaction value of ${txParams.value} not a positive number.`
       return new Error(msg)
     }
-- 
cgit 


From 2564c0c51c39e428540e38b80558e45ec44357a8 Mon Sep 17 00:00:00 2001
From: Dan Finlay <dan@danfinlay.com>
Date: Tue, 6 Sep 2016 18:57:18 -0700
Subject: Bump changelog

---
 app/scripts/lib/listener-manager.js | 25 -------------------------
 1 file changed, 25 deletions(-)
 delete mode 100644 app/scripts/lib/listener-manager.js

(limited to 'app')

diff --git a/app/scripts/lib/listener-manager.js b/app/scripts/lib/listener-manager.js
deleted file mode 100644
index 9e3c71afc..000000000
--- a/app/scripts/lib/listener-manager.js
+++ /dev/null
@@ -1,25 +0,0 @@
-module.exports = class ListenerManager {
-
-  constructor() {
-    this.cleaners = {}
-  }
-
-  setup (name) {
-    if (!(name in this.cleaners)) {
-      this.cleaners[name] = []
-    }
-  }
-
-  addCleanup (name, cleaner) {
-    this.setup(name)
-  }
-
-  cleanupOldListeners (name) {
-    this.setup(name)
-    this.cleaners[name].forEach((cleaner) => {
-      cleaner()
-    })
-    this.cleaners[name] = []
-  }
-
-}
-- 
cgit