From ec40b2a32526a8e28b007905c1ba63395c1042b6 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Thu, 4 Jul 2019 16:18:12 -0300 Subject: Check for invalid gas estimates from local storage (#6800) * Remove unused state 'gas.basicPriceAndTimeEstimates' * Check for invalid estimates from local storage Gas estimates were being cached in local storage then later retrieved, but the retrieved values were not being checked. If the data failed to save, failed to load, or was cleared since being saved, it would result in the gas estimates being set to undefined. The estimates retrieved from local storage are now checked before they are used. If they are falsy, the estimates are retrieved from the network instead. This should fix this Sentry issue: [METAMASK-6W0T](https://sentry.io/share/issue/cfe470314a5741768b19050815322aa4/) A few additional changes were made to the gas-duck tests to accommodate the use of `sinon.restore`. `restore` is strongly recommended by the `sinon` team, as neglecting to use it can result in memory leaks. It has the additional benefit of ensuring you create fresh stubs/spies for each test, which means they no longer need to be reset between tests. --- development/states/confirm-new-ui.json | 1 - 1 file changed, 1 deletion(-) (limited to 'development/states/confirm-new-ui.json') diff --git a/development/states/confirm-new-ui.json b/development/states/confirm-new-ui.json index dfa4170bb..c7c0b0893 100644 --- a/development/states/confirm-new-ui.json +++ b/development/states/confirm-new-ui.json @@ -202,7 +202,6 @@ }, "basicEstimateIsLoading": false, "gasEstimatesLoading": false, - "basicPriceAndTimeEstimates": [], "priceAndTimeEstimates": [ { "expectedTime": "1374.1168296452973076627", -- cgit