From aac810b1eb3414c907010c30537b7014f303d20f Mon Sep 17 00:00:00 2001 From: Kevin Serrano Date: Thu, 21 Jul 2016 08:47:03 -0700 Subject: Progress on config manager. Plus tests. --- test/unit/config-manager-test.js | 82 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 81 insertions(+), 1 deletion(-) (limited to 'test') diff --git a/test/unit/config-manager-test.js b/test/unit/config-manager-test.js index 8974a6bc5..cf8362108 100644 --- a/test/unit/config-manager-test.js +++ b/test/unit/config-manager-test.js @@ -3,6 +3,7 @@ const extend = require('xtend') const STORAGE_KEY = 'metamask-persistance-key' var configManagerGen = require('../lib/mock-config-manager') var configManager +const rp = require('request-promise') describe('config-manager', function() { @@ -11,6 +12,86 @@ describe('config-manager', function() { configManager = configManagerGen() }) + describe('currency conversions', function() { + + describe('#getCurrentFiat', function() { + it('should return false if no previous key exists', function() { + var result = configManager.getCurrentFiat() + assert.ok(!result) + }) + }) + + describe('#setCurrentFiat', function() { + it('should make getCurrentFiat return true once set', function() { + assert.equal(configManager.getCurrentFiat(), false) + configManager.setCurrentFiat('usd') + var result = configManager.getCurrentFiat() + assert.equal(result, 'usd') + }) + + it('should work with other currencies as well', function() { + assert.equal(configManager.getCurrentFiat(), false) + configManager.setCurrentFiat('jpy') + var result = configManager.getCurrentFiat() + assert.equal(result, 'jpy') + }) + }) + + describe('#getConversionRate', function() { + it('should return false if non-existent', function() { + var result = configManager.getConversionRate() + assert.ok(!result) + }) + }) + + describe('#setConversionRate', function() { + it('should retrieve an update for ETH to USD and set it in memory', function(done) { + this.timeout(15000) + assert.equal(configManager.getConversionRate(), false) + var promise = new Promise( + function (resolve, reject) { + configManager.setCurrentFiat('usd') + configManager.setConversionRate().then(function() { + resolve() + }) + }) + + promise.then(function() { + var result = configManager.getConversionRate() + assert.equal(typeof result, 'number') + done() + }).catch(function(err) { + console.log(err) + }) + + }) + + it('should work for JPY as well.', function() { + this.timeout(15000) + assert.equal(configManager.getConversionRate(), false) + var promise = new Promise( + function (resolve, reject) { + configManager.setCurrentFiat('jpy') + configManager.setConversionRate().then(function() { + resolve() + }) + }) + + promise.then(function() { + var result = configManager.getConversionRate() + assert.equal(typeof result, 'number') + done() + }).catch(function(err) { + console.log(err) + }) + }) + + xit('should activate every time the currency is changed.', function() { + + }) + }) + }) + describe('confirmation', function() { describe('#getConfirmed', function() { @@ -215,4 +296,3 @@ describe('config-manager', function() { }) }) }) - -- cgit From a612fcee64422ca43c470d7832a263f5e490611d Mon Sep 17 00:00:00 2001 From: Kevin Serrano Date: Thu, 21 Jul 2016 16:44:50 -0700 Subject: Change function names. Add interval polling for api. Refactor functions. --- test/unit/config-manager-test.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'test') diff --git a/test/unit/config-manager-test.js b/test/unit/config-manager-test.js index cf8362108..eba663975 100644 --- a/test/unit/config-manager-test.js +++ b/test/unit/config-manager-test.js @@ -44,14 +44,14 @@ describe('config-manager', function() { }) }) - describe('#setConversionRate', function() { + describe('#updateConversionRate', function() { it('should retrieve an update for ETH to USD and set it in memory', function(done) { this.timeout(15000) assert.equal(configManager.getConversionRate(), false) var promise = new Promise( function (resolve, reject) { configManager.setCurrentFiat('usd') - configManager.setConversionRate().then(function() { + configManager.updateConversionRate().then(function() { resolve() }) }) @@ -72,7 +72,7 @@ describe('config-manager', function() { var promise = new Promise( function (resolve, reject) { configManager.setCurrentFiat('jpy') - configManager.setConversionRate().then(function() { + configManager.updateConversionRate().then(function() { resolve() }) }) -- cgit From daba8e87bbb02612581991b3a3ff5adbfab551da Mon Sep 17 00:00:00 2001 From: Kevin Serrano Date: Tue, 16 Aug 2016 10:50:03 -0700 Subject: Remove extra test. --- test/unit/config-manager-test.js | 4 ---- 1 file changed, 4 deletions(-) (limited to 'test') diff --git a/test/unit/config-manager-test.js b/test/unit/config-manager-test.js index eba663975..6eeaa7c51 100644 --- a/test/unit/config-manager-test.js +++ b/test/unit/config-manager-test.js @@ -85,10 +85,6 @@ describe('config-manager', function() { console.log(err) }) }) - - xit('should activate every time the currency is changed.', function() { - - }) }) }) -- cgit From 666f3cd66ce56013e5688d514e3c1fc3ec8a6ac4 Mon Sep 17 00:00:00 2001 From: Kevin Serrano Date: Tue, 16 Aug 2016 15:11:40 -0700 Subject: Added compliance for tests and properly accounts for N/A conversions. --- test/unit/config-manager-test.js | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'test') diff --git a/test/unit/config-manager-test.js b/test/unit/config-manager-test.js index 6eeaa7c51..b34089163 100644 --- a/test/unit/config-manager-test.js +++ b/test/unit/config-manager-test.js @@ -24,16 +24,16 @@ describe('config-manager', function() { describe('#setCurrentFiat', function() { it('should make getCurrentFiat return true once set', function() { assert.equal(configManager.getCurrentFiat(), false) - configManager.setCurrentFiat('usd') + configManager.setCurrentFiat('USD') var result = configManager.getCurrentFiat() - assert.equal(result, 'usd') + assert.equal(result, 'USD') }) it('should work with other currencies as well', function() { assert.equal(configManager.getCurrentFiat(), false) - configManager.setCurrentFiat('jpy') + configManager.setCurrentFiat('JPY') var result = configManager.getCurrentFiat() - assert.equal(result, 'jpy') + assert.equal(result, 'JPY') }) }) @@ -50,7 +50,7 @@ describe('config-manager', function() { assert.equal(configManager.getConversionRate(), false) var promise = new Promise( function (resolve, reject) { - configManager.setCurrentFiat('usd') + configManager.setCurrentFiat('USD') configManager.updateConversionRate().then(function() { resolve() }) @@ -71,7 +71,7 @@ describe('config-manager', function() { assert.equal(configManager.getConversionRate(), false) var promise = new Promise( function (resolve, reject) { - configManager.setCurrentFiat('jpy') + configManager.setCurrentFiat('JPY') configManager.updateConversionRate().then(function() { resolve() }) @@ -80,7 +80,6 @@ describe('config-manager', function() { promise.then(function() { var result = configManager.getConversionRate() assert.equal(typeof result, 'number') - done() }).catch(function(err) { console.log(err) }) -- cgit