From 4196b16f06a45d5ebfbf8599cc2f96c9b690e29b Mon Sep 17 00:00:00 2001 From: Bobby Dresser Date: Mon, 11 Jun 2018 14:28:57 -0700 Subject: add help link to eth_sign warning --- ui/app/components/signature-request.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) (limited to 'ui/app/components/signature-request.js') diff --git a/ui/app/components/signature-request.js b/ui/app/components/signature-request.js index ab780dcf4..2a3e929fe 100644 --- a/ui/app/components/signature-request.js +++ b/ui/app/components/signature-request.js @@ -178,7 +178,14 @@ SignatureRequest.prototype.renderBody = function () { rows = data } else if (type === 'eth_sign') { rows = [{ name: this.context.t('message'), value: data }] - notice = this.context.t('signNotice') + notice = [this.context.t('signNotice'), + h('span.request-signature__help-link', { + onClick: () => { + global.platform.openWindow({ + url: 'https://consensys.zendesk.com/hc/en-us/articles/360004427792', + }) + }, + }, this.context.t('learnMore'))] } return h('div.request-signature__body', {}, [ -- cgit From 1ff29c5b4aa305c6dc59736791a1dce642ae3991 Mon Sep 17 00:00:00 2001 From: Koh Wei Jie Date: Fri, 22 Jun 2018 16:38:54 +0800 Subject: fixed blank boolean field for typed signing for new UI --- ui/app/components/signature-request.js | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'ui/app/components/signature-request.js') diff --git a/ui/app/components/signature-request.js b/ui/app/components/signature-request.js index 2a3e929fe..79f2f42d1 100644 --- a/ui/app/components/signature-request.js +++ b/ui/app/components/signature-request.js @@ -204,6 +204,10 @@ SignatureRequest.prototype.renderBody = function () { h('div.request-signature__rows', [ ...rows.map(({ name, value }) => { + console.log(value) + if (typeof value === 'boolean') { + value = value.toString() + } return h('div.request-signature__row', [ h('div.request-signature__row-title', [`${name}:`]), h('div.request-signature__row-value', value), -- cgit From cd90e8a869eca9edc183b142e9a7d811e7c46e57 Mon Sep 17 00:00:00 2001 From: Koh Wei Jie Date: Fri, 22 Jun 2018 16:46:00 +0800 Subject: removed stray console.log --- ui/app/components/signature-request.js | 1 - 1 file changed, 1 deletion(-) (limited to 'ui/app/components/signature-request.js') diff --git a/ui/app/components/signature-request.js b/ui/app/components/signature-request.js index 79f2f42d1..bbb340fcf 100644 --- a/ui/app/components/signature-request.js +++ b/ui/app/components/signature-request.js @@ -204,7 +204,6 @@ SignatureRequest.prototype.renderBody = function () { h('div.request-signature__rows', [ ...rows.map(({ name, value }) => { - console.log(value) if (typeof value === 'boolean') { value = value.toString() } -- cgit