From 04cc98d8e4155246b1be5ffd5404440d4799736b Mon Sep 17 00:00:00 2001 From: Dan Miller Date: Mon, 10 Dec 2018 14:00:50 -0330 Subject: Clean up for the loading-network-screen --- ui/app/components/loading-network-screen/index.js | 3 +- .../loading-network-screen.component.js | 53 ++++++++++------------ ui/app/selectors.js | 1 - 3 files changed, 24 insertions(+), 33 deletions(-) (limited to 'ui') diff --git a/ui/app/components/loading-network-screen/index.js b/ui/app/components/loading-network-screen/index.js index 9d0612f26..726b4b530 100644 --- a/ui/app/components/loading-network-screen/index.js +++ b/ui/app/components/loading-network-screen/index.js @@ -1,2 +1 @@ -const LoadingNetworksScreen = require('./loading-network-screen.container') -module.exports = LoadingNetworksScreen +export { default } from './loading-network-screen.container' diff --git a/ui/app/components/loading-network-screen/loading-network-screen.component.js b/ui/app/components/loading-network-screen/loading-network-screen.component.js index 98abf6bd2..bf1c141e0 100644 --- a/ui/app/components/loading-network-screen/loading-network-screen.component.js +++ b/ui/app/components/loading-network-screen/loading-network-screen.component.js @@ -1,23 +1,31 @@ -import React, { Component } from 'react' +import React, { PureComponent } from 'react' import PropTypes from 'prop-types' import Spinner from '../spinner' import Button from '../button' -class LoadingNetworkScreen extends Component { - constructor (props) { - super(props) - - this.state = { - showErrorScreen: false, - } +export default class LoadingNetworkScreen extends PureComponent { + state = { + showErrorScreen: false, } static contextTypes = { t: PropTypes.func, } - componentWillMount = () => { - this.cancelCallTimeout = setTimeout(this.cancelCall, this.props.cancelTime || 3000) + static propTypes = { + loadingMessage: PropTypes.string, + cancelTime: PropTypes.number, + provider: PropTypes.oneOfType([PropTypes.string, PropTypes.object]), + providerId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]), + showNetworkDropdown: PropTypes.func, + setProviderArgs: PropTypes.array, + lastSelectedProvider: PropTypes.oneOfType([PropTypes.string, PropTypes.object]), + setProviderType: PropTypes.func, + isLoadingNetwork: PropTypes.bool, + } + + componentDidMount = () => { + this.cancelCallTimeout = setTimeout(this.cancelCall, this.props.cancelTime || 15000) } getConnectingLabel = function (loadingMessage) { @@ -60,7 +68,7 @@ class LoadingNetworkScreen extends Component { return
😞 - Oops! Something went wrong. + { this.context.t('somethingWentWrong') }
@@ -101,7 +109,7 @@ class LoadingNetworkScreen extends Component { if (provider.type !== prevProvider.type) { window.clearTimeout(this.cancelCallTimeout) this.setState({ showErrorScreen: false }) - this.cancelCallTimeout = setTimeout(this.cancelCall, this.props.cancelTime || 3000) + this.cancelCallTimeout = setTimeout(this.cancelCall, this.props.cancelTime || 15000) } } @@ -128,18 +136,3 @@ class LoadingNetworkScreen extends Component { ) } } - -LoadingNetworkScreen.propTypes = { - loadingMessage: PropTypes.string, - cancelTime: PropTypes.number, - provider: PropTypes.oneOfType([PropTypes.string, PropTypes.object]), - providerId: PropTypes.oneOfType([PropTypes.string, PropTypes.number]), - showNetworkDropdown: PropTypes.func, - setProviderArgs: PropTypes.array, - lastSelectedProvider: PropTypes.oneOfType([PropTypes.string, PropTypes.object]), - setProviderType: PropTypes.func, - isLoadingNetwork: PropTypes.bool, - -} - -module.exports = LoadingNetworkScreen diff --git a/ui/app/selectors.js b/ui/app/selectors.js index 10bf63975..f1ef41f28 100644 --- a/ui/app/selectors.js +++ b/ui/app/selectors.js @@ -45,7 +45,6 @@ function getNetworkIdentifier (state) { const { metamask: { provider: { type, nickname, rpcTarget } } } = state return nickname || rpcTarget || type - } function getSelectedAddress (state) { -- cgit