# Welcome to MetaMask!
If you're submitting code to MetaMask, there are some simple things we'd appreciate you doing to help us stay organized!
## Submitting pull requests
Before taking the time to code and implement something, feel free to open an issue and discuss it! There may even be an issue already open, and together we may come up with a specific strategy before you take your precious time to write code.
### Tests
For any new programmatic functionality, we like unit tests when possible, so if you can keep your code cleanly isolated, please do add a test file to the `tests` folder.
### PR Format
We use [waffle](https://waffle.io/) for project management, and it will automatically keep us organized if you do one simple thing:
If this PR closes the issue, add the line `Fixes #$ISSUE_NUMBER`. Ex. For closing issue 418, include the line `Fixes #418`.
If it doesn't close the issue but addresses it partially, just include a reference to the issue number, like `#418`.
## Before Merging
Make sure you get a `:thumbsup`, `:+1`, or `LGTM` from another collaborator before merging.
## Before Closing Issues
Make sure the relevant code has been reviewed and merged.
### Developing inside a node_modules folder
First make sure you are comfortable with [how require works](https://github.com/maxogden/art-of-node#how-require-works) in node.
We recommend creating a folder somewhere manually called `node_modules`. For example in `~/code/node_modules`. Clone all of your git copies of modules that you want to work on into here, so for example:
- `~/code/node_modules/dat`
- `~/code/node_modules/hyperdrive`
When you run `npm install` inside of `~/code/node_modules/dat`, dat will get its own copy of `hyperdrive` (one if its dependencies) inside `~/code/node_modules/dat/node_modules`. However, if you encounter a bug in hyperdrive that you need to fix, but you want to test your fix in dat, you want dat to use your git copy of hyperdrive at `~/code/node_modules/hyperdrive` and not the npm copy of hyperdrive at `~/code/node_modules/dat/node_modules/hyperdrive`.
How do you get dat to use the git copy of hyperdrive? Just delete the npm copy!
```
rm -rf ~/code/node_modules/dat/node_modules/hyperdrive
```
Now when you run dat, and it tries to `require('hyperdrive')` it first looks in its own `node_modules` folder at `~/code/node_modules/dat/node_modules` but doesnt find hyperdrive. So it goes up to `~/code/node_modules` and finds `hyperdrive` there and uses that one, your git copy.
If you want to switch back to an npm copy, just run `npm install` inside `~/code/node_modules/dat/` and npm will download any missing modules into `~/code/node_modules/dat/node_modules` but wont touch anything in `~/code/node_modules`.
This might seem a bit complicated at first, but is simple once you get the hang of it. Here are some rules to help you get started:
- Never make any meaningful edits to code inside an "npm-managed" node_modules folder (such as `~/code/node_modules/dat/node_modules`), because when you run `npm install` inside those folders it could inadvertently delete all of your edits when installing an updated copy of a module. This has happened to me many times, so I just always use my git copy and delete the npm copy (as described above) to make edits to a module.
- You should never need to run any npm commands in terminal when at your "manually managed"" node_modules folder at `~/code/node_modules`. Never running npm commands at that folder also prevents npm from accidentally erasing your git copies of modules
- The location of your "manually managed" node_modules folder should be somewhere isolated from your normal require path. E.g. if you put it at `~/node_modules`, then when you run `npm install dat` at `~/Desktop` npm might decide to erase your git copy of dat at `~/node_modules/dat` and replace it with a copy from npm, which could make you lose work. Putting your manually managed `node_modules` folder in a sub-folder like `~/code` gets it "out of the way" and prevents accidents like that from happening.
_32_1&id=493d0ed9a32c3c0a3d7761049b9e746273a5cbe3'> ** Fix for bug #325882| Srinivasa Ragavan | 2007-06-18 | 4 | -3/+12 |
| |
|
|
| |
svn path=/trunk/; revision=33694
|
| |
|
|
|
|
|
|
|
|
| |
2007-06-17 Tobias Mueller <tobiasmue@svn.gnome.org>
* evolution-test-component.c:
removed createControls stuff. Fixes #444289
svn path=/trunk/; revision=33683
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-06-15 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #447727
* po/POTFILES.in: Remove e-clipped-label.c
* mail/mail-send-recv.c:
* shell/e-shell-folder-title-bar.c:
* widgets/misc/e-info-label.c:
* widgets/misc/e-multi-config-dialog.c:
* widgets/misc/e-task-bar.c:
Use ellipsized GtkLabels instead of EClippedLabels.
* widgets/misc/e-clipped-label.[ch]:
Remove these files. GTK+ provides this functionality now.
* widgets/misc/Makefile.am:
Remove e-clipped-label.[ch].
svn path=/trunk/; revision=33680
|
| |
|
|
| |
svn path=/trunk/; revision=33647
|
| |
|
|
| |
svn path=/trunk/; revision=33646
|
| |
|
|
| |
svn path=/trunk/; revision=33642
|
| |
|
|
| |
svn path=/trunk/; revision=33627
|
| |
|
|
| |
svn path=/trunk/; revision=33598
|
| |
|
|
|
|
|
|
|
|
| |
2007-05-13 Matthew Barnes <mbarnes@redhat.com>
* e-shell.c (impl_Shell_handleURI):
Revert the change from 2007-05-11. (#407104)
svn path=/trunk/; revision=33523
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-05-12 Matthew Barnes <mbarnes@redhat.com>
** Fixes part of bug #337616
* Makefile.am:
Add --disable-scrollkeeper to DISTCHECK_CONFIGURE_FLAGS.
* addressbook/Makefile.am:
* calendar/gui/Makefile.am:
* mail/Makefile.am:
* plugins/bogo-junk-plugins/Makefile.am:
* plugins/default-mailer/Makefile.am:
* shell/Makefile.am:
Add $(schema_DATA) to DISTCLEANFILES.
* plugins/bogo-junk-plugins/org-gnome-bogo-junk-plugin.eplug.in:
Rename as org-gnome-bogo-junk-plugin.eplug.xml.
* plugins/caldav/Makefile.am:
* plugins/import-ics-attachments/Makefile.am:
* plugins/publish-calendar/Makefile.am:
Add "eplug" file to CLEANFILES.
* plugins/mail-remote/Makefile.am:
Add "eplug.xml" file to EXTRA_DIST.
* po/POTFILES.in: Don't translate files we no longer ship.
svn path=/trunk/; revision=33521
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
2007-05-11 Matthew Barnes <mbarnes@redhat.com>
* e-shell.c (impl_Shell_handleURI):
Create a shell window if the schema or an alias was found.
Previously this only opened a window if an alias was found
but not the schema. Makes the GNOME Clock applet able to
correctly start Evolution once again. (#407104)
svn path=/trunk/; revision=33514
|
| |
|
|
|
|
|
|
|
|
| |
2007-05-01 Matthew Barnes <mbarnes@redhat.com>
* shell/main.c (show_development_warning):
Bump stable version recommendation from 2.8.1 to 2.10.1.
svn path=/trunk/; revision=33468
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
2007-04-24 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #433005 (patch from Daniel Gryniewicz)
* shell/main.c: #include <gtk/gtkcheckbutton.h>
* widgets/misc/e-task-widget.c: #include "e-spinner.h"
svn path=/trunk/; revision=33455
|
| |
|
|
| |
svn path=/trunk/; revision=33446
|
| |
|
|
| |
svn path=/trunk/; revision=33444
|
| |
|
|
| |
svn path=/trunk/; revision=33438
|
| |
|
|
| |
svn path=/trunk/; revision=33432
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-03-29 Matthew Barnes <mbarnes@redhat.com>
* calendar/gui/e-day-view.c:
* calendar/gui/e-week-view.c:
* calendar/gui/tasks-control.c:
* composer/e-msg-composer-select-file.c:
* mail/em-account-editor.c:
* mail/em-folder-view.c:
* mail/em-format-html-display.c:
* mail/em-format-html.c:
* mail/em-format.h:
* mail/em-mailer-prefs.c:
* mail/em-vfolder-rule.c:
* mail/mail-ops.c:
* mail/mail-send-recv.c:
* mail/message-list.c:
* plugins/bbdb/gaimbuddies.c:
* plugins/itip-formatter/itip-formatter.c:
* plugins/save-calendar/save-calendar.c:
* shell/e-shell-window.c:
* widgets/misc/e-icon-entry.c:
* widgets/table/e-table-header-utils.c:
* widgets/table/e-table-item.c:
* widgets/table/e-tree-header-item.c:
* widgets/table/e-tree-table-adapter.c:
Fix "incompatible pointer type" warnings (#360619).
svn path=/trunk/; revision=33339
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-03-20 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #419524
* Include <glib/gi18n.h> instead of <libgnome/gnome-i18n.h>.
* e-util/e-xml-utils.c (e_xml_get_child_by_name_by_lang_list):
* mail/em-migrate.c (emm_setup_initial):
* shell/e-component-registry.c (query_components):
* shell/e-shell-settings-dialog.c (load_pages):
* shell/e-shell-window-commands.c (command_quick_reference):
* tools/killev.c (main):
Use g_get_language_names() instead of gnome_i18n_get_language_list().
* e-util/e-util.c: Remove e_gettext().
* e-util/Makefile.am: Remove e-i18n.h.
svn path=/trunk/; revision=33319
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-03-20 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #419469 - Miscellaneous main.c cleanups
* shell/main.c (kill_dataserver): Kill evolution-data-server-1.8.
* shell/main.c (show_development_warning): Call gtk_dialog_run()
instead of listening for a "response" signal. Pass the checkbox
state back to main() and let main() set the "show_dialog_warning"
GConf key.
* shell/main.c (open_uris), (idle_cb), (main): Use the
remaining_args string vector directly instead of needlessly
building a GSList out of it.
* shell/main.c (main): Manage a reference to the default GConf
client and pass it to the functions that need it.
svn path=/trunk/; revision=33318
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-03-16 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #360240
* addressbook/gui/widgets/e-addressbook-view.c
(e_contact_print_button):
* addressbook/printing/e-contact-print.c (complete_sequence),
(e_contact_build_style), (e_contact_print_response),
(e_contact_print_contact_list_dialog_new):
* shell/e-shell-importer.c (importer_file_page_new):
* plugins/startup-wizard/startup-wizard.c
(startup_wizard_timezone_page):
* mail/em-vfolder-rule.c (select_source_with_changed), (get_widget):
* mail/em-format-quote.c (emfq_format_source):
* mail/mail-ops.c (save_messages_save):
* mail/em-format.c (emf_init):
* mail/em-format-html-display (em_format_html_get_search_dialog),
(em_format_html_display_seearch_with), (ehhd_resize),
(efhd_attachment_optional), (efhd_format_optional):
* mail/em-folder-view.c (emfv_init):
* mail/message-list.c (ml_tree_value_at):
* composer/e-msg-composer-hdrs (header_new_recipient):
* composer/e-msg-composer.c (e_msg_composer_show_help), (drop_action):
* widgets/table/e-cell-text.c (ect_free_color):
* widgets/misc/e-calendar-item.c (e_calendar_item_unrealize):
* widgets/misc/e-icon-entry.c (e_icon_entry_pack_widget):
Remove unused variables.
svn path=/trunk/; revision=33315
|
| |
|
|
|
|
|
|
|
| |
2007-03-12 Harish Krishnaswamy <kharish@novell.com>
* e-shell-window-commands.c : Update contributors' list for
credits.
svn path=/trunk/; revision=33307
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
2007-02-12 Matthew Barnes <mbarnes@redhat.com>
** Fixes bug #360946
shell/e-shell-window-commands.c (command_about): Migrate to
GtkAboutDialog, use "evolution" for the icon name, add a website link.
shell/main.c (main): Set default window icon name to "evolution".
svn path=/trunk/; revision=33212
|
| |
|
|
| |
svn path=/trunk/; revision=33201
|
| |
|
|
|
|
|
|
|
| |
2007-02-09 William Jon McCann <mccann@jhu.edu>
* e-shell-nm-glib.c: Fix the build. Fixes #403744
svn path=/trunk/; revision=33194
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
2006-01-22 Srinivasa Ragavan <sragavan@novell.com>
** Committing Ebby Wiselyn's patch for GtkPrint API migration.
svn path=/trunk/; revision=33134
|
| |
|
|
|
|
|
|
| |
2006-12-03 Harish Krishnaswamy <kharish@novell.com>
* e-shell.c: (impl_dispose): Fix memory leak of iid.
svn path=/trunk/; revision=33041
|
| |
|
|
|
|
|
|
|
| |
2006-11-29 Chris Halls <halls@debian.org>
* main.c: Register import eplugin type.
Fixes bug #372528.
svn path=/trunk/; revision=33033
|
| |
|
|
|
|
|
|
|
| |
2006-10-17 Harish Krishnaswamy <kharish@novell.com>
* main.c: (show_development_warning): Update last
stable version.
svn path=/trunk/; revision=32903
|
| |
|
|
| |
svn path=/trunk/; revision=32897
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2006-10-15 Francisco Javier F. Serrador <serrador@openshine.com>
* addressbook/gui/widgets/eab-contact-display.c:
addressbook/importers/evolution-ldif-importer.c
addressbook/importers/evolution-vcard-importer.c
calendar/importers/icalendar-importer.c
plugins/groupwise-features/properties.glade
plugins/mailing-list-actions/org-gnome-mailing-list-actions.eplug.xml
plugins/save-attachments/org-gnome-save-attachments.xml
shell/shell.error.xml : Make some string improvements to allow better
use of gettext compendia.
svn path=/trunk/; revision=32879
|
| |
|
|
| |
svn path=/trunk/; revision=32869
|