diff options
author | Xan Lopez <xlopez@igalia.com> | 2011-09-04 00:30:59 +0800 |
---|---|---|
committer | Xan Lopez <xlopez@igalia.com> | 2011-09-04 00:31:36 +0800 |
commit | e7fa362332fd9dae8ade423e12c24bb3ab1d3ac6 (patch) | |
tree | 27173f413be6d35c0e0ba6cc1a55e9825b04b628 | |
parent | 4f6da94c96d77a296e185c0fcf35ca74ddeee3a2 (diff) | |
download | gsoc2013-epiphany-e7fa362332fd9dae8ade423e12c24bb3ab1d3ac6.tar.gz gsoc2013-epiphany-e7fa362332fd9dae8ade423e12c24bb3ab1d3ac6.tar.zst gsoc2013-epiphany-e7fa362332fd9dae8ade423e12c24bb3ab1d3ac6.zip |
HACKING: remove dubious guideline, add guideline for headers
-rw-r--r-- | HACKING | 14 |
1 files changed, 8 insertions, 6 deletions
@@ -1,15 +1,17 @@ In order to keep the code nice and clean we have a few requirements you'll need to stick to in order to get your patch accepted: -- use 2-space no-tabs for indentation (mandatory on new files, old ones will +- Use 2-space no-tabs for indentation (mandatory on new files, old ones will be re-indented eventually. When modifying an existing file with 8-space - indentation keep the old style please) -- Use K&R style for the braces + indentation keep the old style please). +- Use K&R style for the braces. - No braces for one line control clauses. -- please compare with NULL or FALSE isntead of using "!" -- callback functions have a suffix _cb -- all files have to be encoded in UTF-8 +- Callback functions have a suffix _cb. +- All files have to be encoded in UTF-8. - Use char/int/double/..., not gchar/gint/gdouble/... types. +- All implementation files must include first "config.h", followed by + the primary header, followed by a blank line, followed by all the + other headers sorted alphabetically. - data/kr-gnome-indent.cfg is provided as a reference config file for the uncrustify program to get correct indentation in new files. |