aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNot Zed <NotZed@Ximian.com>2004-06-14 10:46:03 +0800
committerMichael Zucci <zucchi@src.gnome.org>2004-06-14 10:46:03 +0800
commitac86e91fbd40e9a9336a7591110010b54f6014d9 (patch)
tree40358cb3082c36c11ab02293d84f3e7d5612e031
parent4aa7df085b273c170f09380b106116d9809f1d84 (diff)
downloadgsoc2013-evolution-ac86e91fbd40e9a9336a7591110010b54f6014d9.tar.gz
gsoc2013-evolution-ac86e91fbd40e9a9336a7591110010b54f6014d9.tar.zst
gsoc2013-evolution-ac86e91fbd40e9a9336a7591110010b54f6014d9.zip
use g_ascii_strcasecmp. (smtp_connect): do not re-helo after we've
2004-06-14 Not Zed <NotZed@Ximian.com> * providers/smtp/camel-smtp-transport.c (smtp_data): use g_ascii_strcasecmp. (smtp_connect): do not re-helo after we've authenticated. This was a misreading of the spec. We must only re-helo after a transport layer negotiation. svn path=/trunk/; revision=26329
-rw-r--r--camel/ChangeLog8
-rw-r--r--camel/providers/smtp/camel-smtp-transport.c11
2 files changed, 9 insertions, 10 deletions
diff --git a/camel/ChangeLog b/camel/ChangeLog
index 402c331b9f..52468b21d8 100644
--- a/camel/ChangeLog
+++ b/camel/ChangeLog
@@ -1,3 +1,11 @@
+2004-06-14 Not Zed <NotZed@Ximian.com>
+
+ * providers/smtp/camel-smtp-transport.c (smtp_data): use
+ g_ascii_strcasecmp.
+ (smtp_connect): do not re-helo after we've authenticated. This
+ was a misreading of the spec. We must only re-helo after a
+ transport layer negotiation.
+
2004-06-12 Jeffrey Stedfast <fejj@ximian.com>
* providers/imap4/camel-imap4-store.c (imap4_noop): Flush summary
diff --git a/camel/providers/smtp/camel-smtp-transport.c b/camel/providers/smtp/camel-smtp-transport.c
index 18583e6839..3245cc68a1 100644
--- a/camel/providers/smtp/camel-smtp-transport.c
+++ b/camel/providers/smtp/camel-smtp-transport.c
@@ -536,15 +536,6 @@ smtp_connect (CamelService *service, CamelException *ex)
camel_exception_clear (ex);
}
}
-
- /* The spec says we have to re-EHLO, but some servers
- * we won't bother to name don't want you to... so ignore
- * errors.
- */
- if (!smtp_helo (transport, ex) && !transport->connected)
- return FALSE;
-
- camel_exception_clear (ex);
}
return TRUE;
@@ -1287,7 +1278,7 @@ smtp_data (CamelSmtpTransport *transport, CamelMimeMessage *message, CamelExcept
header = (struct _camel_header_raw *) &CAMEL_MIME_PART (message)->headers;
n = header->next;
while (n != NULL) {
- if (!strcasecmp (n->name, "Bcc")) {
+ if (!g_ascii_strcasecmp (n->name, "Bcc")) {
header->next = n->next;
tail->next = n;
n->next = NULL;