StripAndTab() poorly designed for "". It is possible for it to get

called on a zero length string and the code assumes this is not possible.

Reviewed by:	Kevin Dwyer <kevindication> (Bidwatcher author)

1 files changed, 21 insertions, 0 deletions

diff --git a/misc/bidwatcher/files/patch-helpers.cpp b/misc/bidwatcher/files/patch-helpers.cpp
new file mode 100644
index 000000000000..525eff1e2e7e
--- /dev/null
+++ b/misc/bidwatcher/files/patch-helpers.cpp
@@ -0,0 +1,21 @@
+--- helpers.cpp.orig	Sat Dec 21 00:00:42 2002
++++ helpers.cpp	Sun Dec 29 09:31:01 2002
+@@ -344,13 +344,16 @@
+ //////////////////////////////////////////////////////////////////////
+ char * StripAndTab(const char * stringToStrip)
+ {
+-  char *Buff=(char *)malloc(strlen(stringToStrip));
+-  Buff[0]='\0';
+   int buffLength = strlen(stringToStrip);
+   int BuffIdx = 0;
+   int u,c;
+   int IncludeFlag = 5;
+   bool tabFlag = FALSE;
++  if (!buffLength) {
++    ++buffLength;	// some malloc's don't handled malloc(0) well
++  }
++  char *Buff=(char *)malloc(buffLength);
++  Buff[0]='\0';
+   for (u = 0; (u < buffLength);u++) {
+     c = stringToStrip[u];
+     if (c=='<') {