aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEttore Perazzoli <ettore@src.gnome.org>2001-10-12 12:21:19 +0800
committerEttore Perazzoli <ettore@src.gnome.org>2001-10-12 12:21:19 +0800
commite7ea6195482eac08a8ea3239e7751592324791ef (patch)
treecb25f479c172487c98b19402389f4389848ae3e7
parent7bb7bfa68155fd9010a222851c55143c7fbfa0df (diff)
downloadgsoc2013-evolution-e7ea6195482eac08a8ea3239e7751592324791ef.tar.gz
gsoc2013-evolution-e7ea6195482eac08a8ea3239e7751592324791ef.tar.zst
gsoc2013-evolution-e7ea6195482eac08a8ea3239e7751592324791ef.zip
Don't free the folder_command_data here. It is supposed to be freed in the
* e-shell-folder-commands.c (folder_selection_dialog_folder_selected_callback): Don't free the folder_command_data here. It is supposed to be freed in the async callback. The leak that Dan supposedly fixed was probably only due to the fact that the component that was supposed to perform the xfer didn't report a result. Now that xfer actually works, it was triggering the crash instead. [Fixes #9769.] svn path=/trunk/; revision=13615
-rw-r--r--shell/ChangeLog10
-rw-r--r--shell/e-shell-folder-commands.c1
2 files changed, 10 insertions, 1 deletions
diff --git a/shell/ChangeLog b/shell/ChangeLog
index 316c50630e..eadbc94421 100644
--- a/shell/ChangeLog
+++ b/shell/ChangeLog
@@ -1,5 +1,15 @@
2001-10-12 Ettore Perazzoli <ettore@ximian.com>
+ * e-shell-folder-commands.c
+ (folder_selection_dialog_folder_selected_callback): Don't free the
+ folder_command_data here. It is supposed to be freed in the async
+ callback. The leak that Dan supposedly fixed was probably only
+ due to the fact that the component that was supposed to perform
+ the xfer didn't report a result. Now that xfer actually works, it
+ was triggering the crash instead. [Fixes #9769.]
+
+2001-10-12 Ettore Perazzoli <ettore@ximian.com>
+
* e-shell-offline-handler.c (prepare_for_offline): Only invoke
`progress_listener_servant_free()', no need to also do `__fini()'
on it as `__fini()' is also called by the former. [Fixes #12329.]
diff --git a/shell/e-shell-folder-commands.c b/shell/e-shell-folder-commands.c
index 9a7d6008e7..bef14fb5e5 100644
--- a/shell/e-shell-folder-commands.c
+++ b/shell/e-shell-folder-commands.c
@@ -204,7 +204,6 @@ folder_selection_dialog_folder_selected_callback (EShellFolderSelectionDialog *f
folder_command_data);
gtk_widget_destroy (GTK_WIDGET (folder_selection_dialog));
- folder_command_data_free (folder_command_data);
}
static void